[GitHub] [hbase] Apache-HBase commented on pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3784: URL: https://github.com/apache/hbase/pull/3784#issuecomment-951569007 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3784: URL: https://github.com/apache/hbase/pull/3784#issuecomment-951557696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3784: URL: https://github.com/apache/hbase/pull/3784#issuecomment-951554674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3795: HBASE-26396 Remove duplicate thread creation during migrating rsgroup

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3795: URL: https://github.com/apache/hbase/pull/3795#issuecomment-951546927 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] YutSean commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
YutSean commented on a change in pull request #3784: URL: https://github.com/apache/hbase/pull/3784#discussion_r736128832 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java ## @@ -60,6 +60,9 @@ private static final String JVMVersion =

[jira] [Commented] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-10-25 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434091#comment-17434091 ] chenglei commented on HBASE-26384: -- [~zhangduo], Would you please help me have review at your

[jira] [Comment Edited] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-10-25 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434091#comment-17434091 ] chenglei edited comment on HBASE-26384 at 10/26/21, 3:31 AM: - [~zhangduo],

[jira] [Commented] (HBASE-26390) Upload src tarball to nightlies for nightly jobs

2021-10-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434089#comment-17434089 ] Hudson commented on HBASE-26390: Results for branch branch-2.4 [build #222 on

[GitHub] [hbase] Apache9 commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
Apache9 commented on a change in pull request #3784: URL: https://github.com/apache/hbase/pull/3784#discussion_r736109066 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java ## @@ -60,6 +60,9 @@ private static final String JVMVersion =

[GitHub] [hbase] Apache-HBase commented on pull request #3795: HBASE-26396 Remove duplicate thread creation during migrating rsgroup

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3795: URL: https://github.com/apache/hbase/pull/3795#issuecomment-951514268 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] YutSean commented on pull request #3776: HBASE-26325 Backport the HBASE-26305 to branch-1. Move NavigableSet add operation to writer thread in BucketCache

2021-10-25 Thread GitBox
YutSean commented on pull request #3776: URL: https://github.com/apache/hbase/pull/3776#issuecomment-951514324 From the results, it seems that the test JVM crashed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] YutSean commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
YutSean commented on a change in pull request #3784: URL: https://github.com/apache/hbase/pull/3784#discussion_r736106026 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java ## @@ -60,6 +60,9 @@ private static final String JVMVersion =

[GitHub] [hbase] YutSean commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
YutSean commented on a change in pull request #3784: URL: https://github.com/apache/hbase/pull/3784#discussion_r736105791 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java ## @@ -60,6 +60,9 @@ private static final String JVMVersion =

[GitHub] [hbase] comnetwork commented on pull request #3794: HBASE-26394 Cache in RSRpcServices.executeProcedures does not take ef…

2021-10-25 Thread GitBox
comnetwork commented on pull request #3794: URL: https://github.com/apache/hbase/pull/3794#issuecomment-951497469 @sunhelly, @Apache9 , thank you very much for review, checkstyle error already fixed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache9 commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
Apache9 commented on a change in pull request #3784: URL: https://github.com/apache/hbase/pull/3784#discussion_r736075454 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java ## @@ -60,6 +60,9 @@ private static final String JVMVersion =

[GitHub] [hbase] Apache-HBase commented on pull request #3795: HBASE-26396 Remove duplicate thread creation during migrating rsgroup

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3795: URL: https://github.com/apache/hbase/pull/3795#issuecomment-951463808 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[jira] [Comment Edited] (HBASE-26304) Reflect out-of-band locality improvements in served requests

2021-10-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433138#comment-17433138 ] Bryan Beaudreault edited comment on HBASE-26304 at 10/26/21, 12:34 AM:

[jira] [Created] (HBASE-26396) Remove duplicate thread creation during migrating rsgroup

2021-10-25 Thread Zhuoyue Huang (Jira)
Zhuoyue Huang created HBASE-26396: - Summary: Remove duplicate thread creation during migrating rsgroup Key: HBASE-26396 URL: https://issues.apache.org/jira/browse/HBASE-26396 Project: HBase

[GitHub] [hbase] YutSean commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
YutSean commented on a change in pull request #3784: URL: https://github.com/apache/hbase/pull/3784#discussion_r736047488 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java ## @@ -60,6 +60,9 @@ private static final String JVMVersion =

[jira] [Commented] (HBASE-26047) [JDK17] Track JDK17 unit test failures

2021-10-25 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434035#comment-17434035 ] Huaxiang Sun commented on HBASE-26047: -- [~xytss123], I linked HBASE-26392.  > [JDK17] Track JDK17

[GitHub] [hbase] huaxiangsun merged pull request #3789: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering bal…

2021-10-25 Thread GitBox
huaxiangsun merged pull request #3789: URL: https://github.com/apache/hbase/pull/3789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] huaxiangsun commented on pull request #3788: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering bal…

2021-10-25 Thread GitBox
huaxiangsun commented on pull request #3788: URL: https://github.com/apache/hbase/pull/3788#issuecomment-951390188 Got it, merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] huaxiangsun merged pull request #3788: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering bal…

2021-10-25 Thread GitBox
huaxiangsun merged pull request #3788: URL: https://github.com/apache/hbase/pull/3788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-26373) Release 2.3.7

2021-10-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-26373. -- Resolution: Done > Release 2.3.7 > - > > Key: HBASE-26373 >

[jira] [Resolved] (HBASE-26381) Send announce email

2021-10-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-26381. -- Resolution: Done > Send announce email > --- > > Key:

[GitHub] [hbase] clarax commented on pull request #3788: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering bal…

2021-10-25 Thread GitBox
clarax commented on pull request #3788: URL: https://github.com/apache/hbase/pull/3788#issuecomment-951299695 > @clarax, can you check what is the check failure? Thanks. It is TEST-org.apache.hadoop.hbase.replication.TestMasterReplication.xml.[failed-to-read] This a known issue on

[GitHub] [hbase] huaxiangsun commented on pull request #3788: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering bal…

2021-10-25 Thread GitBox
huaxiangsun commented on pull request #3788: URL: https://github.com/apache/hbase/pull/3788#issuecomment-951195400 @clarax, can you check what is the check failure? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] huaxiangsun commented on pull request #3729: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering Bal…

2021-10-25 Thread GitBox
huaxiangsun commented on pull request #3729: URL: https://github.com/apache/hbase/pull/3729#issuecomment-951192158 > If the weight is set to 0, it won't be considered for evaluation. However the 1 out 4 generator will still waste time generating candidates for rack balance. Therefor I

[GitHub] [hbase] huaxiangsun merged pull request #3729: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering Bal…

2021-10-25 Thread GitBox
huaxiangsun merged pull request #3729: URL: https://github.com/apache/hbase/pull/3729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ndimiduk commented on pull request #3770: HBASE-26380 Add 2.3.7 to downloads page

2021-10-25 Thread GitBox
ndimiduk commented on pull request #3770: URL: https://github.com/apache/hbase/pull/3770#issuecomment-951123578 Thanks @Apache9 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-10-25 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r735748629 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -348,8 +353,14 @@ private

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-10-25 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r735746314 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1895,6 +1900,22 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3794: HBASE-26394 Cache in RSRpcServices.executeProcedures does not take ef…

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3794: URL: https://github.com/apache/hbase/pull/3794#issuecomment-951066529 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-26390) Upload src tarball to nightlies for nightly jobs

2021-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26390: -- Fix Version/s: 2.4.9 1.7.2 3.0.0-alpha-2

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-10-25 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r735736298 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -537,4 +547,17 @@ protected

[jira] [Resolved] (HBASE-26390) Upload src tarball to nightlies for nightly jobs

2021-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26390. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+ and branch-1. Thanks

[jira] [Updated] (HBASE-26390) Upload src tarball to nightlies for nightly jobs

2021-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26390: -- Component/s: scripts jenkins > Upload src tarball to nightlies for nightly jobs >

[GitHub] [hbase] Apache9 merged pull request #3793: HBASE-26390 Upload src tarball to nightlies for nightly jobs

2021-10-25 Thread GitBox
Apache9 merged pull request #3793: URL: https://github.com/apache/hbase/pull/3793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-10-25 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r735718786 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/FileBasedStoreFileCleaner.java ## @@ -0,0 +1,191 @@ +/** + * Licensed

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-10-25 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r735718289 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java ## @@ -176,7 +176,7 @@

[GitHub] [hbase] Apache9 commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

2021-10-25 Thread GitBox
Apache9 commented on a change in pull request #3784: URL: https://github.com/apache/hbase/pull/3784#discussion_r735713973 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java ## @@ -60,6 +60,9 @@ private static final String JVMVersion =

[GitHub] [hbase] Apache9 commented on pull request #3794: HBASE-26394 Cache in RSRpcServices.executeProcedures does not take ef…

2021-10-25 Thread GitBox
Apache9 commented on pull request #3794: URL: https://github.com/apache/hbase/pull/3794#issuecomment-951039652 Please fix the checkstyle issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-26395) Add 1.4.14 to download page

2021-10-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26395: - Summary: Add 1.4.14 to download page Key: HBASE-26395 URL: https://issues.apache.org/jira/browse/HBASE-26395 Project: HBase Issue Type: Sub-task

[jira] [Work started] (HBASE-26395) Add 1.4.14 to download page

2021-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26395 started by Duo Zhang. - > Add 1.4.14 to download page > --- > > Key:

[jira] [Resolved] (HBASE-26358) Put up 1.4.14RC0

2021-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26358. --- Resolution: Fixed Done. > Put up 1.4.14RC0 > > > Key: HBASE-26358

[jira] [Updated] (HBASE-26358) Put up 1.4.14RC0

2021-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26358: -- Component/s: community > Put up 1.4.14RC0 > > > Key: HBASE-26358 >

[GitHub] [hbase] Apache-HBase commented on pull request #3794: HBASE-26394 Cache in RSRpcServices.executeProcedures does not take ef…

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3794: URL: https://github.com/apache/hbase/pull/3794#issuecomment-950991418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-10-25 Thread GitBox
wchevreuil commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r735493337 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1895,6 +1900,22 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3794: HBASE-26394 Cache in RSRpcServices.executeProcedures does not take ef…

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3794: URL: https://github.com/apache/hbase/pull/3794#issuecomment-950885479 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-26394) Cache in RSRpcServices.executeProcedures does not take effect

2021-10-25 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei reassigned HBASE-26394: Assignee: chenglei > Cache in RSRpcServices.executeProcedures does not take effect >

[jira] [Updated] (HBASE-26394) Cache in RSRpcServices.executeProcedures does not take effect

2021-10-25 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26394: - Status: Patch Available (was: Open) > Cache in RSRpcServices.executeProcedures does not take effect >

[GitHub] [hbase] comnetwork opened a new pull request #3794: HBASE-26394 Cache in RSRpcServices.executeProcedures does not take ef…

2021-10-25 Thread GitBox
comnetwork opened a new pull request #3794: URL: https://github.com/apache/hbase/pull/3794 …fect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26394) Cache in RSRpcServices.executeProcedures does not take effect

2021-10-25 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26394: - Description: In {{RSRpcServices.executeProcedures}} , we use tdCache to avoid reading from the

[jira] [Created] (HBASE-26394) Cache in RSRpcServices.executeProcedures does not take effect

2021-10-25 Thread chenglei (Jira)
chenglei created HBASE-26394: Summary: Cache in RSRpcServices.executeProcedures does not take effect Key: HBASE-26394 URL: https://issues.apache.org/jira/browse/HBASE-26394 Project: HBase Issue

[jira] [Updated] (HBASE-26394) Cache in RSRpcServices.executeProcedures does not take effect

2021-10-25 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26394: - Description: In > Cache in RSRpcServices.executeProcedures does not take effect >

[GitHub] [hbase] Apache-HBase commented on pull request #3776: HBASE-26325 Backport the HBASE-26305 to branch-1. Move NavigableSet add operation to writer thread in BucketCache

2021-10-25 Thread GitBox
Apache-HBase commented on pull request #3776: URL: https://github.com/apache/hbase/pull/3776#issuecomment-950759493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m