[jira] [Commented] (HBASE-26320) Separate Log Cleaner DirScanPool to prevent the OLDWALs from filling up the disk when archive is large

2021-11-08 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440955#comment-17440955 ] Pankaj Kumar commented on HBASE-26320: -- Thanks [~zyork] for merging this in master

[GitHub] [hbase] d-c-manning commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
d-c-manning commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r745329686 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java ## @@ -73,9 +73,11 @@ * @return A ServerName instance

[GitHub] [hbase] sunhelly commented on pull request #3825: HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…

2021-11-08 Thread GitBox
sunhelly commented on pull request #3825: URL: https://github.com/apache/hbase/pull/3825#issuecomment-963870288 Thanks, @Apache9 . The main advantage here is that the first compaction after split can be a minor compaction instead of old major compaction, because only reference files should

[jira] [Assigned] (HBASE-26422) Support only select reference files for the compaction after split

2021-11-08 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha reassigned HBASE-26422: -- Assignee: Xiaolin Ha > Support only select reference files for the compaction after split > -

[jira] [Updated] (HBASE-26422) Support only select reference files for the compaction after split

2021-11-08 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26422: --- Description: The reference files are those with these patterns, . and =-.. We can compact these re

[GitHub] [hbase] Apache-HBase commented on pull request #3829: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3829: URL: https://github.com/apache/hbase/pull/3829#issuecomment-963865440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 42s

[jira] [Commented] (HBASE-26337) Optimization for weighted random generators

2021-11-08 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440914#comment-17440914 ] Anoop Sam John commented on HBASE-26337: When we dont care/consider the locality

[jira] [Comment Edited] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440908#comment-17440908 ] Andrew Kyle Purtell edited comment on HBASE-26384 at 11/9/21, 5:40 AM: ---

[GitHub] [hbase] Apache-HBase commented on pull request #3829: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3829: URL: https://github.com/apache/hbase/pull/3829#issuecomment-963834078 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s

[jira] [Comment Edited] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440908#comment-17440908 ] Andrew Kyle Purtell edited comment on HBASE-26384 at 11/9/21, 5:37 AM: ---

[jira] [Comment Edited] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440907#comment-17440907 ] Andrew Kyle Purtell edited comment on HBASE-26384 at 11/9/21, 5:35 AM: ---

[jira] [Updated] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26384: Fix Version/s: (was: 2.4.9) > Segment already flushed to hfile may still be re

[jira] [Commented] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440908#comment-17440908 ] Andrew Kyle Purtell commented on HBASE-26384: - Reverted from branch-2.4. >

[jira] [Reopened] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reopened HBASE-26384: - Recent branch-2.4 is showing dataloss in an integration test scenario with ADAPTIVE

[GitHub] [hbase] Apache-HBase commented on pull request #3828: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3828: URL: https://github.com/apache/hbase/pull/3828#issuecomment-963827842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s

[GitHub] [hbase] Apache-HBase commented on pull request #3823: HBASE-26432 enable tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-963826335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3823: HBASE-26432 enable tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-963824270 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35

[GitHub] [hbase] Apache-HBase commented on pull request #3823: HBASE-26432 enable tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-963821478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[GitHub] [hbase] ArkenKiran commented on pull request #3823: HBASE-26432 enable tracing from shell

2021-11-08 Thread GitBox
ArkenKiran commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-963817376 @ndimiduk can you please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ArkenKiran commented on pull request #3824: HBASE-26432 enabled tracing from shell

2021-11-08 Thread GitBox
ArkenKiran commented on pull request #3824: URL: https://github.com/apache/hbase/pull/3824#issuecomment-963817125 @ndimiduk can you please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #3828: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3828: URL: https://github.com/apache/hbase/pull/3828#issuecomment-963800883 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s

[GitHub] [hbase] Apache-HBase commented on pull request #3829: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3829: URL: https://github.com/apache/hbase/pull/3829#issuecomment-963784261 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[jira] [Commented] (HBASE-25322) Redundant Reference file in bottom region of split

2021-11-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440876#comment-17440876 ] Hudson commented on HBASE-25322: Results for branch branch-2.4 [build #234 on b

[GitHub] [hbase] GeorryHuang commented on pull request #3815: HBASE-26412 Handle sink failure in RegionReplicationSink

2021-11-08 Thread GitBox
GeorryHuang commented on pull request #3815: URL: https://github.com/apache/hbase/pull/3815#issuecomment-963780922 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (HBASE-26430) Increase DefaultHeapMemoryTuner log level

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26430: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Pa

[jira] [Updated] (HBASE-26430) Increase DefaultHeapMemoryTuner log level

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26430: Fix Version/s: (was: 2.4.9) > Increase DefaultHeapMemoryTuner log level >

[GitHub] [hbase] apurtell merged pull request #3820: HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO

2021-11-08 Thread GitBox
apurtell merged pull request #3820: URL: https://github.com/apache/hbase/pull/3820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Updated] (HBASE-26429) HeapMemoryManager fails memstore flushes with NPE if enabled

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26429: Fix Version/s: 2.3.8 > HeapMemoryManager fails memstore flushes with NPE if enable

[jira] [Updated] (HBASE-26309) Balancer tends to move regions to the server at the end of list

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26309: Fix Version/s: 2.3.8 > Balancer tends to move regions to the server at the end of

[jira] [Updated] (HBASE-26309) Balancer tends to move regions to the server at the end of list

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26309: Fix Version/s: (was: 2.3.8) > Balancer tends to move regions to the server at

[GitHub] [hbase] apurtell merged pull request #3819: HBASE-26429 HeapMemoryManager fails memstore flushes with NPE if enabled

2021-11-08 Thread GitBox
apurtell merged pull request #3819: URL: https://github.com/apache/hbase/pull/3819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Updated] (HBASE-26429) HeapMemoryManager fails memstore flushes with NPE if enabled

2021-11-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26429: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Pa

[GitHub] [hbase] Apache-HBase commented on pull request #3828: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3828: URL: https://github.com/apache/hbase/pull/3828#issuecomment-963739843 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6

[GitHub] [hbase] clarax opened a new pull request #3828: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
clarax opened a new pull request #3828: URL: https://github.com/apache/hbase/pull/3828 backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[GitHub] [hbase] Apache-HBase commented on pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3826: URL: https://github.com/apache/hbase/pull/3826#issuecomment-963715236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s

[GitHub] [hbase] Apache9 commented on pull request #3825: HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…

2021-11-08 Thread GitBox
Apache9 commented on pull request #3825: URL: https://github.com/apache/hbase/pull/3825#issuecomment-963696081 What is the advantage here to use HFileLink? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HBASE-26337) Optimization for weighted random generators

2021-11-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440827#comment-17440827 ] Duo Zhang commented on HBASE-26337: --- [~claraxiong] Please open a PR for branch-2? The

[GitHub] [hbase] Apache9 closed pull request #3827: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache9 closed pull request #3827: URL: https://github.com/apache/hbase/pull/3827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [hbase] Apache9 commented on pull request #3827: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache9 commented on pull request #3827: URL: https://github.com/apache/hbase/pull/3827#issuecomment-963693464 Close as #3732 has already been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hbase] Apache9 merged pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache9 merged pull request #3732: URL: https://github.com/apache/hbase/pull/3732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [hbase] Apache9 commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
Apache9 commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r745187340 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/AbstractMultiOutputCompactor.java ## @@ -79,5 +79,6 @@ protected

[GitHub] [hbase] Apache-HBase commented on pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3786: URL: https://github.com/apache/hbase/pull/3786#issuecomment-963689036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[GitHub] [hbase] Apache-HBase commented on pull request #3827: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3827: URL: https://github.com/apache/hbase/pull/3827#issuecomment-963674953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #3827: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3827: URL: https://github.com/apache/hbase/pull/3827#issuecomment-963671632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59

[GitHub] [hbase] Apache-HBase commented on pull request #3827: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3827: URL: https://github.com/apache/hbase/pull/3827#issuecomment-963668947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3786: URL: https://github.com/apache/hbase/pull/3786#issuecomment-963646789 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37

[GitHub] [hbase] clarax edited a comment on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
clarax edited a comment on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-963601867 > The only failure TEST-org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.xml.[failed-to-read] is known unrelated issue. > > The javac complaint is

[GitHub] [hbase] clarax opened a new pull request #3827: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
clarax opened a new pull request #3827: URL: https://github.com/apache/hbase/pull/3827 a clean PR to re-run recommit checks for https://github.com/apache/hbase/pull/3732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [hbase] apurtell commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
apurtell commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r745123322 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -3343,6 +3346,55 @@ boolean waitUntilNoRegionsInTrans

[GitHub] [hbase] apurtell commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
apurtell commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r745121873 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -938,6 +938,8 @@ private void finishActiveMasterInitialization(

[GitHub] [hbase] Apache-HBase commented on pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3826: URL: https://github.com/apache/hbase/pull/3826#issuecomment-963603846 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 15s

[GitHub] [hbase] clarax commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
clarax commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-963601867 > The only failure TEST-org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.xml.[failed-to-read] is known unrelated issue. > > The javac complaint is about o

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-963574009 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3786: URL: https://github.com/apache/hbase/pull/3786#issuecomment-963558439 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-963551371 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58

[GitHub] [hbase] BukrosSzabolcs commented on pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
BukrosSzabolcs commented on pull request #3786: URL: https://github.com/apache/hbase/pull/3786#issuecomment-963512850 @Apache9 Rebased my changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] virajjasani commented on pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
virajjasani commented on pull request #3826: URL: https://github.com/apache/hbase/pull/3826#issuecomment-963501153 > Looks good, just a suggested Extract Method. What sort of test should we have to exercise this new code path? Done, added new test. Thanks -- This is an automated m

[GitHub] [hbase] virajjasani commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
virajjasani commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r745029676 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -3343,6 +3346,55 @@ boolean waitUntilNoRegionsInTr

[GitHub] [hbase] virajjasani commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
virajjasani commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r745029546 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -938,6 +938,8 @@ private void finishActiveMasterInitializati

[GitHub] [hbase] virajjasani commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
virajjasani commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r745027686 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java ## @@ -73,9 +73,11 @@ * @return A ServerName instance

[jira] [Commented] (HBASE-26304) Reflect out-of-band locality improvements in served requests

2021-11-08 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440687#comment-17440687 ] Huaxiang Sun commented on HBASE-26304: -- Thanks [~bbeaudreault] . Will try to look a

[GitHub] [hbase] Apache-HBase commented on pull request #3825: HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3825: URL: https://github.com/apache/hbase/pull/3825#issuecomment-963483259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18

[GitHub] [hbase] Apache-HBase commented on pull request #3825: HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3825: URL: https://github.com/apache/hbase/pull/3825#issuecomment-963475925 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0

[GitHub] [hbase] d-c-manning commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
d-c-manning commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r744990831 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -938,6 +938,8 @@ private void finishActiveMasterInitializati

[jira] [Commented] (HBASE-25322) Redundant Reference file in bottom region of split

2021-11-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440656#comment-17440656 ] Hudson commented on HBASE-25322: Results for branch branch-2 [build #389 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-963435853 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[GitHub] [hbase] gjacoby126 commented on a change in pull request #3826: HBASE-26433 Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread GitBox
gjacoby126 commented on a change in pull request #3826: URL: https://github.com/apache/hbase/pull/3826#discussion_r744972053 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java ## @@ -73,9 +73,11 @@ * @return A ServerName instance

[jira] [Created] (HBASE-26433) Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions

2021-11-08 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-26433: Summary: Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions Key: HBASE-26433 URL: https://issues.apache.org/jira/browse/HBASE-

[GitHub] [hbase] clarax edited a comment on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
clarax edited a comment on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-963386266 The only failure TEST-org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.xml.[failed-to-read] is known unrelated issue. The javac complaint is about

[GitHub] [hbase] clarax commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
clarax commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-963386266 The only failure TEST-org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.xml.[failed-to-read] is known unrelated issue. The javac complaint is about out a

[jira] [Commented] (HBASE-26304) Reflect out-of-band locality improvements in served requests

2021-11-08 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440580#comment-17440580 ] Bryan Beaudreault commented on HBASE-26304: --- This has been rolled out to ~80 c

[GitHub] [hbase] Apache9 commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
Apache9 commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r744858544 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/AbstractMultiOutputCompactor.java ## @@ -79,5 +79,6 @@ protected

[GitHub] [hbase] Apache-HBase commented on pull request #3825: HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3825: URL: https://github.com/apache/hbase/pull/3825#issuecomment-963284372 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r744817192 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/AbstractMultiOutputCompactor.java ## @@ -79,5 +79,6 @@ pro

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r744817878 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BrokenStoreFileCleaner.java ## @@ -0,0 +1,191 @@ +/** + * Licensed to

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r744817878 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BrokenStoreFileCleaner.java ## @@ -0,0 +1,191 @@ +/** + * Licensed to

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r744817192 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/AbstractMultiOutputCompactor.java ## @@ -79,5 +79,6 @@ pro

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r744806941 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BrokenStoreFileCleaner.java ## @@ -0,0 +1,191 @@ +/** + * Licensed to

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3786: HBASE-26271: Cleanup the broken store files under data directory

2021-11-08 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3786: URL: https://github.com/apache/hbase/pull/3786#discussion_r744806633 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BrokenStoreFileCleaner.java ## @@ -0,0 +1,191 @@ +/** + * Licensed to

[jira] [Comment Edited] (HBASE-26286) Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-08 Thread Szabolcs Bukros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440521#comment-17440521 ] Szabolcs Bukros edited comment on HBASE-26286 at 11/8/21, 2:52 PM: ---

[jira] [Commented] (HBASE-26286) Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-08 Thread Szabolcs Bukros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440521#comment-17440521 ] Szabolcs Bukros commented on HBASE-26286: - [~zhangduo]  {quote} IIRC, our decis

[GitHub] [hbase] sunhelly opened a new pull request #3825: HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…

2021-11-08 Thread GitBox
sunhelly opened a new pull request #3825: URL: https://github.com/apache/hbase/pull/3825 …n splitting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[jira] [Commented] (HBASE-26428) Add hadoop 2.10.1, 3.2.2 and 3.3.1 to our hadoop checks

2021-11-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440464#comment-17440464 ] Hudson commented on HBASE-26428: Results for branch master [build #437 on build

[GitHub] [hbase] Apache-HBase commented on pull request #3824: HBASE-26432 enabled tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3824: URL: https://github.com/apache/hbase/pull/3824#issuecomment-963053932 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3824: HBASE-26432 enabled tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3824: URL: https://github.com/apache/hbase/pull/3824#issuecomment-963052453 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] Apache-HBase commented on pull request #3823: HBASE-26432 enable tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-963048689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45

[GitHub] [hbase] Apache-HBase commented on pull request #3824: HBASE-26432 enabled tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3824: URL: https://github.com/apache/hbase/pull/3824#issuecomment-963048255 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22

[GitHub] [hbase] Apache-HBase commented on pull request #3823: HBASE-26432 enable tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-963045692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #3823: HBASE-26432 enable tracing from shell

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-963041718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20

[jira] [Updated] (HBASE-26432) Add tracing support in hbase shell

2021-11-08 Thread Kiran Kumar Maturi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kiran Kumar Maturi updated HBASE-26432: --- Component/s: tracing > Add tracing support in hbase shell >

[jira] [Created] (HBASE-26432) Add tracing support in hbase shell

2021-11-08 Thread Kiran Kumar Maturi (Jira)
Kiran Kumar Maturi created HBASE-26432: -- Summary: Add tracing support in hbase shell Key: HBASE-26432 URL: https://issues.apache.org/jira/browse/HBASE-26432 Project: HBase Issue Type: Im

[jira] [Assigned] (HBASE-26265) Update ref guide to mention the new store file tracker implementations

2021-11-08 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil reassigned HBASE-26265: Assignee: Wellington Chevreuil > Update ref guide to mention the new stor

[jira] [Commented] (HBASE-26265) Update ref guide to mention the new store file tracker implementations

2021-11-08 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440341#comment-17440341 ] Wellington Chevreuil commented on HBASE-26265: -- Sure, I can pick this one.

[jira] [Commented] (HBASE-26262) Implement a region based store file tracker

2021-11-08 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440340#comment-17440340 ] Wellington Chevreuil commented on HBASE-26262: -- Hi [~zhangduo] , we don't.

[GitHub] [hbase] Apache-HBase commented on pull request #3732: HBASE-26337 Optimization for weighted random generators

2021-11-08 Thread GitBox
Apache-HBase commented on pull request #3732: URL: https://github.com/apache/hbase/pull/3732#issuecomment-962975824 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[jira] [Resolved] (HBASE-26431) Add hadoop 3.3.x to our hadoop version support matrix

2021-11-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26431. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~weichiu] for reviewing.

[GitHub] [hbase] Apache9 merged pull request #3822: HBASE-26431 Add hadoop 3.3.x to our hadoop version support matrix

2021-11-08 Thread GitBox
Apache9 merged pull request #3822: URL: https://github.com/apache/hbase/pull/3822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.