[GitHub] [hbase] Apache-HBase commented on pull request #3864: HBASE-26416 Implement a new method for region replication instead of …

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3864: URL: https://github.com/apache/hbase/pull/3864#issuecomment-974603881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[GitHub] [hbase] Apache9 opened a new pull request #3864: HBASE-26416 Implement a new method for region replication instead of …

2021-11-19 Thread GitBox
Apache9 opened a new pull request #3864: URL: https://github.com/apache/hbase/pull/3864 …using replay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[jira] [Created] (HBASE-26475) The flush and compact methods in HTU should skip processing secondary replicas

2021-11-19 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26475: - Summary: The flush and compact methods in HTU should skip processing secondary replicas Key: HBASE-26475 URL: https://issues.apache.org/jira/browse/HBASE-26475 Project: HBa

[GitHub] [hbase] Apache9 commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
Apache9 commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974593183 The comment of the method says it will only call System.exit when a nonzero return code is returned from the run method? -- This is an automated message from the Apache Git Serv

[GitHub] [hbase] Apache9 commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
Apache9 commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r753632988 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java ## @@ -854,15 +860,75 @@ public long restoreOrCloneSn

[GitHub] [hbase] Apache9 commented on a change in pull request #3852: HBASE-26458 Update Snapshot TTL doc

2021-11-19 Thread GitBox
Apache9 commented on a change in pull request #3852: URL: https://github.com/apache/hbase/pull/3852#discussion_r753632040 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -3150,23 +3150,24 @@ TTL some notion of optional TTL (and optional default TTL) for snapshots

[GitHub] [hbase] Apache9 commented on pull request #3863: Tracing Spans of RPCs should follow otel semantic conventions

2021-11-19 Thread GitBox
Apache9 commented on pull request #3863: URL: https://github.com/apache/hbase/pull/3863#issuecomment-974590906 Let's open separated PRs for the different issues? It will be easier to review -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] Apache-HBase commented on pull request #3863: Tracing Spans of RPCs should follow otel semantic conventions

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3863: URL: https://github.com/apache/hbase/pull/3863#issuecomment-974589801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 50s

[GitHub] [hbase] Apache-HBase commented on pull request #3863: Tracing Spans of RPCs should follow otel semantic conventions

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3863: URL: https://github.com/apache/hbase/pull/3863#issuecomment-974587261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[GitHub] [hbase] Apache-HBase commented on pull request #3863: Tracing Spans of RPCs should follow otel semantic conventions

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3863: URL: https://github.com/apache/hbase/pull/3863#issuecomment-974572879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0

[GitHub] [hbase] ndimiduk commented on a change in pull request #3863: Tracing Spans of RPCs should follow otel semantic conventions

2021-11-19 Thread GitBox
ndimiduk commented on a change in pull request #3863: URL: https://github.com/apache/hbase/pull/3863#discussion_r753609492 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java ## @@ -90,16 +102,33 @@ public void tearDown()

[jira] [Created] (HBASE-26473) Introduce `db.hbase.container_operations` span attribute

2021-11-19 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26473: Summary: Introduce `db.hbase.container_operations` span attribute Key: HBASE-26473 URL: https://issues.apache.org/jira/browse/HBASE-26473 Project: HBase Issu

[jira] [Updated] (HBASE-26474) Implement connection-level attributes

2021-11-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26474: - Status: Patch Available (was: Open) > Implement connection-level attributes > -

[jira] [Updated] (HBASE-26473) Introduce `db.hbase.container_operations` span attribute

2021-11-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26473: - Status: Patch Available (was: Open) > Introduce `db.hbase.container_operations` span attribute

[jira] [Updated] (HBASE-26472) Adhere to semantic conventions regarding table data operations

2021-11-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26472: - Status: Patch Available (was: Open) > Adhere to semantic conventions regarding table data opera

[jira] [Assigned] (HBASE-26473) Introduce `db.hbase.container_operations` span attribute

2021-11-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-26473: Assignee: Nick Dimiduk > Introduce `db.hbase.container_operations` span attribute > -

[jira] [Updated] (HBASE-26471) Move tracing semantic attributes to their own class

2021-11-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26471: - Status: Patch Available (was: Open) > Move tracing semantic attributes to their own class > ---

[GitHub] [hbase] ndimiduk opened a new pull request #3863: Tracing Spans of RPCs should follow otel semantic conventions

2021-11-19 Thread GitBox
ndimiduk opened a new pull request #3863: URL: https://github.com/apache/hbase/pull/3863 A first set of patches to bring our implementation around to the conventions as described. Focuses primarily on spans from HTable and a couple other connection-level methods. Applicable reference is h

[jira] [Created] (HBASE-26474) Implement connection-level attributes

2021-11-19 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26474: Summary: Implement connection-level attributes Key: HBASE-26474 URL: https://issues.apache.org/jira/browse/HBASE-26474 Project: HBase Issue Type: Sub-task

[jira] [Created] (HBASE-26472) Adhere to semantic conventions regarding table data operations

2021-11-19 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26472: Summary: Adhere to semantic conventions regarding table data operations Key: HBASE-26472 URL: https://issues.apache.org/jira/browse/HBASE-26472 Project: HBase

[jira] [Created] (HBASE-26471) Move tracing semantic attributes to their own class

2021-11-19 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26471: Summary: Move tracing semantic attributes to their own class Key: HBASE-26471 URL: https://issues.apache.org/jira/browse/HBASE-26471 Project: HBase Issue Typ

[GitHub] [hbase] Apache-HBase commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974385630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974327935 Yeah that sounds right, server would have already been unresponsive. Also, nothing happens after call to `ServerCommandLine#doMain` in master and regionserver main methods so

[GitHub] [hbase] shahrs87 commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
shahrs87 commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974324963 > is already (or in the progress of) shutdown? If the control reaches in the changed code, then HMaster/HRegionServer thread has already died. -- This is an automate

[GitHub] [hbase] shahrs87 commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
shahrs87 commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974324125 > just wondering what could be the most destructive action that non-daemons could do. Maybe nothing? because regionserver/master is already (or in the progress of) shutdown?

[GitHub] [hbase] virajjasani commented on a change in pull request #3852: HBASE-26458 Update Snapshot TTL doc

2021-11-19 Thread GitBox
virajjasani commented on a change in pull request #3852: URL: https://github.com/apache/hbase/pull/3852#discussion_r753019998 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -3150,23 +3150,24 @@ TTL some notion of optional TTL (and optional default TTL) for snapsh

[GitHub] [hbase] virajjasani commented on a change in pull request #3852: HBASE-26458 Update Snapshot TTL doc

2021-11-19 Thread GitBox
virajjasani commented on a change in pull request #3852: URL: https://github.com/apache/hbase/pull/3852#discussion_r753019998 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -3150,23 +3150,24 @@ TTL some notion of optional TTL (and optional default TTL) for snapsh

[GitHub] [hbase] Apache-HBase commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974314250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[jira] [Commented] (HBASE-26421) Use HFileLink file to replace entire file‘s reference when splitting

2021-11-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446624#comment-17446624 ] Hudson commented on HBASE-26421: Results for branch branch-2 [build #396 on bui

[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974312848 This looks good actually, just wondering what could be the most destructive action that non-daemons could do. Maybe nothing? because regionserver/master is already (or in the

[GitHub] [hbase] Apache-HBase commented on pull request #3860: HBASE-26470 Use openlabtesting protoc on linux arm64 in HBASE 2.x

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3860: URL: https://github.com/apache/hbase/pull/3860#issuecomment-974280709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r753396530 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java ## @@ -854,15 +860,75 @@ public long restoreOr

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r753396530 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java ## @@ -854,15 +860,75 @@ public long restoreOr

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r753396530 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java ## @@ -854,15 +860,75 @@ public long restoreOr

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r753375599 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -2628,10 +2628,10 @@ public long restoreSnapshot(final Sn

[GitHub] [hbase] Apache-HBase commented on pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3851: URL: https://github.com/apache/hbase/pull/3851#issuecomment-974241295 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] Apache-HBase commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974229799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38

[jira] [Assigned] (HBASE-26468) Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah reassigned HBASE-26468: Assignee: Rushabh Shah > Region Server doesn't exit cleanly incase it crashes. >

[jira] [Updated] (HBASE-26468) Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-26468: - Description: Observed this in our production cluster running 1.6 version. RS crashed due to some

[jira] [Commented] (HBASE-26067) Change the way on how we track store file list

2021-11-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446530#comment-17446530 ] Hudson commented on HBASE-26067: Results for branch HBASE-26067 [build #3 on bu

[GitHub] [hbase] Apache-HBase commented on pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3851: URL: https://github.com/apache/hbase/pull/3851#issuecomment-974131336 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446501#comment-17446501 ] Duo Zhang commented on HBASE-25905: --- OK, thanks for providing more information. Let me

[GitHub] [hbase] Apache9 commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-11-19 Thread GitBox
Apache9 commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r753205297 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -2628,10 +2628,10 @@ public long restoreSnapshot(final SnapshotD

[GitHub] [hbase] Apache9 commented on a change in pull request #3861: HBASE-26441: Add metrics for BrokenStoreFileCleaner

2021-11-19 Thread GitBox
Apache9 commented on a change in pull request #3861: URL: https://github.com/apache/hbase/pull/3861#discussion_r753163460 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterBrokenStoreFileCleaner.java ## @@ -0,0 +1,82 @@ +/* + * License

[jira] [Commented] (HBASE-26421) Use HFileLink file to replace entire file‘s reference when splitting

2021-11-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446491#comment-17446491 ] Hudson commented on HBASE-26421: Results for branch master [build #446 on build

[GitHub] [hbase] Apache-HBase commented on pull request #3861: HBASE-26441: Add metrics for BrokenStoreFileCleaner

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3861: URL: https://github.com/apache/hbase/pull/3861#issuecomment-974066467 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] Apache-HBase commented on pull request #3861: HBASE-26441: Add metrics for BrokenStoreFileCleaner

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3861: URL: https://github.com/apache/hbase/pull/3861#issuecomment-974061854 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3860: HBASE-26470 Use openlabtesting protoc on linux arm64 in HBASE 2.x

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3860: URL: https://github.com/apache/hbase/pull/3860#issuecomment-974045931 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37

[jira] [Updated] (HBASE-26454) CreateTableProcedure still relies on temp dir and renames when creating table FS layout

2021-11-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26454: -- Fix Version/s: HBASE-26067 > CreateTableProcedure still relies on temp dir and renames when creating t

[GitHub] [hbase] Apache-HBase commented on pull request #3845: HBASE-26454 CreateTableProcedure still relies on temp dir and renames…

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3845: URL: https://github.com/apache/hbase/pull/3845#issuecomment-974022885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[jira] [Resolved] (HBASE-26454) CreateTableProcedure still relies on temp dir and renames when creating table FS layout

2021-11-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-26454. -- Resolution: Fixed Merged into the feature branch. Thanks for reviewing it, [~z

[GitHub] [hbase] Apache-HBase commented on pull request #3845: HBASE-26454 CreateTableProcedure still relies on temp dir and renames…

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3845: URL: https://github.com/apache/hbase/pull/3845#issuecomment-974022690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] wchevreuil merged pull request #3845: HBASE-26454 CreateTableProcedure still relies on temp dir and renames…

2021-11-19 Thread GitBox
wchevreuil merged pull request #3845: URL: https://github.com/apache/hbase/pull/3845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] Apache-HBase commented on pull request #3861: HBASE-26441: Add metrics for BrokenStoreFileCleaner

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3861: URL: https://github.com/apache/hbase/pull/3861#issuecomment-973995970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3859: HBASE-26465 MemStoreLAB may be released early when its SegmentScanner…

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3859: URL: https://github.com/apache/hbase/pull/3859#issuecomment-973992520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[GitHub] [hbase] BukrosSzabolcs opened a new pull request #3861: HBASE-26441: Add metrics for BrokenStoreFileCleaner

2021-11-19 Thread GitBox
BukrosSzabolcs opened a new pull request #3861: URL: https://github.com/apache/hbase/pull/3861 add rs metricsfor BrokenStoreFileCleaner aggregate the rs metrics on master for easier access -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [hbase] Apache-HBase commented on pull request #3860: HBASE-26470 Use openlabtesting protoc on linux arm64 in HBASE 2.x

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3860: URL: https://github.com/apache/hbase/pull/3860#issuecomment-973918125 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] virajjasani commented on pull request #3857: HBASE-26458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting

2021-11-19 Thread GitBox
virajjasani commented on pull request #3857: URL: https://github.com/apache/hbase/pull/3857#issuecomment-973916353 @joswiatek I think here also we will have to follow the same approach as branch-2/master by converting -1 to 0 because proto already has 0 as default value of TTL that we don'

[GitHub] [hbase] virajjasani commented on a change in pull request #3852: HBASE-26458 Update Snapshot TTL doc

2021-11-19 Thread GitBox
virajjasani commented on a change in pull request #3852: URL: https://github.com/apache/hbase/pull/3852#discussion_r753019998 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -3150,23 +3150,24 @@ TTL some notion of optional TTL (and optional default TTL) for snapsh

[GitHub] [hbase] Apache-HBase commented on pull request #3859: HBASE-26465 MemStoreLAB may be released early when its SegmentScanner…

2021-11-19 Thread GitBox
Apache-HBase commented on pull request #3859: URL: https://github.com/apache/hbase/pull/3859#issuecomment-973900928 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[GitHub] [hbase] markjens opened a new pull request #3860: HBASE-26470 Use openlabtesting protoc on linux arm64 in HBASE 2.x

2021-11-19 Thread GitBox
markjens opened a new pull request #3860: URL: https://github.com/apache/hbase/pull/3860 This is a backport of https://github.com/apache/hbase/commit/5480493f5f7b01b496f54215334543f2a82c6ba7 with a small improvement to use latest openlabtesting:protoc (2.5.0.2) which. -- This is an aut

[jira] [Updated] (HBASE-26465) MemStoreLAB may be released early when its SegmentScanner is scanning

2021-11-19 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26465: - Status: Patch Available (was: Open) > MemStoreLAB may be released early when its SegmentScanner is scan

[GitHub] [hbase] comnetwork opened a new pull request #3859: HBASE-26465 MemStoreLAB may be released early when its SegmentScanner…

2021-11-19 Thread GitBox
comnetwork opened a new pull request #3859: URL: https://github.com/apache/hbase/pull/3859 … is scanning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Updated] (HBASE-26470) CLONE - Update pom.xml to use another 2.5.0 protoc as external protobuf

2021-11-19 Thread Mark Jens (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Jens updated HBASE-26470: -- Fix Version/s: (was: 3.0.0-alpha-1) > CLONE - Update pom.xml to use another 2.5.0 protoc as extern

[jira] [Updated] (HBASE-26470) CLONE - Update pom.xml to use another 2.5.0 protoc as external protobuf

2021-11-19 Thread Mark Jens (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Jens updated HBASE-26470: -- Description: This is the same issue as HBASE-23612 but for HBase 2.x. Please backport the fix to HBas

[jira] [Created] (HBASE-26470) CLONE - Update pom.xml to use another 2.5.0 protoc as external protobuf

2021-11-19 Thread Mark Jens (Jira)
Mark Jens created HBASE-26470: - Summary: CLONE - Update pom.xml to use another 2.5.0 protoc as external protobuf Key: HBASE-26470 URL: https://issues.apache.org/jira/browse/HBASE-26470 Project: HBase

[jira] [Updated] (HBASE-26465) MemStoreLAB may be released early when its SegmentScanner is scanning

2021-11-19 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26465: - Description: HBASE-26144 moved {{MemStore.clearSnapshot}} out of write lock of {{HStore#lock}}, but bec