Apache-HBase commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974766461
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3
[
https://issues.apache.org/jira/browse/HBASE-26047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao reassigned HBASE-26047:
---
Assignee: Yutong Xiao
> [JDK17] Track JDK17 unit test failures
> --
Apache-HBase commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974761047
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25
Apache-HBase commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974751261
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28
YutSean commented on pull request #3776:
URL: https://github.com/apache/hbase/pull/3776#issuecomment-974748728
Do i need to push another blank commit to trigger the QA once more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
shahrs87 commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974724292
> so we need to make sure that it is OK for us to change the behavior. We
could fix a bug introduced by the old behavior but we may introduce more bugs
if we change the behavior.
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974702699
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974701937
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s
Apache-HBase commented on pull request #3865:
URL: https://github.com/apache/hbase/pull/3865#issuecomment-974692881
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 35
Apache-HBase commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974688988
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 2
Apache-HBase commented on pull request #3866:
URL: https://github.com/apache/hbase/pull/3866#issuecomment-974685659
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 8m 3s
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974684702
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26
Apache-HBase commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974681177
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37
Apache-HBase commented on pull request #3859:
URL: https://github.com/apache/hbase/pull/3859#issuecomment-974675352
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25
Apache9 commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974675076
When adding UTs I found some new problems, and I added a comment on the
design doc about the fail recovery logic.
The PR is not fully completed yet, still need to add more U
Apache9 commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974674843
> > The comment of the method says it will only call System.exit when a
nonzero return code is returned from the run method?
>
> @Apache9 good catch. Changed the comment. Pl
Apache-HBase commented on pull request #3859:
URL: https://github.com/apache/hbase/pull/3859#issuecomment-974672789
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25
Apache-HBase commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974661559
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 27
Apache-HBase commented on pull request #3865:
URL: https://github.com/apache/hbase/pull/3865#issuecomment-974660335
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34
virajjasani commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974660177
Backport PRs: #3865 #3866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Apache-HBase commented on pull request #3865:
URL: https://github.com/apache/hbase/pull/3865#issuecomment-974659714
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s
[
https://issues.apache.org/jira/browse/HBASE-26468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446829#comment-17446829
]
Rushabh Shah commented on HBASE-26468:
--
Created PR for master, branch-2 and branch-
Apache-HBase commented on pull request #3859:
URL: https://github.com/apache/hbase/pull/3859#issuecomment-974655589
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25
shahrs87 commented on pull request #3862:
URL: https://github.com/apache/hbase/pull/3862#issuecomment-974654639
> The comment of the method says it will only call System.exit when a
nonzero return code is returned from the run method?
@Apache9 good catch. Changed the comment. Please
[
https://issues.apache.org/jira/browse/HBASE-26476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei reassigned HBASE-26476:
Assignee: chenglei
> Make DefaultMemStore extensible for HStore.memstore
> -
[
https://issues.apache.org/jira/browse/HBASE-26476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26476:
-
Description:
When {{HStore.memstore}} is {{DefaultMemStore}} , I find that it is
impossible to extend
[
https://issues.apache.org/jira/browse/HBASE-26476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26476:
-
Description:
When {{HStore.memstore}} is {{DefaultMemStore}} , I find that it is
impossible to exten
[
https://issues.apache.org/jira/browse/HBASE-26476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26476:
-
Description: When I test {{HStore}}, I find that it is impossible to extend
> Make DefaultMemStore exte
chenglei created HBASE-26476:
Summary: Make DefaultMemStore extensible for HStore.memstore
Key: HBASE-26476
URL: https://issues.apache.org/jira/browse/HBASE-26476
Project: HBase
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HBASE-26067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446816#comment-17446816
]
Hudson commented on HBASE-26067:
Results for branch HBASE-26067
[build #4 on
bu
comnetwork edited a comment on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974631960
@zhengzhuobinzzb, and please also fix the checkstyle issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
comnetwork commented on pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#issuecomment-974631960
and please also fix the checkstyle issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
comnetwork commented on a change in pull request #3858:
URL: https://github.com/apache/hbase/pull/3858#discussion_r753662321
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellFlatMapMemStore.java
##
@@ -903,6 +904,37 @@ public vo
[
https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446774#comment-17446774
]
chenglei edited comment on HBASE-25905 at 11/20/21, 9:59 AM:
-
[
https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446774#comment-17446774
]
chenglei edited comment on HBASE-25905 at 11/20/21, 9:57 AM:
-
[
https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446774#comment-17446774
]
chenglei commented on HBASE-25905:
--
[~Xiaolin Ha], I think your analysis is reansonable
virajjasani commented on a change in pull request #3852:
URL: https://github.com/apache/hbase/pull/3852#discussion_r753652443
##
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##
@@ -3150,23 +3150,24 @@ TTL some notion of optional TTL (and optional default
TTL) for snapsh
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974616558
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28
Apache-HBase commented on pull request #3864:
URL: https://github.com/apache/hbase/pull/3864#issuecomment-974615412
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25
39 matches
Mail list logo
