[GitHub] [hbase] Apache-HBase commented on pull request #3913: HBASE-26536 Tweak checkstyle LeftCurly config to "nlow"

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3913: URL: https://github.com/apache/hbase/pull/3913#issuecomment-993248689 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more s

[GitHub] [hbase] Apache-HBase commented on pull request #3913: HBASE-26536 Tweak checkstyle LeftCurly config to "nlow"

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3913: URL: https://github.com/apache/hbase/pull/3913#issuecomment-993178136 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s

[jira] [Resolved] (HBASE-26510) Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao resolved HBASE-26510. - Resolution: Won't Do > Separate the blockcache enabled key and cache data on read key >

[GitHub] [hbase] YutSean closed pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
YutSean closed pull request #3893: URL: https://github.com/apache/hbase/pull/3893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more s

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more s

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more s

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more s

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more s

[GitHub] [hbase] sunhelly commented on a change in pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
sunhelly commented on a change in pull request #3893: URL: https://github.com/apache/hbase/pull/3893#discussion_r768303073 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -40,8 +40,12 @@ public static final CacheConfig DISABL

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more s

[GitHub] [hbase] comnetwork commented on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork commented on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more simpler?

[GitHub] [hbase] YutSean commented on a change in pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
YutSean commented on a change in pull request #3893: URL: https://github.com/apache/hbase/pull/3893#discussion_r768290278 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -40,8 +40,12 @@ public static final CacheConfig DISABLE

[GitHub] [hbase] YutSean commented on a change in pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
YutSean commented on a change in pull request #3893: URL: https://github.com/apache/hbase/pull/3893#discussion_r768286968 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -40,8 +40,12 @@ public static final CacheConfig DISABLE

[GitHub] [hbase] sunhelly commented on a change in pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
sunhelly commented on a change in pull request #3893: URL: https://github.com/apache/hbase/pull/3893#discussion_r768284017 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -40,8 +40,12 @@ public static final CacheConfig DISABL

[GitHub] [hbase] sunhelly commented on a change in pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
sunhelly commented on a change in pull request #3893: URL: https://github.com/apache/hbase/pull/3893#discussion_r768284017 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -40,8 +40,12 @@ public static final CacheConfig DISABL

[GitHub] [hbase] YutSean commented on a change in pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
YutSean commented on a change in pull request #3893: URL: https://github.com/apache/hbase/pull/3893#discussion_r768254888 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java ## @@ -218,6 +221,12 @@ */ public static

[GitHub] [hbase] Apache-HBase commented on pull request #3913: HBASE-26536 Tweak checkstyle LeftCurly config to "nlow"

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3913: URL: https://github.com/apache/hbase/pull/3913#issuecomment-993077559 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 18

[GitHub] [hbase] Apache-HBase commented on pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3942: URL: https://github.com/apache/hbase/pull/3942#issuecomment-993063980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] ndimiduk commented on pull request #3913: HBASE-26536 Tweak checkstyle LeftCurly config to "nlow"

2021-12-13 Thread GitBox
ndimiduk commented on pull request #3913: URL: https://github.com/apache/hbase/pull/3913#issuecomment-993063501 The `.editorconfig` has drifted from the checkstyle file, I'm not sure why/how. Maybe a newer version of the IntelliJ or the IntelliJ Checkstyle Plugin have changed how settings

[jira] [Commented] (HBASE-26557) log4j2 has a critical RCE vulnerability

2021-12-13 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458840#comment-17458840 ] Yutong Xiao commented on HBASE-26557: - [~elserj] Thanks Josh, my mistake for that...

[GitHub] [hbase] Apache-HBase commented on pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3942: URL: https://github.com/apache/hbase/pull/3942#issuecomment-993056843 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] Apache-HBase commented on pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3942: URL: https://github.com/apache/hbase/pull/3942#issuecomment-993056418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[jira] [Commented] (HBASE-26265) Update ref guide to mention the new store file tracker implementations

2021-12-13 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458835#comment-17458835 ] Wellington Chevreuil commented on HBASE-26265: -- Sorry for the delay here, [

[GitHub] [hbase] wchevreuil opened a new pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-13 Thread GitBox
wchevreuil opened a new pull request #3942: URL: https://github.com/apache/hbase/pull/3942 …plementations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [hbase] Apache9 commented on pull request #3924: HBASE-26542 Apply a `package` to test protobuf files

2021-12-13 Thread GitBox
Apache9 commented on pull request #3924: URL: https://github.com/apache/hbase/pull/3924#issuecomment-993031260 OK, I guess the problem is that if we only touch the proto without changing any java files, we will not trigger a 'mvn install' first which could lead to the problem... Let

[jira] [Created] (HBASE-26569) Put up 3.0.0-alpha-2RC1

2021-12-13 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26569: - Summary: Put up 3.0.0-alpha-2RC1 Key: HBASE-26569 URL: https://issues.apache.org/jira/browse/HBASE-26569 Project: HBase Issue Type: Sub-task Components:

[jira] [Resolved] (HBASE-26559) Put up 3.0.0-alpha-2RC0

2021-12-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26559. --- Resolution: Fixed Need a RC1 because an error in the hbase-config.sh script. > Put up 3.0.0-alpha-2

[jira] [Resolved] (HBASE-26557) log4j2 has a critical RCE vulnerability

2021-12-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26557. --- Resolution: Fixed Thanks [~elserj] for the fix! > log4j2 has a critical RCE vulnerability > ---

[GitHub] [hbase] Apache9 merged pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
Apache9 merged pull request #3941: URL: https://github.com/apache/hbase/pull/3941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (HBASE-26537) FuzzyRowFilter backwards compatibility

2021-12-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458806#comment-17458806 ] Duo Zhang commented on HBASE-26537: --- We could also include this in 2.4.x? > FuzzyRowF

[GitHub] [hbase] ndimiduk commented on pull request #3913: HBASE-26536 Tweak checkstyle LeftCurly config to "nlow"

2021-12-13 Thread GitBox
ndimiduk commented on pull request #3913: URL: https://github.com/apache/hbase/pull/3913#issuecomment-993021853 Eclipse should be using the formatting configuration that is committed to the project, which was generated from checkstyle config. Actually,let me update both configurations here

[GitHub] [hbase] ndimiduk commented on pull request #3906: HBASE-26472 Adhere to semantic conventions regarding table data operations

2021-12-13 Thread GitBox
ndimiduk commented on pull request #3906: URL: https://github.com/apache/hbase/pull/3906#issuecomment-993021327 @Apache9, @taklwu do you have any further concerns here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Apache9 commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
Apache9 commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-993020482 Checked hbase-config.cmd, we do not have space for that file... Thanks Josh for catching this. Let me merge and generate a RC2. -- This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #3910: HBASE-25623 Upgrade hbase-thirdparty dependency to 4.0.0

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3910: URL: https://github.com/apache/hbase/pull/3910#issuecomment-993014194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[GitHub] [hbase] ndimiduk commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
ndimiduk commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992993238 ``` ... [2021-12-13T22:47:22.954Z] [Mon Dec 13 22:47:23 UTC 2021 DEBUG]: Importing /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3941/yetus-general-check/

[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992981974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992981834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] ndimiduk commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
ndimiduk commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992980646 Building again with debug enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
ndimiduk commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992970238 > lgtm. why didn't shellcheck catch this on the original? I came around to ask the exact same question. -- This is an automated message from the Apache Git Service. To re

[GitHub] [hbase] Apache-HBase commented on pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3851: URL: https://github.com/apache/hbase/pull/3851#issuecomment-992965375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56

[GitHub] [hbase] joshelser edited a comment on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
joshelser edited a comment on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992940447 Great question. I just ran it through their online interpreter for shell check and it should have generated an error. The nightly build doesn't seem to complain

[jira] [Resolved] (HBASE-26568) hbase master got stuck after running couple of days in Azure setup

2021-12-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-26568. Resolution: Workaround Resolving with "Workaround" being upgrade. > hbase master got stuck after

[jira] [Updated] (HBASE-26568) hbase master got stuck after running couple of days in Azure setup

2021-12-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-26568: --- Component/s: (was: hbase-thirdparty) > hbase master got stuck after running couple of days in Az

[GitHub] [hbase] joshelser commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
joshelser commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992940447 Great question. I just ran it through their online interpreter for shell check and it should have generated an error. The nightly build doesn't seem to complain ```

[jira] [Resolved] (HBASE-26537) FuzzyRowFilter backwards compatibility

2021-12-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-26537. - Hadoop Flags: Reviewed Release Note: HBASE-15676 introduced a backwards incom

[GitHub] [hbase] apurtell merged pull request #3916: HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto

2021-12-13 Thread GitBox
apurtell merged pull request #3916: URL: https://github.com/apache/hbase/pull/3916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [hbase] apurtell merged pull request #3931: HBASE-26537: Make HBASE-15676 backwards compatible, using a flag on the proto

2021-12-13 Thread GitBox
apurtell merged pull request #3931: URL: https://github.com/apache/hbase/pull/3931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992916307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 3

[GitHub] [hbase] Apache-HBase commented on pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3851: URL: https://github.com/apache/hbase/pull/3851#issuecomment-992916028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3941: URL: https://github.com/apache/hbase/pull/3941#issuecomment-992911056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] joshelser opened a new pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…

2021-12-13 Thread GitBox
joshelser opened a new pull request #3941: URL: https://github.com/apache/hbase/pull/3941 …OPTS Tagging folks who reviewed the first time. The original change is ineffective and does not result in adding the property to the HBASE_OPTS environment variable ``` $ ./bin/start-hba

[jira] [Reopened] (HBASE-26557) log4j2 has a critical RCE vulnerability

2021-12-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser reopened HBASE-26557: > log4j2 has a critical RCE vulnerability > --- > >

[jira] [Commented] (HBASE-26557) log4j2 has a critical RCE vulnerability

2021-12-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458713#comment-17458713 ] Josh Elser commented on HBASE-26557: [~xytss123] [~zhangduo] looks like there's a sy

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768069212 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/TestIntegrationTestBase.java ## @@ -40,11 +40,10 @@ public void testMonkeyPropertiesParsing()

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768070642 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestCoprocessorDescriptor.java ## @@ -71,7 +67,11 @@ public void testSetCoprocesso

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768068944 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestBulkLoad.java ## @@ -373,7 +375,11 @@ public void close() throws IOE

[GitHub] [hbase] apurtell edited a comment on pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell edited a comment on pull request #3936: URL: https://github.com/apache/hbase/pull/3936#issuecomment-992812212 Each module has its own commit in the PR branch @Apache9 . I think that is the best we can do as far as keeping each review item small. In other words I am a

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768071320 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestAvlUtil.java ## @@ -54,9 +55,8 @@ public void testAvlTreeCrud() { final Tre

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768070886 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/PerClientRandomNonceGenerator.java ## @@ -32,13 +32,14 @@ public final class PerC

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768070642 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestCoprocessorDescriptor.java ## @@ -71,7 +67,11 @@ public void testSetCoprocesso

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768070397 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/io/util/TestLRUDictionary.java ## @@ -81,9 +83,8 @@ public void testPassingSameArrayToAdd

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768069212 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/TestIntegrationTestBase.java ## @@ -40,11 +40,10 @@ public void testMonkeyPropertiesParsing()

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r768068944 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestBulkLoad.java ## @@ -373,7 +375,11 @@ public void close() throws IOE

[GitHub] [hbase] apurtell commented on pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
apurtell commented on pull request #3936: URL: https://github.com/apache/hbase/pull/3936#issuecomment-992812212 Each module has its own commit in the PR branch @Apache9 . I think that is the best we can do as far as keeping each review item small. -- This is an automated message from th

[GitHub] [hbase] Apache-HBase commented on pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3851: URL: https://github.com/apache/hbase/pull/3851#issuecomment-992779940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #3910: HBASE-25623 Upgrade hbase-thirdparty dependency to 4.0.0

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3910: URL: https://github.com/apache/hbase/pull/3910#issuecomment-992704155 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[jira] [Updated] (HBASE-26568) hbase master got stuck after running couple of days in Azure setup

2021-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-26568: Affects Version/s: 2.0.1 > hbase master got stuck after running couple of days in Azure setup > --

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-13 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r767965248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java ## @@ -854,15 +859,46 @@ public long restoreOr

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-13 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r767963691 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -92,7 +92,7 @@ sta

[GitHub] [hbase] ndimiduk commented on pull request #3924: HBASE-26542 Apply a `package` to test protobuf files

2021-12-13 Thread GitBox
ndimiduk commented on pull request #3924: URL: https://github.com/apache/hbase/pull/3924#issuecomment-992675731 > What I mean is that, we used to change the protobuf files a lot in the past and IIRC we haven't seen any problems on the pre commit build. > > So I want to know, in which

[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-13 Thread GitBox
BukrosSzabolcs commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r767939110 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java ## @@ -203,6 +216,26 @@ protected Flow

[jira] [Commented] (HBASE-26265) Update ref guide to mention the new store file tracker implementations

2021-12-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458521#comment-17458521 ] Duo Zhang commented on HBASE-26265: --- Ping [~wchevreuil]. > Update ref guide to mentio

[GitHub] [hbase] Apache9 commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-13 Thread GitBox
Apache9 commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r767920480 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java ## @@ -707,7 +706,9 @@ private void cloneRegion(final

[GitHub] [hbase] Apache9 commented on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
Apache9 commented on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-992636187 I do not think you fully got my point... My point is, the design of the MemStoreSnapshot is mainly for storing the snapshot id and the snapshot scanner, if we do not want to

[jira] [Commented] (HBASE-26568) hbase master got stuck after running couple of days in Azure setup

2021-12-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458484#comment-17458484 ] Duo Zhang commented on HBASE-26568: --- HBase 2.0.x has already EOL. Please try to upgrad

[jira] [Resolved] (HBASE-26528) [hbase-thirdparty] Put up 4.0.0RC1

2021-12-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26528. --- Resolution: Fixed > [hbase-thirdparty] Put up 4.0.0RC1 > -- > >

[GitHub] [hbase] Apache9 commented on pull request #3924: HBASE-26542 Apply a `package` to test protobuf files

2021-12-13 Thread GitBox
Apache9 commented on pull request #3924: URL: https://github.com/apache/hbase/pull/3924#issuecomment-992591318 What I mean is that, we used to change the protobuf files a lot in the past and IIRC we haven't seen any problems on the pre commit build. So I want to know, in which PR you

[GitHub] [hbase] Apache9 commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-13 Thread GitBox
Apache9 commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r767847725 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestCoprocessorDescriptor.java ## @@ -71,7 +67,11 @@ public void testSetCoprocessor

[GitHub] [hbase] Apache9 commented on a change in pull request #3800: HBASE-26347 Support detect and exclude slow DNs in fan-out of WAL

2021-12-13 Thread GitBox
Apache9 commented on a change in pull request #3800: URL: https://github.com/apache/hbase/pull/3800#discussion_r767834778 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/monitor/StreamSlowMonitor.java ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Ap

[jira] [Created] (HBASE-26568) hbase master got stuck after running couple of days in Azure setup

2021-12-13 Thread kaushik mandal (Jira)
kaushik mandal created HBASE-26568: -- Summary: hbase master got stuck after running couple of days in Azure setup Key: HBASE-26568 URL: https://issues.apache.org/jira/browse/HBASE-26568 Project: HBase

[jira] [Commented] (HBASE-20503) [AsyncFSWAL] Failed to get sync result after 300000 ms for txid=160912, WAL system stuck?

2021-12-13 Thread Emil Kleszcz (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458453#comment-17458453 ] Emil Kleszcz commented on HBASE-20503: -- Hi [~zhengsicheng], we experienced the issu

[jira] [Updated] (HBASE-26518) Concurrent assign and SCP may cause regionserver abort

2021-12-13 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26518: --- Summary: Concurrent assign and SCP may cause regionserver abort (was: Concurrent assign the same re

[GitHub] [hbase] Apache9 commented on pull request #3891: HBASE-26233 The region replication framework should not be built upon the general replication framework

2021-12-13 Thread GitBox
Apache9 commented on pull request #3891: URL: https://github.com/apache/hbase/pull/3891#issuecomment-992526154 > Is this a draft? This is for reviewers to take a look at the implementation of HBASE-26233. I'm still testing this feature branch, once I'm done, I will start a vote thre

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-13 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, Chunks in {{CellChunkMap}} is indexed by ChunkID ,so they would deallo

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-13 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, Chunks in {{CellChunkMap}} is (was: As HBASE-18375 said, ) > Remove

[GitHub] [hbase] sunhelly commented on a change in pull request #3893: HBASE-26510 Separate the blockcache enabled key and cache data on read key

2021-12-13 Thread GitBox
sunhelly commented on a change in pull request #3893: URL: https://github.com/apache/hbase/pull/3893#discussion_r767761762 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java ## @@ -218,6 +221,12 @@ */ public static

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992465121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992454859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992452602 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-13 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, > Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

[jira] [Created] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-13 Thread chenglei (Jira)
chenglei created HBASE-26567: Summary: Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method Key: HBASE-26567 URL: https://issues.apache.org/jira/browse/HBASE-26567 Project: HBase I

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992349142 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992339063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13

[GitHub] [hbase] Apache-HBase commented on pull request #3939: HBASE-26565 Make StatisticThread alternative in LruBC

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3939: URL: https://github.com/apache/hbase/pull/3939#issuecomment-992339235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992336547 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[GitHub] [hbase] Apache-HBase commented on pull request #3939: HBASE-26565 Make StatisticThread alternative in LruBC

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3939: URL: https://github.com/apache/hbase/pull/3939#issuecomment-992336160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992312060 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 2

[GitHub] [hbase] Apache-HBase commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-13 Thread GitBox
Apache-HBase commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-992295302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36

  1   2   >