[GitHub] [hbase] Apache-HBase commented on pull request #3946: HBASE-26578 CompactedHFilesDischarger should be shutdown when abortin…

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3946: URL: https://github.com/apache/hbase/pull/3946#issuecomment-994422822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3946: HBASE-26578 CompactedHFilesDischarger should be shutdown when abortin…

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3946: URL: https://github.com/apache/hbase/pull/3946#issuecomment-994416870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #3641: HBASE-26006 Update ref guide about the 2.4.x release line

2021-12-14 Thread GitBox
Apache9 commented on pull request #3641: URL: https://github.com/apache/hbase/pull/3641#issuecomment-994416010 Ping @apurtell @ndimiduk @busbey , let's finish this one? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache9 commented on pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-14 Thread GitBox
Apache9 commented on pull request #3851: URL: https://github.com/apache/hbase/pull/3851#issuecomment-994412034 > Looks great to me. I think I agree with the method layout you have here already, Szabolcs. > > It would be great to land this change this week, but let's give Duo the

[GitHub] [hbase] Apache9 commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-14 Thread GitBox
Apache9 commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r769314742 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -92,7 +92,7 @@ static

[GitHub] [hbase] Apache9 commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

2021-12-14 Thread GitBox
Apache9 commented on a change in pull request #3851: URL: https://github.com/apache/hbase/pull/3851#discussion_r768796706 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java ## @@ -203,6 +216,42 @@ protected Flow

[GitHub] [hbase] Apache-HBase commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994405924 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Summary: Remove high-risk ChunkCreator.getChunk(ChunkType) method (was: Remove high-risk

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: For {{CellChunkMap}}, cells in data chunks in is indexed by index chunks by ChunkID ,not

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: For {{CellChunkMap}}, cells in data chunks in is indexed by index chunks by ChunkID ,not

[jira] [Resolved] (HBASE-26574) [hbase-operator-tools] Set version as 1.2.0 in master

2021-12-14 Thread Guangxu Cheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng resolved HBASE-26574. --- Fix Version/s: hbase-operator-tools-1.2.0 Resolution: Resolved >

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[GitHub] [hbase] Apache-HBase commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994330456 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, data chunks in {{CellChunkMap}} is indexed by index chunks by

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, data chunks in {{CellChunkMap}} is indexed by index chunks by

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, data chunks in {{CellChunkMap}} is indexed by index chunks by

[GitHub] [hbase] Apache-HBase commented on pull request #3800: HBASE-26347 Support detect and exclude slow DNs in fan-out of WAL

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3800: URL: https://github.com/apache/hbase/pull/3800#issuecomment-994316456 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3946: HBASE-26578 CompactedHFilesDischarger should be shutdown when abortin…

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3946: URL: https://github.com/apache/hbase/pull/3946#issuecomment-994306193 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sunhelly commented on pull request #3800: HBASE-26347 Support detect and exclude slow DNs in fan-out of WAL

2021-12-14 Thread GitBox
sunhelly commented on pull request #3800: URL: https://github.com/apache/hbase/pull/3800#issuecomment-994294492 The failed UTs is not relevant to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, data chunks in {{CellChunkMap}} is indexed by index chunks by

[GitHub] [hbase] sunhelly opened a new pull request #3946: HBASE-26578 CompactedHFilesDischarger should be shutdown when abortin…

2021-12-14 Thread GitBox
sunhelly opened a new pull request #3946: URL: https://github.com/apache/hbase/pull/3946 …g regionserver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Created] (HBASE-26578) CompactedHFilesDischarger should be shutdown when aborting regionserver

2021-12-14 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-26578: -- Summary: CompactedHFilesDischarger should be shutdown when aborting regionserver Key: HBASE-26578 URL: https://issues.apache.org/jira/browse/HBASE-26578 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994272522 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-26567) Remove high-risk ChunkCreator.getChunk(ChunkType chunkType) method

2021-12-14 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26567: - Description: As HBASE-18375 said, data chunks in {{CellChunkMap}} is indexed by index chunks by ChunkID

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[GitHub] [hbase] YutSean commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-14 Thread GitBox
YutSean commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-994267722 Have added details in the corresponding jira ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[jira] [Updated] (HBASE-26566) Optimize determine E step in OrderedBytes

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26566: Description: Found current estimate E step in OrderedBytes is to search step by step in loops.

[GitHub] [hbase] YutSean commented on a change in pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
YutSean commented on a change in pull request #3929: URL: https://github.com/apache/hbase/pull/3929#discussion_r769218872 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FastPathRWQueueRpcExecutor.java ## @@ -0,0 +1,72 @@ +/** + + * Licensed to the Apache

[GitHub] [hbase] Reidddddd commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-14 Thread GitBox
Reidd commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-994262463 I feel it is better to give more details, even math theoretics, to make me or other reviewers more clear and understand your changes... -- This is an automated message from

[GitHub] [hbase] Reidddddd commented on a change in pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
Reidd commented on a change in pull request #3929: URL: https://github.com/apache/hbase/pull/3929#discussion_r769216904 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FastPathRWQueueRpcExecutor.java ## @@ -0,0 +1,72 @@ +/** + + * Licensed to the

[jira] [Commented] (HBASE-26549) hbaseprotoc plugin should initialize maven

2021-12-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459625#comment-17459625 ] Hudson commented on HBASE-26549: Results for branch branch-2.4 [build #256 on

[GitHub] [hbase] YutSean commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-14 Thread GitBox
YutSean commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-994251066 There is a UT named TestOrderedNumeric. The changes passed this UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994250531 Left some comments to explain in the corresponding ticket. @Reidd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994250198 Left comments > LGTM. Can you explain more about the pics in the ticket you upload? I don't quite catch what it tells -- This is an automated message from the

[GitHub] [hbase] YutSean removed a comment on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
YutSean removed a comment on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994250198 Left comments > LGTM. Can you explain more about the pics in the ticket you upload? I don't quite catch what it tells -- This is an automated message

[GitHub] [hbase] YutSean closed pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
YutSean closed pull request #3929: URL: https://github.com/apache/hbase/pull/3929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-26551) Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459624#comment-17459624 ] Yutong Xiao commented on HBASE-26551: - The screen shots showed the rpc requests queue time. The

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-14 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase-operator-tools] guangxuCheng merged pull request #98: HBASE-26574 [hbase-operator-tools] Set version as 1.2.0 in master

2021-12-14 Thread GitBox
guangxuCheng merged pull request #98: URL: https://github.com/apache/hbase-operator-tools/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Reidddddd commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread GitBox
Reidd commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994243323 LGTM. Can you explain more about the pics in the ticket you upload? I don't quite catch what it tells -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-26551) Add FastPath feature to HBase RWQueueRpcExecutor

2021-12-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26551: -- Component/s: Scheduler > Add FastPath feature to HBase RWQueueRpcExecutor >

[jira] [Updated] (HBASE-17808) FastPath for RWQueueRpcExecutor

2021-12-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-17808: -- Resolution: Incomplete Status: Resolved (was: Patch Available) > FastPath for

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2021-12-14 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459615#comment-17459615 ] Reid Chan commented on HBASE-17808: --- A contributor is working on this in HBASE-26551. This has been a

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #98: HBASE-26574 [hbase-operator-tools] Set version as 1.2.0 in master

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #98: URL: https://github.com/apache/hbase-operator-tools/pull/98#issuecomment-994239422 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase] Reidddddd commented on pull request #3940: HBASE-26566 Optimize determine E step in OrderedBytes

2021-12-14 Thread GitBox
Reidd commented on pull request #3940: URL: https://github.com/apache/hbase/pull/3940#issuecomment-994238238 Is there any test or unit test for verifying the behaviour of before-change and after-change is equal? -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (HBASE-26573) [hbase-operator-tools] Generate CHANGES.md and RELEASENOTES.md for 1.2.0

2021-12-14 Thread Guangxu Cheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-26573: -- Fix Version/s: hbase-operator-tools-1.2.0 > [hbase-operator-tools] Generate CHANGES.md and

[jira] [Resolved] (HBASE-26573) [hbase-operator-tools] Generate CHANGES.md and RELEASENOTES.md for 1.2.0

2021-12-14 Thread Guangxu Cheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng resolved HBASE-26573. --- Resolution: Resolved > [hbase-operator-tools] Generate CHANGES.md and RELEASENOTES.md for

[GitHub] [hbase-operator-tools] guangxuCheng merged pull request #97: HBASE-26573 [hbase-operator-tools] Generate CHANGES.md and RELEASENOT…

2021-12-14 Thread GitBox
guangxuCheng merged pull request #97: URL: https://github.com/apache/hbase-operator-tools/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3944: HBASE-26576

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3944: URL: https://github.com/apache/hbase/pull/3944#issuecomment-994209327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3944: HBASE-26576

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3944: URL: https://github.com/apache/hbase/pull/3944#issuecomment-994208119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3945: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2.5

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3945: URL: https://github.com/apache/hbase/pull/3945#issuecomment-994183757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3945: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2.5

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3945: URL: https://github.com/apache/hbase/pull/3945#issuecomment-994178122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3945: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2.5

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3945: URL: https://github.com/apache/hbase/pull/3945#issuecomment-994172896 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26472) Adhere to semantic conventions regarding table data operations

2021-12-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26472: - Fix Version/s: 2.5.0 2.6.0 3.0.0-alpha-3 > Adhere to

[GitHub] [hbase] ndimiduk opened a new pull request #3945: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2.5

2021-12-14 Thread GitBox
ndimiduk opened a new pull request #3945: URL: https://github.com/apache/hbase/pull/3945 Follows the guidance outlined in https://github.com/open-telemetry/opentelemetry-specification/blob/3e380e2/specification/trace/semantic_conventions/database.dm * all table data operations are

[GitHub] [hbase] ndimiduk merged pull request #3907: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2

2021-12-14 Thread GitBox
ndimiduk merged pull request #3907: URL: https://github.com/apache/hbase/pull/3907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3907: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3907: URL: https://github.com/apache/hbase/pull/3907#issuecomment-994145584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3906: HBASE-26472 Adhere to semantic conventions regarding table data operations

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3906: URL: https://github.com/apache/hbase/pull/3906#issuecomment-994144082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3906: HBASE-26472 Adhere to semantic conventions regarding table data operations

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3906: URL: https://github.com/apache/hbase/pull/3906#issuecomment-994138210 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3907: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3907: URL: https://github.com/apache/hbase/pull/3907#issuecomment-994138036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3906: HBASE-26472 Adhere to semantic conventions regarding table data operations

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3906: URL: https://github.com/apache/hbase/pull/3906#issuecomment-994135877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3907: Backport "HBASE-26472 Adhere to semantic conventions regarding table data operations" to branch-2

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3907: URL: https://github.com/apache/hbase/pull/3907#issuecomment-994133683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk merged pull request #3906: HBASE-26472 Adhere to semantic conventions regarding table data operations

2021-12-14 Thread GitBox
ndimiduk merged pull request #3906: URL: https://github.com/apache/hbase/pull/3906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26530) Backport HBASE-26524 Support remove coprocessor by class name via alter table command

2021-12-14 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26530: - Affects Version/s: 2.5.0 > Backport HBASE-26524 Support remove coprocessor by

[jira] [Updated] (HBASE-26530) Backport HBASE-26524 Support remove coprocessor by class name via alter table command

2021-12-14 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26530: - Affects Version/s: 2.6.0 (was: 2.5.0) > Backport

[GitHub] [hbase] Apache-HBase commented on pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3942: URL: https://github.com/apache/hbase/pull/3942#issuecomment-994110717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3944: HBASE-26576

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3944: URL: https://github.com/apache/hbase/pull/3944#issuecomment-994102068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3942: URL: https://github.com/apache/hbase/pull/3942#issuecomment-994101166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-14 Thread GitBox
Apache-HBase commented on pull request #3942: URL: https://github.com/apache/hbase/pull/3942#issuecomment-994100775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-14 Thread GitBox
wchevreuil commented on pull request #3942: URL: https://github.com/apache/hbase/pull/3942#issuecomment-994100121 Thanks for the review comments, @joshelser and @Apache9 . I believe I have addressed all the suggestions, please give a second look at your convenience. -- This is an

[GitHub] [hbase] wchevreuil commented on a change in pull request #3942: HBASE-26265 Update ref guide to mention the new store file tracker im…

2021-12-14 Thread GitBox
wchevreuil commented on a change in pull request #3942: URL: https://github.com/apache/hbase/pull/3942#discussion_r769089392 ## File path: src/main/asciidoc/_chapters/store_file_tracking.adoc ## @@ -0,0 +1,175 @@ + +/** + * + * Licensed to the Apache Software Foundation

[jira] [Updated] (HBASE-26520) Remove use of `db.hbase.namespace` tracing attribute

2021-12-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26520: - Summary: Remove use of `db.hbase.namespace` tracing attribute (was: Remove use of

[jira] [Commented] (HBASE-26473) Introduce `db.hbase.container_operations` span attribute

2021-12-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459516#comment-17459516 ] Nick Dimiduk commented on HBASE-26473: -- I have started some discussion on this topic over on

[jira] [Created] (HBASE-26577) Update ref guide section for IT and Chaos Monkey to explain the additions from HBASE-26556

2021-12-14 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-26577: Summary: Update ref guide section for IT and Chaos Monkey to explain the additions from HBASE-26556 Key: HBASE-26577 URL:

[jira] [Resolved] (HBASE-26556) IT and Chaos Monkey improvements

2021-12-14 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-26556. -- Resolution: Fixed Merged into master and cherry-picked into branch-2,

[jira] [Updated] (HBASE-26522) Improve documentation of hbase 1.x to 2.x potential incompatibilities

2021-12-14 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-26522: -- Description: We're working on a major upgrade of almost 900 tables across 100

[jira] [Updated] (HBASE-26556) IT and Chaos Monkey improvements

2021-12-14 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26556: - Fix Version/s: 2.5.0 2.3.8 2.4.9 > IT and

[jira] [Updated] (HBASE-26556) IT and Chaos Monkey improvements

2021-12-14 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26556: - Affects Version/s: 2.4.7 2.3.7 > IT and Chaos Monkey

[jira] [Updated] (HBASE-26522) Improve documentation of hbase 1.x to 2.x potential incompatibilities

2021-12-14 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-26522: -- Description: We're working on a major upgrade of almost 900 tables across 100

[GitHub] [hbase] rmarsch commented on a change in pull request #3944: HBASE-26576

2021-12-14 Thread GitBox
rmarsch commented on a change in pull request #3944: URL: https://github.com/apache/hbase/pull/3944#discussion_r769065613 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java ## @@ -274,6 +275,41 @@ public void

[GitHub] [hbase] rmarsch opened a new pull request #3944: HBASE-26576

2021-12-14 Thread GitBox
rmarsch opened a new pull request #3944: URL: https://github.com/apache/hbase/pull/3944 Allow pluggable queue to be used with the fast path executor or normal balanced executor. https://issues.apache.org/jira/browse/HBASE-26576 -- This is an automated message from the Apache Git

[GitHub] [hbase] apurtell commented on a change in pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-14 Thread GitBox
apurtell commented on a change in pull request #3936: URL: https://github.com/apache/hbase/pull/3936#discussion_r769064443 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/io/util/TestLRUDictionary.java ## @@ -81,9 +83,8 @@ public void

[jira] [Updated] (HBASE-26556) IT and Chaos Monkey improvements

2021-12-14 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26556: - Fix Version/s: 2.6.0 > IT and Chaos Monkey improvements >

[jira] [Updated] (HBASE-26556) IT and Chaos Monkey improvements

2021-12-14 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26556: - Affects Version/s: 2.4.8 2.5.0

[jira] [Updated] (HBASE-26556) IT and Chaos Monkey improvements

2021-12-14 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26556: - Affects Version/s: 3.0.0-alpha-1 > IT and Chaos Monkey improvements >

[GitHub] [hbase] wchevreuil merged pull request #3932: HBASE-26556 IT and Chaos Monkey improvements

2021-12-14 Thread GitBox
wchevreuil merged pull request #3932: URL: https://github.com/apache/hbase/pull/3932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] wchevreuil commented on pull request #3932: HBASE-26556 IT and Chaos Monkey improvements

2021-12-14 Thread GitBox
wchevreuil commented on pull request #3932: URL: https://github.com/apache/hbase/pull/3932#issuecomment-994024484 > Re-reviewed after last update. Looks good to me. We can update docs with how to use in follow-on. Thanks @joshelser . Yeah, was just waiting the qa run before replying

[GitHub] [hbase] apurtell edited a comment on pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-14 Thread GitBox
apurtell edited a comment on pull request #3936: URL: https://github.com/apache/hbase/pull/3936#issuecomment-994018233 > We could just use multiple PRs to get them in You want me to close this and open multiple PRs? How many PRs? How would you divide this? One PR per module? One PR

[GitHub] [hbase] apurtell edited a comment on pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-14 Thread GitBox
apurtell edited a comment on pull request #3936: URL: https://github.com/apache/hbase/pull/3936#issuecomment-994018233 > We could just use multiple PRs to get them in You want me to close this and open multiple PRs? How many PRs? How would you divide this? One PR per module? One PR

[GitHub] [hbase] apurtell edited a comment on pull request #3936: HBASE-26555 Fix findbugs/spotbugs findings

2021-12-14 Thread GitBox
apurtell edited a comment on pull request #3936: URL: https://github.com/apache/hbase/pull/3936#issuecomment-994018233 > We could just use multiple PRs to get them in You want me to close this and open multiple PRs? How many PRs? How would you divide this? One PR per module? One PR

  1   2   >