[GitHub] [hbase] sunhelly merged pull request #4001: Backport HBASE-26578 CompactedHFilesDischarger should be shutdown whe…

2022-01-04 Thread GitBox
sunhelly merged pull request #4001: URL: https://github.com/apache/hbase/pull/4001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4001: Backport HBASE-26578 CompactedHFilesDischarger should be shutdown whe…

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4001: URL: https://github.com/apache/hbase/pull/4001#issuecomment-1005443675 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4001: Backport HBASE-26578 CompactedHFilesDischarger should be shutdown whe…

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4001: URL: https://github.com/apache/hbase/pull/4001#issuecomment-1005441639 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #4002: HBASE-26632 Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4002: URL: https://github.com/apache/hbase/pull/4002#issuecomment-1005438364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3990: HBASE-26397 Display the excluded datanodes on regionserver UI

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3990: URL: https://github.com/apache/hbase/pull/3990#issuecomment-1005427276 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4002: HBASE-26632 Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4002: URL: https://github.com/apache/hbase/pull/4002#issuecomment-1005425627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4002: HBASE-26632 Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4002: URL: https://github.com/apache/hbase/pull/4002#issuecomment-1005425233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] fcb-xiaobo opened a new pull request #4002: HBASE-26632 Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md

2022-01-04 Thread GitBox
fcb-xiaobo opened a new pull request #4002: URL: https://github.com/apache/hbase/pull/4002 HBASE-26632 Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1005422265 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #3990: HBASE-26397 Display the excluded datanodes on regionserver UI

2022-01-04 Thread GitBox
Apache9 commented on a change in pull request #3990: URL: https://github.com/apache/hbase/pull/3990#discussion_r778565108 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ## @@ -398,6 +404,17 @@ public long

[GitHub] [hbase] Apache-HBase commented on pull request #3990: HBASE-26397 Display the excluded datanodes on regionserver UI

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3990: URL: https://github.com/apache/hbase/pull/3990#issuecomment-1005381850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4001: Backport HBASE-26578 CompactedHFilesDischarger should be shutdown whe…

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4001: URL: https://github.com/apache/hbase/pull/4001#issuecomment-1005366547 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] sunhelly commented on a change in pull request #3990: HBASE-26397 Display the excluded datanodes on regionserver UI

2022-01-04 Thread GitBox
sunhelly commented on a change in pull request #3990: URL: https://github.com/apache/hbase/pull/3990#discussion_r778527912 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ## @@ -398,6 +403,17 @@ public long

[GitHub] [hbase] Apache9 commented on a change in pull request #3990: HBASE-26397 Display the excluded datanodes on regionserver UI

2022-01-04 Thread GitBox
Apache9 commented on a change in pull request #3990: URL: https://github.com/apache/hbase/pull/3990#discussion_r778524352 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ## @@ -398,6 +403,17 @@ public long

[jira] [Commented] (HBASE-26567) Remove IndexType from ChunkCreator

2022-01-04 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468998#comment-17468998 ] chenglei commented on HBASE-26567: -- [~zhangduo],thank you very much for help code review. > Remove

[GitHub] [hbase] sunhelly opened a new pull request #4001: Backport HBASE-26578 CompactedHFilesDischarger should be shutdown whe…

2022-01-04 Thread GitBox
sunhelly opened a new pull request #4001: URL: https://github.com/apache/hbase/pull/4001 …n aborting regionserver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] sunhelly merged pull request #3946: HBASE-26578 CompactedHFilesDischarger should be shutdown when abortin…

2022-01-04 Thread GitBox
sunhelly merged pull request #3946: URL: https://github.com/apache/hbase/pull/3946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-26567) Remove IndexType from ChunkCreator

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468994#comment-17468994 ] Hudson commented on HBASE-26567: Results for branch branch-2 [build #434 on

[GitHub] [hbase] sunhelly commented on a change in pull request #3990: HBASE-26397 Display the excluded datanodes on regionserver UI

2022-01-04 Thread GitBox
sunhelly commented on a change in pull request #3990: URL: https://github.com/apache/hbase/pull/3990#discussion_r778518829 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ## @@ -398,6 +403,17 @@ public long

[jira] [Commented] (HBASE-26386) Refactor StoreFileTracker implementations to expose the set method

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468987#comment-17468987 ] Hudson commented on HBASE-26386: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26454) CreateTableProcedure still relies on temp dir and renames when creating table FS layout

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468991#comment-17468991 ] Hudson commented on HBASE-26454: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26286) Add support for specifying store file tracker when restoring or cloning snapshot

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468992#comment-17468992 ] Hudson commented on HBASE-26286: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26263) [Rolling Upgrading] Persist the StoreFileTracker configurations to TableDescriptor for existing tables

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468989#comment-17468989 ] Hudson commented on HBASE-26263: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26224) Introduce a MigrationStoreFileTracker to support migrating from different store file tracker implementations

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468981#comment-17468981 ] Hudson commented on HBASE-26224: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26326) CreateTableProcedure fails when FileBasedStoreFileTracker is set in global config

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468986#comment-17468986 ] Hudson commented on HBASE-26326: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26264) Add more checks to prevent misconfiguration on store file tracker

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468984#comment-17468984 ] Hudson commented on HBASE-26264: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26246) Persist the StoreFileTracker configurations to TableDescriptor when creating table

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468982#comment-17468982 ] Hudson commented on HBASE-26246: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26631) Upgrade junit to 4.13.2

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468993#comment-17468993 ] Hudson commented on HBASE-26631: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26328) Clone snapshot doesn't load reference files into FILE SFT impl

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468988#comment-17468988 ] Hudson commented on HBASE-26328: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26079) Use StoreFileTracker when splitting and merging

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468980#comment-17468980 ] Hudson commented on HBASE-26079: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26280) Use store file tracker when snapshoting

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468985#comment-17468985 ] Hudson commented on HBASE-26280: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26271) Cleanup the broken store files under data directory

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468990#comment-17468990 ] Hudson commented on HBASE-26271: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-25988) Store the store file list by a file

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468979#comment-17468979 ] Hudson commented on HBASE-25988: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26248) Should find a suitable way to let users specify the store file tracker implementation

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468983#comment-17468983 ] Hudson commented on HBASE-26248: Results for branch branch-2 [build #434 on

[jira] [Commented] (HBASE-26064) Introduce a StoreFileTracker to abstract the store file tracking logic

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468978#comment-17468978 ] Hudson commented on HBASE-26064: Results for branch branch-2 [build #434 on

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1005336497 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26233) The region replication framework should not be built upon the general replication framework

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468969#comment-17468969 ] Duo Zhang commented on HBASE-26233: --- {quote} Can we start a discussion on backporting it to branch-2?

[GitHub] [hbase] Apache9 commented on a change in pull request #3992: HBASE-26006 Update ref guide about the 2.4.x release line

2022-01-04 Thread GitBox
Apache9 commented on a change in pull request #3992: URL: https://github.com/apache/hbase/pull/3992#discussion_r778511208 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -289,14 +289,14 @@ Use the following legend to interpret this table:

[jira] (HBASE-26634) Upgrade log4j to 2.17.1

2022-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/HBASE-26634 ] 范成波 deleted comment on HBASE-26634: - was (Author: fan cheng bo): i want to try > Upgrade log4j to 2.17.1 > --- > > Key: HBASE-26634 > URL:

[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1005299061 > Yes, the latest version doesn’t work with java 8. Still should fix the other bugs tho Per my read of https://errorprone.info/docs/installation#jdk-8, 2.10.0 is the

[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1005298249 > Maybe we could change the pre commit compile stage to use java11 with --release=8? Doesn't work, #3974 -- This is an automated message from the Apache Git Service.

[GitHub] [hbase] ndimiduk commented on a change in pull request #3979: HBASE-26622 Update error-prone to 2.10

2022-01-04 Thread GitBox
ndimiduk commented on a change in pull request #3979: URL: https://github.com/apache/hbase/pull/3979#discussion_r778484786 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java ## @@ -1102,10 +1102,11 @@ private int calculateHashForKey(Cell cell) {

[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005296457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1005273664 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4000: HBASE-26543 correct parsing of shell args with GetoptLong

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4000: URL: https://github.com/apache/hbase/pull/4000#issuecomment-1005268510 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4000: HBASE-26543 correct parsing of shell args with GetoptLong

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4000: URL: https://github.com/apache/hbase/pull/4000#issuecomment-1005267884 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4000: HBASE-26543 correct parsing of shell args with GetoptLong

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #4000: URL: https://github.com/apache/hbase/pull/4000#issuecomment-1005265863 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] busbey opened a new pull request #4000: HBASE-26543 correct parsing of shell args with GetoptLong

2022-01-04 Thread GitBox
busbey opened a new pull request #4000: URL: https://github.com/apache/hbase/pull/4000 Since Ruby's getoptlong library can't handle config definitions of the form `-Dkey=value`, we preprocess all args to pull out config definitions. After that preprocessing, the remaining changes

[GitHub] [hbase] ndimiduk commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1005258889 Canceling patch as this is blocked by a bug in javac. See the issue linked from JIRA. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ndimiduk closed pull request #3999: HBASE-26645 Upgrade create-release to use JDK11

2022-01-04 Thread GitBox
ndimiduk closed pull request #3999: URL: https://github.com/apache/hbase/pull/3999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26645) Upgrade create-release to use JDK11

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26645: - Assignee: (was: Nick Dimiduk) Status: Open (was: Patch Available) > Upgrade

[GitHub] [hbase] ndimiduk closed pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk closed pull request #3974: URL: https://github.com/apache/hbase/pull/3974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25465: - Assignee: (was: Nick Dimiduk) Status: Open (was: Patch Available) Canceling patch

[jira] [Commented] (HBASE-26233) The region replication framework should not be built upon the general replication framework

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468916#comment-17468916 ] Nick Dimiduk commented on HBASE-26233: -- This is great [~zhangduo] , congratulations! Can we start

[GitHub] [hbase] busbey commented on a change in pull request #3992: HBASE-26006 Update ref guide about the 2.4.x release line

2022-01-04 Thread GitBox
busbey commented on a change in pull request #3992: URL: https://github.com/apache/hbase/pull/3992#discussion_r778454171 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -289,14 +289,14 @@ Use the following legend to interpret this table:

[GitHub] [hbase] busbey commented on pull request #3641: HBASE-26006 Update ref guide about the 2.4.x release line

2022-01-04 Thread GitBox
busbey commented on pull request #3641: URL: https://github.com/apache/hbase/pull/3641#issuecomment-1005246788 a belated apology for missing this notification Duo. thanks for taking care of things. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ndimiduk commented on a change in pull request #3992: HBASE-26006 Update ref guide about the 2.4.x release line

2022-01-04 Thread GitBox
ndimiduk commented on a change in pull request #3992: URL: https://github.com/apache/hbase/pull/3992#discussion_r778451927 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -289,14 +289,14 @@ Use the following legend to interpret this table:

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1005226544 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2022-01-04 Thread Giuseppe Valente (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468887#comment-17468887 ] Giuseppe Valente commented on HBASE-24309: -- My bad I think this change was a red herring,

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-01-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468880#comment-17468880 ] Andrew Kyle Purtell commented on HBASE-25465: - JDK-8214165 seems to closed in favor of

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468868#comment-17468868 ] Nick Dimiduk commented on HBASE-25465: -- I'm pretty sure this will not work with today's version of

[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005192587 I'm pretty sure this will not work with today's version of JDK11 ; we appear to be blocked by [JDK-8214165](https://bugs.openjdk.java.net/browse/JDK-8214165). -- This is an

[GitHub] [hbase] joshelser commented on pull request #3937: HBASE-26555 Fix findbugs/spotbugs findings

2022-01-04 Thread GitBox
joshelser commented on pull request #3937: URL: https://github.com/apache/hbase/pull/3937#issuecomment-1005157127 Oh bother, now I see #3936 has the same changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005126570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk commented on a change in pull request #3974: URL: https://github.com/apache/hbase/pull/3974#discussion_r778345876 ## File path: pom.xml ## @@ -1725,7 +1725,9 @@ -MM-dd'T'HH:mm ${maven.build.timestamp} + 1.8 Review comment: Ah,

[GitHub] [hbase] Apache-HBase commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005108975 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005103719 It's never as simple as that... ``` $ env JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home mvn clean install assembly:single -DskipTests

[GitHub] [hbase] madrob commented on a change in pull request #3999: HBASE-26645 Upgrade create-release to use JDK11

2022-01-04 Thread GitBox
madrob commented on a change in pull request #3999: URL: https://github.com/apache/hbase/pull/3999#discussion_r778329498 ## File path: dev-support/create-release/hbase-rm/Dockerfile ## @@ -34,13 +34,13 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get -qq -y update \

[GitHub] [hbase] madrob commented on a change in pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
madrob commented on a change in pull request #3974: URL: https://github.com/apache/hbase/pull/3974#discussion_r778326539 ## File path: pom.xml ## @@ -1725,7 +1725,9 @@ -MM-dd'T'HH:mm ${maven.build.timestamp} + 1.8 Review comment: I

[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005094596 > > Perhaps the change to `create-release` can be done in isolation to the change to the pom. > > Yes, let's have separated issues for these two changes. The

[GitHub] [hbase] Apache-HBase commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1005094669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1005092157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1005091653 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25465: - Summary: Use javac --release option for supporting cross version compilation (was: Use javac

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468775#comment-17468775 ] Nick Dimiduk commented on HBASE-25465: -- See also HBASE-26645. > Use javac --release option for

[jira] [Updated] (HBASE-26645) Upgrade create-release to use JDK11

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26645: - Affects Version/s: 3.0.0-alpha-3 > Upgrade create-release to use JDK11 >

[jira] [Updated] (HBASE-26645) Upgrade create-release to use JDK11

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26645: - Status: Patch Available (was: Open) > Upgrade create-release to use JDK11 >

[GitHub] [hbase] ndimiduk opened a new pull request #3999: HBASE-26645 Upgrade create-release to use JDK11

2022-01-04 Thread GitBox
ndimiduk opened a new pull request #3999: URL: https://github.com/apache/hbase/pull/3999 update create-release Dockerfile to use jdk11-headless Requires #3974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (HBASE-26645) Upgrade create-release to use JDK11

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26645: - Summary: Upgrade create-release to use JDK11 (was: Upgrade create-release to use jdk11) >

[jira] [Created] (HBASE-26645) Upgrade create-release to use jdk11

2022-01-04 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26645: Summary: Upgrade create-release to use jdk11 Key: HBASE-26645 URL: https://issues.apache.org/jira/browse/HBASE-26645 Project: HBase Issue Type: Improvement

[jira] [Commented] (HBASE-26617) Use spotless to reduce the pain on fixing checkstyle issues

2022-01-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468770#comment-17468770 ] Nick Dimiduk commented on HBASE-26617: -- Selecting tooling and automated enforcement will be great.

[GitHub] [hbase] taklwu commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
taklwu commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r778307814 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/security/oauthbearer/OAuthBearerValidatorCallbackTest.java ## @@ -0,0 +1,65 @@ +/* + *

[GitHub] [hbase] taklwu commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
taklwu commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r778306068 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/security/oauthbearer/internals/knox/OAuthBearerSignedJwtValidatorCallbackHandler.java ##

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1005066031 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26642) Increase the timeout for TestStochasticLoadBalancerRegionReplicaLargeCluster

2022-01-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468758#comment-17468758 ] Hudson commented on HBASE-26642: Results for branch branch-2 [build #433 on

[jira] [Commented] (HBASE-26643) TestCreateTableWithMasterFailover and TestTruncateTableWithMasterFailover are flaky

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468748#comment-17468748 ] Duo Zhang commented on HBASE-26643: --- OK, finally I find out that, on master branch, all the

[GitHub] [hbase] Apache-HBase commented on pull request #3998: HBASE-26585 Add SFT configuration to META table descriptor when creating META

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3998: URL: https://github.com/apache/hbase/pull/3998#issuecomment-1004989501 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anmolnar commented on a change in pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
anmolnar commented on a change in pull request #3934: URL: https://github.com/apache/hbase/pull/3934#discussion_r778218640 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/OAuthBearerSaslServerAuthenticationProvider.java ## @@ -0,0 +1,99 @@

[jira] [Updated] (HBASE-26567) Remove IndexType from ChunkCreator

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26567: -- Fix Version/s: 2.5.0 3.0.0-alpha-3 Hadoop Flags: Reviewed Resolution:

[jira] [Created] (HBASE-26644) Spurious compaction failures with file tracker

2022-01-04 Thread Josh Elser (Jira)
Josh Elser created HBASE-26644: -- Summary: Spurious compaction failures with file tracker Key: HBASE-26644 URL: https://issues.apache.org/jira/browse/HBASE-26644 Project: HBase Issue Type:

[GitHub] [hbase] Apache9 merged pull request #3947: HBASE-26567 Remove IndexType from ChunkCreator

2022-01-04 Thread GitBox
Apache9 merged pull request #3947: URL: https://github.com/apache/hbase/pull/3947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-26631) Upgrade junit to 4.13.2

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26631. --- Hadoop Flags: Reviewed Release Note: Upgrade junit to 4.13.2 for addressing CVE-2020-15250.

[jira] [Commented] (HBASE-26632) Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468705#comment-17468705 ] Duo Zhang commented on HBASE-26632: --- [~Fan Cheng Bo] Assigned the issue to you. Please open a PR to

[GitHub] [hbase] Apache-HBase commented on pull request #3934: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-01-04 Thread GitBox
Apache-HBase commented on pull request #3934: URL: https://github.com/apache/hbase/pull/3934#issuecomment-1004935063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Assigned] (HBASE-26632) Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26632: - Assignee: 范成波 > Should use downloads.apache.org for checksum, signature, changes.md and >

[jira] [Updated] (HBASE-26631) Upgrade junit to 4.13.2

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26631: -- Fix Version/s: 2.5.0 3.0.0-alpha-3 2.4.10 > Upgrade junit to

[GitHub] [hbase] Apache9 merged pull request #3997: HBASE-26631 Upgrade junit to 4.13.2

2022-01-04 Thread GitBox
Apache9 merged pull request #3997: URL: https://github.com/apache/hbase/pull/3997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-26067) Change the way on how we track store file list

2022-01-04 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468703#comment-17468703 ] Josh Elser commented on HBASE-26067: {quote}Let me go for a merge and then resolve this issue

[jira] [Resolved] (HBASE-26634) Upgrade log4j to 2.17.1

2022-01-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26634. --- Fix Version/s: 3.0.0-alpha-3 Hadoop Flags: Reviewed Resolution: Fixed Merged to master.

[GitHub] [hbase] Apache9 merged pull request #3996: HBASE-26634 Upgrade log4j to 2.17.1

2022-01-04 Thread GitBox
Apache9 merged pull request #3996: URL: https://github.com/apache/hbase/pull/3996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >