Apache9 merged PR #4636:
URL: https://github.com/apache/hbase/pull/4636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.
Apache-HBase commented on PR #4634:
URL: https://github.com/apache/hbase/pull/4634#issuecomment-1191079460
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 39s | Docker
Apache-HBase commented on PR #4636:
URL: https://github.com/apache/hbase/pull/4636#issuecomment-1191072806
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 51s | Docker
Apache-HBase commented on PR #4634:
URL: https://github.com/apache/hbase/pull/4634#issuecomment-1191056006
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s | Docke
Apache-HBase commented on PR #4636:
URL: https://github.com/apache/hbase/pull/4636#issuecomment-1191039397
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 24s | Docke
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r926225943
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r926225943
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27231:
-
Description: Just as HBASE-27233 said, basically, if the {{WAL}} write to
HDFS fails, we do not know whe
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27231:
-
Summary: FSHLog should retry writing WAL entries when syncs to HDFS failed.
(was: Make FSHLog retry wri
[
https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27231:
-
Description: Just as HBASE-27233 said, basically, if the {{WAL}} write to
HDFS fails, we do not know whe
chenglei created HBASE-27231:
Summary: Make FSHLog retry writing WAL entries when syncs to HDFS
failed.
Key: HBASE-27231
URL: https://issues.apache.org/jira/browse/HBASE-27231
Project: HBase
Iss
[
https://issues.apache.org/jira/browse/HBASE-27230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27230:
-
Description: As HBASE-27223 said, if {{WAL.sync}} get a timeout exception,
the only correct way is to a
[
https://issues.apache.org/jira/browse/HBASE-27230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27230:
-
Description: As HBASE-27223 said, if here we get a timeout exception, the
only correct way is to abort t
[
https://issues.apache.org/jira/browse/HBASE-27230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27230:
-
Description: As HBASE-27223 said, if we get a timeout exception, the only
correct way is to abort the r
chenglei created HBASE-27230:
Summary: RegionServer should abort when WAL.sync throws
TimeoutIOException.
Key: HBASE-27230
URL: https://issues.apache.org/jira/browse/HBASE-27230
Project: HBase
I
[
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569235#comment-17569235
]
Hudson commented on HBASE-27152:
Results for branch branch-2.5
[build #168 on
b
[
https://issues.apache.org/jira/browse/HBASE-27219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569234#comment-17569234
]
Hudson commented on HBASE-27219:
Results for branch branch-2.5
[build #168 on
b
Apache-HBase commented on PR #4634:
URL: https://github.com/apache/hbase/pull/4634#issuecomment-1190947293
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
Apache-HBase commented on PR #4636:
URL: https://github.com/apache/hbase/pull/4636#issuecomment-1190941682
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 56s | Docke
Apache-HBase commented on PR #4639:
URL: https://github.com/apache/hbase/pull/4639#issuecomment-1190936440
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 40s | Docke
[
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reopened HBASE-27152:
---
This breaks several UTs.
Revert for now.
[~Xiaolin Ha] Please see the TestCompaction.testCompactionQue
Apache-HBase commented on PR #4638:
URL: https://github.com/apache/hbase/pull/4638#issuecomment-1190915790
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s | Docke
[
https://issues.apache.org/jira/browse/HBASE-27219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569217#comment-17569217
]
Hudson commented on HBASE-27219:
Results for branch master
[build #638 on
build
[
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569218#comment-17569218
]
Hudson commented on HBASE-27152:
Results for branch master
[build #638 on
build
[
https://issues.apache.org/jira/browse/HBASE-27225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault reassigned HBASE-27225:
-
Assignee: Bryan Beaudreault
> Add BucketAllocator bucket size statistic logging
[
https://issues.apache.org/jira/browse/HBASE-27229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27229:
--
Assignee: Bryan Beaudreault
Labels: patch-available (was: )
Status: Patch
bbeaudreault opened a new pull request, #4639:
URL: https://github.com/apache/hbase/pull/4639
This change mirrors how it works in LruBlockCache and the other
implementations. A `evictedByEvictionProcess` boolean is added to doEvictBlock
and blockEvicted, which wraps the `cacheStats.evicted`
Apache-HBase commented on PR #4637:
URL: https://github.com/apache/hbase/pull/4637#issuecomment-1190896415
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 12s | Docke
Bryan Beaudreault created HBASE-27229:
-
Summary: BucketCache statistics should not count evictions by hfile
Key: HBASE-27229
URL: https://issues.apache.org/jira/browse/HBASE-27229
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-27225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27225:
--
Labels: patch-available (was: )
Status: Patch Available (was: Open)
[https://git
[
https://issues.apache.org/jira/browse/HBASE-27224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27224:
--
Labels: patch-available (was: )
Status: Patch Available (was: Open)
Submitted a
bbeaudreault opened a new pull request, #4638:
URL: https://github.com/apache/hbase/pull/4638
Wraps the existing codahale Histogram in a KeyValueStats object. This object
tracks the global min and max sizes for the statistic, since Histogram's is
subject to sampling. Additionally adds a new
bbeaudreault opened a new pull request, #4637:
URL: https://github.com/apache/hbase/pull/4637
Example output (with log4j log formatting prefixes removed for clarity):
```
Bucket allocator statistics follow:
Free bytes=5325249536; used bytes=35391673344; total bytes=40716922880;
Apache-HBase commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190819126
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s | Docker
Bryan Beaudreault created HBASE-27228:
-
Summary: Client connection warming API
Key: HBASE-27228
URL: https://issues.apache.org/jira/browse/HBASE-27228
Project: HBase
Issue Type: Improveme
[
https://issues.apache.org/jira/browse/HBASE-27227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27227:
--
Attachment: Screen Shot 2022-07-20 at 10.52.40 AM.png
> Long running heavily filtered
Bryan Beaudreault created HBASE-27227:
-
Summary: Long running heavily filtered scans hold up too many
ByteBuffAllocator buffers
Key: HBASE-27227
URL: https://issues.apache.org/jira/browse/HBASE-27227
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925636963
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925636963
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925636963
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
[
https://issues.apache.org/jira/browse/HBASE-27224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27224:
--
Status: Open (was: Patch Available)
MutableRangeHistogram did not work. It did improv
[
https://issues.apache.org/jira/browse/HBASE-27224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27224:
--
Labels: (was: patch-available)
> HFile tool statistic sampling produces misleading r
bbeaudreault closed pull request #4635: HBASE-27224 HFile tool statistic
sampling produces misleading results
URL: https://github.com/apache/hbase/pull/4635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bbeaudreault commented on PR #4635:
URL: https://github.com/apache/hbase/pull/4635#issuecomment-1190308613
Closing this PR -- going to go in a different direction.
I realized that MutableRangeHistogram's buckets actually are very inaccurate
on the first call to `histogram.snapshot()`.
anmolnar commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190297370
Rebase + spotless fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Apache9 commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190285426
> Anyone has a clue what would be the spotless-friendly formatting of these
ZK references?
>
> Spotless merges them with the existing paragraphs which looks ugly:
>
> ```diff
anmolnar commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190266158
Anyone has a clue what would be the spotless-friendly formatting of these ZK
references?
Spotless merges them with the existing paragraphs which looks ugly:
```diff
/**
Apache9 commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925576679
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms";
bbeaudreault commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190251948
Also looks like spotless and checkstyle in the latest change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Apache-HBase commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190241202
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 14s | Docker
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925547822
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925547822
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
bbeaudreault commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190215769
Would you mind rebasing so we can clear this warning before we merge?
> Used diff version of patch file. Binary files and potentially other
changes not applied. Please rebase and squ
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925527887
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925527215
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms
Apache-HBase commented on PR #4634:
URL: https://github.com/apache/hbase/pull/4634#issuecomment-1190168395
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 7s | Docke
anmolnar commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190115110
Thanks @joshelser . I created a ticket for the doc part:
https://issues.apache.org/jira/browse/HBASE-27226
--
This is an automated message from the Apache Git Service.
To respond to the
Andor Molnar created HBASE-27226:
Summary: Document native TLS support in Netty RPC
Key: HBASE-27226
URL: https://issues.apache.org/jira/browse/HBASE-27226
Project: HBase
Issue Type: Task
Apache-HBase commented on PR #4636:
URL: https://github.com/apache/hbase/pull/4636#issuecomment-1189938359
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s | Docke
59 matches
Mail list logo
