[GitHub] [hbase] Apache-HBase commented on pull request #4722: HBASE-27214 Implement the new replication hfile/log cleaner

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4722: URL: https://github.com/apache/hbase/pull/4722#issuecomment-1223904457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #4660: HBASE-27249 Remove invalid peer RegionServer crash

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4660: URL: https://github.com/apache/hbase/pull/4660#issuecomment-1223893895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
Apache9 commented on code in PR #4717: URL: https://github.com/apache/hbase/pull/4717#discussion_r952442854 ## src/main/asciidoc/_chapters/security.adoc: ## @@ -675,6 +675,228 @@ For more information about ACLs, please see the

[GitHub] [hbase] Apache9 commented on a diff in pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
Apache9 commented on code in PR #4717: URL: https://github.com/apache/hbase/pull/4717#discussion_r952437909 ## src/main/asciidoc/_chapters/security.adoc: ## @@ -675,6 +675,228 @@ For more information about ACLs, please see the

[GitHub] [hbase] SiCheng-Zheng commented on a diff in pull request #4570: HBASE-27132 Log archiving fail cause regionserver abort

2022-08-23 Thread GitBox
SiCheng-Zheng commented on code in PR #4570: URL: https://github.com/apache/hbase/pull/4570#discussion_r952437189 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -816,6 +816,11 @@ protected void archiveLogFile(final Path p)

[jira] [Updated] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-27231: - Description: Just as HBASE-27223 said, basically, if the {{WAL}} write to HDFS fails, we do not know

[jira] [Updated] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-27231: - Description: Just as HBASE-27223 said, basically, if the {{WAL}} write to HDFS fails, we do not know

[jira] [Updated] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-27231: - Description: Just as HBASE-27223 said, basically, if the {{WAL}} write to HDFS fails, we do not know

[GitHub] [hbase] SiCheng-Zheng commented on pull request #4660: HBASE-27249 Remove invalid peer RegionServer crash

2022-08-23 Thread GitBox
SiCheng-Zheng commented on PR #4660: URL: https://github.com/apache/hbase/pull/4660#issuecomment-1223862850 > I mean why adding the check can fix the problem? From the HBASE-27249 log, Remove invalid peer causes InterruptedException. Thread.currentThread().isInterrupted() does not meet

[jira] [Updated] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-27231: - Description: Just as HBASE-27223 said, basically, if the {{WAL}} write to HDFS fails, we do not know

[GitHub] [hbase] comnetwork opened a new pull request, #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
comnetwork opened a new pull request, #4721: URL: https://github.com/apache/hbase/pull/4721 …S failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1223834839 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[jira] [Created] (HBASE-27317) Correcting the Store file tracker tool help doc option

2022-08-23 Thread Abhradeep Kundu (Jira)
Abhradeep Kundu created HBASE-27317: --- Summary: Correcting the Store file tracker tool help doc option Key: HBASE-27317 URL: https://issues.apache.org/jira/browse/HBASE-27317 Project: HBase

[GitHub] [hbase] mwkang opened a new pull request, #4720: HBASE-27315 Add timeout to JavaRegexEngine

2022-08-23 Thread GitBox
mwkang opened a new pull request, #4720: URL: https://github.com/apache/hbase/pull/4720 Add timeout to JavaRegexEngine to prevent ReDoS. https://issues.apache.org/jira/browse/HBASE-27315 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1223781069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache-HBase commented on pull request #4719: HBASE-27316 Time based metrics will be reset after any get request

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4719: URL: https://github.com/apache/hbase/pull/4719#issuecomment-1223768320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[GitHub] [hbase] Apache-HBase commented on pull request #4719: HBASE-27316 Time based metrics will be reset after any get request

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4719: URL: https://github.com/apache/hbase/pull/4719#issuecomment-1223761652 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4719: HBASE-27316 Time based metrics will be reset after any get request

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4719: URL: https://github.com/apache/hbase/pull/4719#issuecomment-1223760597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s |

[jira] [Commented] (HBASE-27316) Time based metrics will be reset after any get request

2022-08-23 Thread Yunbo Fan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583440#comment-17583440 ] Yunbo Fan commented on HBASE-27316: --- !screenshot-1.png! > Time based metrics will be reset after any

[jira] [Updated] (HBASE-27316) Time based metrics will be reset after any get request

2022-08-23 Thread Yunbo Fan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunbo Fan updated HBASE-27316: -- Attachment: screenshot-1.png > Time based metrics will be reset after any get request >

[GitHub] [hbase] fanyunbojerry opened a new pull request, #4719: HBASE-27316 Time based metrics will be reset after any get request

2022-08-23 Thread GitBox
fanyunbojerry opened a new pull request, #4719: URL: https://github.com/apache/hbase/pull/4719 Jmx metrics can be query by http request. But metrics will be reset after any get request. The root cause may be the implement of Histogram's method "snapshot" public Snapshot

[jira] [Created] (HBASE-27316) Time based metrics will be reset after any get request

2022-08-23 Thread Yunbo Fan (Jira)
Yunbo Fan created HBASE-27316: - Summary: Time based metrics will be reset after any get request Key: HBASE-27316 URL: https://issues.apache.org/jira/browse/HBASE-27316 Project: HBase Issue Type:

[jira] [Resolved] (HBASE-27311) The implementation of syncReplicationPeerLock is incomplete

2022-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27311. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~sunxin] for reviewing!

[GitHub] [hbase] Apache9 merged pull request #4715: HBASE-27311 The implementation of syncReplicationPeerLock is incomplete

2022-08-23 Thread GitBox
Apache9 merged PR #4715: URL: https://github.com/apache/hbase/pull/4715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4718: HBASE-27314 Make index block be customized and configured

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4718: URL: https://github.com/apache/hbase/pull/4718#issuecomment-1223626896 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[GitHub] [hbase] Apache-HBase commented on pull request #4718: HBASE-27314 Make index block be customized and configured

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4718: URL: https://github.com/apache/hbase/pull/4718#issuecomment-1223625635 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #4718: HBASE-27314 Make index block be customized and configured

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4718: URL: https://github.com/apache/hbase/pull/4718#issuecomment-1223623614 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[jira] [Assigned] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei reassigned HBASE-27231: Assignee: chenglei > FSHLog should retry writing WAL entries when syncs to HDFS failed. >

[jira] [Work started] (HBASE-27231) FSHLog should retry writing WAL entries when syncs to HDFS failed.

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27231 started by chenglei. > FSHLog should retry writing WAL entries when syncs to HDFS failed. >

<    1   2