[GitHub] [hbase] Apache-HBase commented on pull request #4821: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4821: URL: https://github.com/apache/hbase/pull/4821#issuecomment-1274154138 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4824: HBASE-27421 Bump spotless plugin to 2.27.2 and reimplement the 'Remov…

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4824: URL: https://github.com/apache/hbase/pull/4824#issuecomment-1274141328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 14s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1274121599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docke

[GitHub] [hbase] Apache9 opened a new pull request, #4824: HBASE-27421 Bump spotless plugin to 2.27.2 and reimplement the 'Remov…

2022-10-10 Thread GitBox
Apache9 opened a new pull request, #4824: URL: https://github.com/apache/hbase/pull/4824 …e unhelpful javadoc stubs' rule -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule

2022-10-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27421: - Assignee: Duo Zhang > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful java

[jira] [Work started] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule

2022-10-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27421 started by Duo Zhang. - > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc > stu

[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
2005hithlj commented on code in PR #4811: URL: https://github.com/apache/hbase/pull/4811#discussion_r991828225 ## hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/TableReplicationQueueStorage.java: ## @@ -532,4 +532,13 @@ public Set getAllHFileRefs() throws R

[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1274097018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1274040172 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

[GitHub] [hbase] virajjasani commented on a diff in pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server

2022-10-10 Thread GitBox
virajjasani commented on code in PR #4823: URL: https://github.com/apache/hbase/pull/4823#discussion_r991778115 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -314,7 +314,9 @@ private void succeed(Channel ch) throws IOException {

[GitHub] [hbase] Apache9 commented on a diff in pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
Apache9 commented on code in PR #4811: URL: https://github.com/apache/hbase/pull/4811#discussion_r991774124 ## hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/TableReplicationQueueStorage.java: ## @@ -532,4 +532,13 @@ public Set getAllHFileRefs() throws Repl

[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1274026630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s | Docke

[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink

2022-10-10 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615433#comment-17615433 ] Lijin Bin commented on HBASE-27414: --- Can you supply any patch? > Search order for loc

[jira] [Resolved] (HBASE-27419) Update to hbase-thirdparty 4.1.2

2022-10-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27419. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+. Thanks [~apurtell] for review

[jira] [Resolved] (HBASE-27314) Make index block be customized and configured

2022-10-10 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin resolved HBASE-27314. --- Resolution: Fixed > Make index block be customized and configured >

[jira] [Assigned] (HBASE-27314) Make index block be customized and configured

2022-10-10 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin reassigned HBASE-27314: - Fix Version/s: 2.6.0 2.5.1 3.0.0-alpha-4 Assignee

[GitHub] [hbase] sunhelly commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen

2022-10-10 Thread GitBox
sunhelly commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1274002030 Thanks @apurtell for the review, I'll dig more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4823: URL: https://github.com/apache/hbase/pull/4823#issuecomment-1274000797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4823: URL: https://github.com/apache/hbase/pull/4823#issuecomment-1273998887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4823: URL: https://github.com/apache/hbase/pull/4823#issuecomment-1273995115 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

[GitHub] [hbase] Apache9 commented on a diff in pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server

2022-10-10 Thread GitBox
Apache9 commented on code in PR #4823: URL: https://github.com/apache/hbase/pull/4823#discussion_r991747624 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -314,7 +314,9 @@ private void succeed(Channel ch) throws IOException { }

[GitHub] [hbase] dependabot[bot] closed pull request #4815: Bump protobuf-java from 3.17.3 to 3.19.6 in /hbase-examples

2022-10-10 Thread GitBox
dependabot[bot] closed pull request #4815: Bump protobuf-java from 3.17.3 to 3.19.6 in /hbase-examples URL: https://github.com/apache/hbase/pull/4815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] dependabot[bot] commented on pull request #4815: Bump protobuf-java from 3.17.3 to 3.19.6 in /hbase-examples

2022-10-10 Thread GitBox
dependabot[bot] commented on PR #4815: URL: https://github.com/apache/hbase/pull/4815#issuecomment-1273984533 Looks like com.google.protobuf:protobuf-java is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hbase] Apache9 merged pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2

2022-10-10 Thread GitBox
Apache9 merged PR #4818: URL: https://github.com/apache/hbase/pull/4818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

[jira] [Updated] (HBASE-27339) Improve sasl connection failure log message to include server

2022-10-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27339: Status: Patch Available (was: Open) > Improve sasl connection failure log message

[GitHub] [hbase] apurtell opened a new pull request, #4823: HBASE-27339 Improve sasl connection failure log message to include server

2022-10-10 Thread GitBox
apurtell opened a new pull request, #4823: URL: https://github.com/apache/hbase/pull/4823 Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection. -- This is an automat

[GitHub] [hbase] Apache9 commented on pull request #4821: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004

2022-10-10 Thread GitBox
Apache9 commented on PR #4821: URL: https://github.com/apache/hbase/pull/4821#issuecomment-1273983170 2.14.0-rc2 is out, maybe we should wait for 2.14.0 final release and then upgrading? Will need a new thirdparty release then... -- This is an automated message from the Apache Git Service

[jira] [Updated] (HBASE-27339) Improve sasl connection failure log message to include server

2022-10-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27339: Fix Version/s: 2.5.1 (was: 2.5.2) > Improve sasl connection

[jira] [Assigned] (HBASE-27339) Improve sasl connection failure log message to include server

2022-10-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-27339: --- Assignee: Andrew Kyle Purtell > Improve sasl connection failure log message

[GitHub] [hbase] Apache9 commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150

2022-10-10 Thread GitBox
Apache9 commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1273979438 The jettison dependency is introduced by hadoop. I'm not sure whether upgrading jettison directly will break hadoop. There is a related issue in hadoop to fix jettison. https:/

[GitHub] [hbase] Apache-HBase commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1273973300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4821: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4821: URL: https://github.com/apache/hbase/pull/4821#issuecomment-1273965732 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docke

[jira] [Updated] (HBASE-27424) Upgrade Jettison for CVE-2022-40149/40150

2022-10-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27424: Status: Patch Available (was: Open) > Upgrade Jettison for CVE-2022-40149/40150 >

[GitHub] [hbase] apurtell commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150

2022-10-10 Thread GitBox
apurtell commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1273951689 Checked before push with tests in `hbase-rest`. All passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] apurtell opened a new pull request, #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150

2022-10-10 Thread GitBox
apurtell opened a new pull request, #4822: URL: https://github.com/apache/hbase/pull/4822 Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150. Move jettison.version to 1.5.1. -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Created] (HBASE-27424) Upgrade Jettison for CVE-2022-40149/40150

2022-10-10 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-27424: --- Summary: Upgrade Jettison for CVE-2022-40149/40150 Key: HBASE-27424 URL: https://issues.apache.org/jira/browse/HBASE-27424 Project: HBase Issue

[jira] [Updated] (HBASE-27423) Upgrade Jackson for CVE-2022-42003/42004

2022-10-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27423: Status: Patch Available (was: Open) > Upgrade Jackson for CVE-2022-42003/42004 >

[GitHub] [hbase] apurtell opened a new pull request, #4821: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004

2022-10-10 Thread GitBox
apurtell opened a new pull request, #4821: URL: https://github.com/apache/hbase/pull/4821 Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes CVE-2022-42004. Move jackson.version to 2.13.4. Move jackson.databind.version to 2.14.0-rc1. -- This is an automated messag

[jira] [Created] (HBASE-27423) Upgrade Jackson for CVE-2022-42003/42004

2022-10-10 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-27423: --- Summary: Upgrade Jackson for CVE-2022-42003/42004 Key: HBASE-27423 URL: https://issues.apache.org/jira/browse/HBASE-27423 Project: HBase Issue

[jira] [Updated] (HBASE-27411) Update and clean up bcprov-jdk15on dependency

2022-10-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27411: Fix Version/s: 2.4.15 Hadoop Flags: Reviewed Resolution: Fixed

[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1273921294 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273913802 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docke

[GitHub] [hbase] apurtell merged pull request #4817: HBASE-27411 Update and clean up bcprov-jdk15on dependency

2022-10-10 Thread GitBox
apurtell merged PR #4817: URL: https://github.com/apache/hbase/pull/4817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

[GitHub] [hbase] shahrs87 commented on a diff in pull request #4556: HBASE-26913 Replication Observability Framework

2022-10-10 Thread GitBox
shahrs87 commented on code in PR #4556: URL: https://github.com/apache/hbase/pull/4556#discussion_r991680391 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMarkerChore.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software F

[GitHub] [hbase] Apache-HBase commented on pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4818: URL: https://github.com/apache/hbase/pull/4818#issuecomment-1273838797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

[jira] [Work started] (HBASE-27422) Support replication for hbase:acl

2022-10-10 Thread Shanmukha Haripriya Kota (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27422 started by Shanmukha Haripriya Kota. > Support replication for hbase:acl > -

[GitHub] [hbase] Apache-HBase commented on pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4818: URL: https://github.com/apache/hbase/pull/4818#issuecomment-1273682475 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker

[jira] [Commented] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2022-10-10 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615265#comment-17615265 ] Sandeep Pal commented on HBASE-25848: - This solved the problem since we used it in t

[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table

2022-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615259#comment-17615259 ] Hudson commented on HBASE-27109: Results for branch HBASE-27109/table_based_rqs

[jira] [Created] (HBASE-27422) Support replication for hbase:acl

2022-10-10 Thread Shanmukha Haripriya Kota (Jira)
Shanmukha Haripriya Kota created HBASE-27422: Summary: Support replication for hbase:acl Key: HBASE-27422 URL: https://issues.apache.org/jira/browse/HBASE-27422 Project: HBase Iss

[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273593399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4788: HBASE-21521 Expose master startup status via web UI

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4788: URL: https://github.com/apache/hbase/pull/4788#issuecomment-1273559031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4788: HBASE-21521 Expose master startup status via web UI

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4788: URL: https://github.com/apache/hbase/pull/4788#issuecomment-1273505183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 11s | Docke

[jira] [Updated] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule

2022-10-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27421: -- Description: spotless maven 2.27.2 is released and it contains https://github.com/diffplug/spotless/is

[jira] [Updated] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule

2022-10-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27421: -- Description: spotless maven 2.27.2 is released and it contains https://github.com/diffplug/spotless/is

[jira] [Updated] (HBASE-27403) Remove 'Remove unhelpful javadoc stubs' spotless rule for now

2022-10-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27403: -- Component/s: pom > Remove 'Remove unhelpful javadoc stubs' spotless rule for now > ---

[jira] [Updated] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule

2022-10-10 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27421: -- Component/s: documentation pom > Bump spotless plugin to 2.27.2 and reimplement the '

[jira] [Created] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule

2022-10-10 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27421: - Summary: Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule Key: HBASE-27421 URL: https://issues.apache.org/jira/browse/HBASE-27421 Pr

[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1273455845 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1273434696 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4818: URL: https://github.com/apache/hbase/pull/4818#issuecomment-1273395213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

[GitHub] [hbase] 2005hithlj commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
2005hithlj commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273319765 > > In this PR please, so in ReplicationLogCleaner we do not need to use TableDescriptors to test whether the table exists, then we do not need to modify some of the UTs?

[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273319719 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docke

[GitHub] [hbase] Apache9 commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
Apache9 commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273315904 In this PR please, so in ReplicationLogCleaner we do not need to use TableDescriptors to test whether the table exists, then we do not need to modify some of the UTs? -- This is an autom

[GitHub] [hbase] 2005hithlj commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
2005hithlj commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273313026 > > > Maybe we'd better add a method in ReplicationQueueStorage to test whether there are queue data? It could hide the implementation detail. > > > > > > @Apache9 sir, Can you

[GitHub] [hbase] Apache9 commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
Apache9 commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273298122 > > Maybe we'd better add a method in ReplicationQueueStorage to test whether there are queue data? It could hide the implementation detail. > > @Apache9 sir, Can you give me some det

[GitHub] [hbase] 2005hithlj commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
2005hithlj commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273292894 > Maybe we'd better add a method in ReplicationQueueStorage to test whether there are queue data? It could hide the implementation detail. @Apache9 sir, Can you give me some detai

[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist

2022-10-10 Thread GitBox
2005hithlj commented on code in PR #4811: URL: https://github.com/apache/hbase/pull/4811#discussion_r991271572 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java: ## @@ -314,4 +318,24 @@ public ZKWatcher getZooKeeper() { return null;

[GitHub] [hbase] Apache-HBase commented on pull request #4788: HBASE-21521 Expose master startup status via web UI

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4788: URL: https://github.com/apache/hbase/pull/4788#issuecomment-1273247018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docke

[jira] [Commented] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected

2022-10-10 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615038#comment-17615038 ] chaijunjie commented on HBASE-26967: [~zhangduo] hi, I think there are an example to

[jira] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected

2022-10-10 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26967 ] chaijunjie deleted comment on HBASE-26967: was (Author: JIRAUSER286971): [~zhangduo] sure,if we skip filterRow for a filter which do not have a filterRow method is better, i will change this

[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1273095284 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docke

[GitHub] [hbase] Apache9 commented on a diff in pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2

2022-10-10 Thread GitBox
Apache9 commented on code in PR #4818: URL: https://github.com/apache/hbase/pull/4818#discussion_r991109817 ## hbase-protocol-shaded/pom.xml: ## @@ -34,7 +34,7 @@ -3.21.1 +3.21.7 Review Comment: Will open a new issue if I find a way to do this. -- This is a

[jira] [Updated] (HBASE-27333) Abort RS when the hostname is different from master seen

2022-10-10 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-27333: --- Description: For HRegionServer#handleReportForDutyResponse, when the hostname is different from the

[jira] [Updated] (HBASE-27333) Abort RS when the hostname is different from master seen

2022-10-10 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-27333: --- Summary: Abort RS when the hostname is different from master seen (was: The condition for using the

[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1273012483 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1272999452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1272912381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docke

[GitHub] [hbase] sunhelly commented on pull request #4732: HBASE-27333 The condition for using the local hostname is the opposite

2022-10-10 Thread GitBox
sunhelly commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1272904771 Thanks, @Apache9 and @apurtell . After looking at [HBASE-12954](https://issues.apache.org/jira/browse/HBASE-12954), I think we should abort the RS when the hostname from master seen is dif

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2022-10-10 Thread GitBox
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1272903581 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

[jira] [Commented] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected

2022-10-10 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614941#comment-17614941 ] chaijunjie commented on HBASE-26967: [~zhangduo] sure,if we skip filterRow for a fil