[GitHub] [hbase] Apache-HBase commented on pull request #4810: HBASE-27217 Revisit the DumpReplicationQueues tool

2022-10-22 Thread GitBox
Apache-HBase commented on PR #4810: URL: https://github.com/apache/hbase/pull/4810#issuecomment-1287845261 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache9 commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-10-22 Thread GitBox
Apache9 commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1287817537 I suggest we just change the code in FSHLog, without touching AsyncFSWAL too much. @comnetwork -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache9 commented on pull request #4765: HBASE-27358 Avoid synchronization in AsyncFSWAL

2022-10-22 Thread GitBox
Apache9 commented on PR #4765: URL: https://github.com/apache/hbase/pull/4765#issuecomment-1287815165 Mind explaining your approach here? Just looking at the code I can not fully catch what is going on here... Thanks. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] comnetwork commented on a diff in pull request #4756: HBASE-27354 EOF thrown by WALEntryStream causes replication blocking

2022-10-22 Thread GitBox
comnetwork commented on code in PR #4756: URL: https://github.com/apache/hbase/pull/4756#discussion_r1002478326 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java: ## @@ -255,15 +255,21 @@ private void dequeueCurrentLog() throws

[GitHub] [hbase] Apache-HBase commented on pull request #4842: HBASE-27438 Make release scripts can generate CHANGES.md and RELEASEN…

2022-10-22 Thread GitBox
Apache-HBase commented on PR #4842: URL: https://github.com/apache/hbase/pull/4842#issuecomment-1287784966 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 13s |

[GitHub] [hbase] Apache-HBase commented on pull request #4842: HBASE-27438 Make release scripts can generate CHANGES.md and RELEASEN…

2022-10-22 Thread GitBox
Apache-HBase commented on PR #4842: URL: https://github.com/apache/hbase/pull/4842#issuecomment-1287784945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #4842: HBASE-27438 Make release scripts can generate CHANGES.md and RELEASEN…

2022-10-22 Thread GitBox
Apache-HBase commented on PR #4842: URL: https://github.com/apache/hbase/pull/4842#issuecomment-1287783764 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache9 opened a new pull request, #4842: HBASE-27438 Make release scripts can generate CHANGES.md and RELEASEN…

2022-10-22 Thread GitBox
Apache9 opened a new pull request, #4842: URL: https://github.com/apache/hbase/pull/4842 …OTES.md for 3.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache9 commented on a diff in pull request #4827: HBASE-27422: Support replication for hbase:acl

2022-10-22 Thread GitBox
Apache9 commented on code in PR #4827: URL: https://github.com/apache/hbase/pull/4827#discussion_r1002459244 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/SystemTableWALEntryFilter.java: ## @@ -17,16 +17,24 @@ */ package