[GitHub] [hbase] Apache-HBase commented on pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4859: URL: https://github.com/apache/hbase/pull/4859#issuecomment-1301699593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 38s | Docke

[jira] [Updated] (HBASE-27452) RegionServer JVM crash when scan

2022-11-02 Thread gaofeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gaofeng updated HBASE-27452: Description: jdk8 + hadoop3 + bucketcache + g1 In our cluster, we found region servers may be crashed in

[jira] [Updated] (HBASE-27452) RegionServer JVM crash when scan

2022-11-02 Thread gaofeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gaofeng updated HBASE-27452: Description: jdk8 + hadoop3 + bucketcache + g1 + hbase2.3.5 In our cluster, we found region servers may b

[GitHub] [hbase] Apache9 commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
Apache9 commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1301570535 I've posted my +1 on the mailing list. Please close the vote and I will merge this PR to master. And I believe you guys also want this feature on branch-2? Then please start the backport wo

[jira] [Commented] (HBASE-27462) scan ipc.RpcServer: Unexpected throwable object

2022-11-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628070#comment-17628070 ] Duo Zhang commented on HBASE-27462: --- Please try to upgrade to a newer version of hbase

[jira] [Created] (HBASE-27462) scan ipc.RpcServer: Unexpected throwable object

2022-11-02 Thread gaofeng (Jira)
gaofeng created HBASE-27462: --- Summary: scan ipc.RpcServer: Unexpected throwable object Key: HBASE-27462 URL: https://issues.apache.org/jira/browse/HBASE-27462 Project: HBase Issue Type: Bug

[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1301504892 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1301444983 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4859: URL: https://github.com/apache/hbase/pull/4859#issuecomment-1301085088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1301077610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4859: URL: https://github.com/apache/hbase/pull/4859#issuecomment-1301076730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

[GitHub] [hbase] shahrs87 commented on pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
shahrs87 commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1301008595 > Overall LGTM, using random region and skip it when splitting seems OK. Thank you @Apache9 for your review. > Please fill follow on issue to add support for multi WAL. Created

[jira] [Created] (HBASE-27461) Add multiWAL support for Replication Observability framework.

2022-11-02 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-27461: Summary: Add multiWAL support for Replication Observability framework. Key: HBASE-27461 URL: https://issues.apache.org/jira/browse/HBASE-27461 Project: HBase

[GitHub] [hbase] shahrs87 commented on a diff in pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
shahrs87 commented on code in PR #4556: URL: https://github.com/apache/hbase/pull/4556#discussion_r1012104040 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMarkerChore.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] shahrs87 commented on a diff in pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
shahrs87 commented on code in PR #4556: URL: https://github.com/apache/hbase/pull/4556#discussion_r1012103800 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMarkerChore.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] shahrs87 commented on a diff in pull request #4556: HBASE-26913 Replication Observability Framework

2022-11-02 Thread GitBox
shahrs87 commented on code in PR #4556: URL: https://github.com/apache/hbase/pull/4556#discussion_r1012103432 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java: ## @@ -138,11 +143,13 @@ public void run() { }

[GitHub] [hbase] Apache-HBase commented on pull request #4860: HBASE-27460 Fix the hadolint errors after HBASE-27456

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4860: URL: https://github.com/apache/hbase/pull/4860#issuecomment-1300894707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 29s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4860: HBASE-27460 Fix the hadolint errors after HBASE-27456

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4860: URL: https://github.com/apache/hbase/pull/4860#issuecomment-1300894236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 59s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4860: HBASE-27460 Fix the hadolint errors after HBASE-27456

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4860: URL: https://github.com/apache/hbase/pull/4860#issuecomment-1300894011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 23s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4860: HBASE-27460 Fix the hadolint errors after HBASE-27456

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4860: URL: https://github.com/apache/hbase/pull/4860#issuecomment-1300880394 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/H

[GitHub] [hbase] Apache-HBase commented on pull request #4860: HBASE-27460 Fix the hadolint errors after HBASE-27456

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4860: URL: https://github.com/apache/hbase/pull/4860#issuecomment-1300880308 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/H

[GitHub] [hbase] Apache-HBase commented on pull request #4860: HBASE-27460 Fix the hadolint errors after HBASE-27456

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4860: URL: https://github.com/apache/hbase/pull/4860#issuecomment-1300879858 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/H

[GitHub] [hbase] Apache-HBase commented on pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4859: URL: https://github.com/apache/hbase/pull/4859#issuecomment-1300693656 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

[GitHub] [hbase] 2005hithlj commented on pull request #4810: HBASE-27217 Revisit the DumpReplicationQueues tool

2022-11-02 Thread GitBox
2005hithlj commented on PR #4810: URL: https://github.com/apache/hbase/pull/4810#issuecomment-1300659815 > I've done a rebase on [HBASE-27109](https://issues.apache.org/jira/browse/HBASE-27109), please also rebase here. > > Thanks. @2005hithlj @Apache9 OK sir, and I will have

[GitHub] [hbase] frostruan commented on pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
frostruan commented on PR #4859: URL: https://github.com/apache/hbase/pull/4859#issuecomment-1300621764 Thanks for reviewing Duo.Let's wait for the unit test results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] frostruan commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
frostruan commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011901234 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReadPointCalculationLock.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hbase] Apache9 commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
Apache9 commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011890230 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReadPointCalculationLock.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [hbase] frostruan commented on pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
frostruan commented on PR #4859: URL: https://github.com/apache/hbase/pull/4859#issuecomment-1300596312 Hi Duo @Apache9 I added a new commit. Would mind taking a look in your free time and see is this what you expect ? -- This is an automated message from the Apache Git Service.

[jira] [Created] (HBASE-27460) Fix the hadolint errors after HBASE-27456

2022-11-02 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27460: - Summary: Fix the hadolint errors after HBASE-27456 Key: HBASE-27460 URL: https://issues.apache.org/jira/browse/HBASE-27460 Project: HBase Issue Type: Task

[jira] [Work started] (HBASE-27460) Fix the hadolint errors after HBASE-27456

2022-11-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27460 started by Duo Zhang. - > Fix the hadolint errors after HBASE-27456 > ---

[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table

2022-11-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627718#comment-17627718 ] Hudson commented on HBASE-27109: Results for branch HBASE-27109/table_based_rqs

[jira] [Commented] (HBASE-27451) Setup nightly job for s390x node

2022-11-02 Thread Jonathan Albrecht (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627717#comment-17627717 ] Jonathan Albrecht commented on HBASE-27451: --- Sorry for the delay but I haven't

[GitHub] [hbase] frostruan commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
frostruan commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011747893 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java: ## @@ -130,19 +130,34 @@ private static boolean hasNonce(HRegion region, long

[jira] [Created] (HBASE-27459) Improve our hbase_docker to be able to build and start standalone clusters other than master branch

2022-11-02 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27459: - Summary: Improve our hbase_docker to be able to build and start standalone clusters other than master branch Key: HBASE-27459 URL: https://issues.apache.org/jira/browse/HBASE-27459

[jira] [Assigned] (HBASE-27459) Improve our hbase_docker to be able to build and start standalone clusters other than master branch

2022-11-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27459: - Assignee: Duo Zhang > Improve our hbase_docker to be able to build and start standalone cluster

[jira] [Work started] (HBASE-27459) Improve our hbase_docker to be able to build and start standalone clusters other than master branch

2022-11-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27459 started by Duo Zhang. - > Improve our hbase_docker to be able to build and start standalone clusters > other

[GitHub] [hbase] Apache9 commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
Apache9 commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011738398 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java: ## @@ -130,19 +130,34 @@ private static boolean hasNonce(HRegion region, long

[GitHub] [hbase] frostruan commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
frostruan commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011638229 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java: ## @@ -130,19 +130,34 @@ private static boolean hasNonce(HRegion region, long

[GitHub] [hbase] frostruan commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
frostruan commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011630652 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java: ## @@ -130,19 +130,34 @@ private static boolean hasNonce(HRegion region, long

[GitHub] [hbase] Apache9 commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
Apache9 commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011620789 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java: ## @@ -130,19 +130,34 @@ private static boolean hasNonce(HRegion region, long

[GitHub] [hbase] frostruan commented on a diff in pull request #4859: HBASE-27458 Use ReadWriteLock for region scanner readpoint map

2022-11-02 Thread GitBox
frostruan commented on code in PR #4859: URL: https://github.com/apache/hbase/pull/4859#discussion_r1011605880 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java: ## @@ -130,19 +130,34 @@ private static boolean hasNonce(HRegion region, long

[GitHub] [hbase] 2005hithlj commented on pull request #4849: HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables

2022-11-02 Thread GitBox
2005hithlj commented on PR #4849: URL: https://github.com/apache/hbase/pull/4849#issuecomment-1299888598 > Please check the failure UT for hbase-shell? @Apache9 sir. I have modified the shell UT code, and the UTs are successfully executed in the new commit. -- This i

[jira] [Updated] (HBASE-27435) Make Prometheus metrics queryable

2022-11-02 Thread Luca Kovacs (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Kovacs updated HBASE-27435: Description: To provide the same features that JMX has, I would like to implement querying in Pro

[GitHub] [hbase] Apache-HBase commented on pull request #4849: HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4849: URL: https://github.com/apache/hbase/pull/4849#issuecomment-1299767789 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4849: HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables

2022-11-02 Thread GitBox
Apache-HBase commented on PR #4849: URL: https://github.com/apache/hbase/pull/4849#issuecomment-1299733113 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke