[GitHub] [hbase] Apache9 merged pull request #4951: HBASE-27528 log duplication issues in MasterRpcServices.

2023-01-19 Thread GitBox
Apache9 merged PR #4951: URL: https://github.com/apache/hbase/pull/4951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 merged pull request #4953: HBASE-27562 Publish SBOM artifacts

2023-01-19 Thread GitBox
Apache9 merged PR #4953: URL: https://github.com/apache/hbase/pull/4953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 merged pull request #4968: HBASE-27564 Add default encryption type for MiniKDC to fix failed tests on JDK11+

2023-01-19 Thread GitBox
Apache9 merged PR #4968: URL: https://github.com/apache/hbase/pull/4968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on a diff in pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-19 Thread GitBox
Apache9 commented on code in PR #4945: URL: https://github.com/apache/hbase/pull/4945#discussion_r1082188117 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java: ## @@ -153,6 +153,25 @@ public class AssignmentManager { private

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398017223 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[jira] [Comment Edited] (HBASE-27572) resource leak for store flush during high load

2023-01-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678998#comment-17678998 ] Viraj Jasani edited comment on HBASE-27572 at 1/20/23 6:19 AM: --- Could you

[jira] [Comment Edited] (HBASE-27572) resource leak for store flush during high load

2023-01-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678998#comment-17678998 ] Viraj Jasani edited comment on HBASE-27572 at 1/20/23 6:15 AM: --- Could you

[jira] [Commented] (HBASE-27572) resource leak for store flush during high load

2023-01-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678998#comment-17678998 ] Viraj Jasani commented on HBASE-27572: -- Could you also try

[jira] [Comment Edited] (HBASE-27572) resource leak for store flush during high load

2023-01-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678997#comment-17678997 ] Viraj Jasani edited comment on HBASE-27572 at 1/20/23 6:10 AM: ---

[jira] [Commented] (HBASE-27572) resource leak for store flush during high load

2023-01-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678997#comment-17678997 ] Viraj Jasani commented on HBASE-27572: -- [~mszpatusko] Thanks for reporting. Have you also tried

[GitHub] [hbase] virajjasani commented on a diff in pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
virajjasani commented on code in PR #4986: URL: https://github.com/apache/hbase/pull/4986#discussion_r1082136488 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java: ## @@ -387,59 +390,45 @@ private static boolean hasNoReferences(final Pair

[jira] [Resolved] (HBASE-27557) [JDK17] Update shade plugin version

2023-01-19 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-27557. --- Hadoop Flags: Reviewed Resolution: Fixed > [JDK17] Update shade plugin version >

[jira] [Updated] (HBASE-27557) [JDK17] Update shade plugin version

2023-01-19 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-27557: -- Fix Version/s: 2.4.16 > [JDK17] Update shade plugin version > --- > >

[GitHub] [hbase] Reidddddd merged pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Reidd merged PR #4970: URL: https://github.com/apache/hbase/pull/4970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082095480 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, List

[jira] [Commented] (HBASE-27557) [JDK17] Update shade plugin version

2023-01-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678979#comment-17678979 ] Duo Zhang commented on HBASE-27557: --- https://github.com/apache/hbase/pull/4970 The latest build seems

[GitHub] [hbase] Apache-HBase commented on pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4970: URL: https://github.com/apache/hbase/pull/4970#issuecomment-1397897023 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s |

[jira] [Commented] (HBASE-27216) Revisit the ReplicationSyncUp tool

2023-01-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678976#comment-17678976 ] Duo Zhang commented on HBASE-27216: --- Oh, just cleaning the hbase:replication table is not enough, in

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397893200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4970: URL: https://github.com/apache/hbase/pull/4970#issuecomment-1397893048 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[GitHub] [hbase] Apache-HBase commented on pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4970: URL: https://github.com/apache/hbase/pull/4970#issuecomment-1397892160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082074168 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082074168 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[jira] [Commented] (HBASE-27557) [JDK17] Update shade plugin version

2023-01-19 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678963#comment-17678963 ] Reid Chan commented on HBASE-27557: --- Hi [~tangtianhang] will you fix the problem in branch-2.4's PR >

[jira] [Updated] (HBASE-27557) [JDK17] Update shade plugin version

2023-01-19 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-27557: -- Fix Version/s: 3.0.0-alpha-4 > [JDK17] Update shade plugin version >

[jira] [Updated] (HBASE-27557) [JDK17] Update shade plugin version

2023-01-19 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-27557: -- Fix Version/s: 2.6.0 2.5.3 > [JDK17] Update shade plugin version >

[GitHub] [hbase] Reidddddd merged pull request #4984: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.5

2023-01-19 Thread GitBox
Reidd merged PR #4984: URL: https://github.com/apache/hbase/pull/4984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Reidddddd merged pull request #4983: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2

2023-01-19 Thread GitBox
Reidd merged PR #4983: URL: https://github.com/apache/hbase/pull/4983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-20719) HTable.batch() doesn't handle TableNotFound correctly.

2023-01-19 Thread Sergey Soldatov (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Soldatov resolved HBASE-20719. - Resolution: Duplicate > HTable.batch() doesn't handle TableNotFound correctly. >

[jira] [Resolved] (HBASE-20926) IntegrationTestRSGroup is broken

2023-01-19 Thread Sergey Soldatov (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Soldatov resolved HBASE-20926. - Resolution: Invalid The class was refactored to a number of smaller tests >

[jira] [Commented] (HBASE-27575) Bump future from 0.18.2 to 0.18.3 in /dev-support

2023-01-19 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678960#comment-17678960 ] Tak-Lon (Stephen) Wu commented on HBASE-27575: -- pushed to 2.4, 2.5, branch-2, and master >

[jira] [Updated] (HBASE-27575) Bump future from 0.18.2 to 0.18.3 in /dev-support

2023-01-19 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27575: - Hadoop Flags: Reviewed Release Note: pushed to 2.4, 2.5, branch-2, and

[GitHub] [hbase] taklwu merged pull request #4980: HBASE-27575 Bump future from 0.18.2 to 0.18.3 in /dev-support

2023-01-19 Thread GitBox
taklwu merged PR #4980: URL: https://github.com/apache/hbase/pull/4980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082035135 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, List

[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table

2023-01-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678946#comment-17678946 ] Hudson commented on HBASE-27109: Results for branch HBASE-27109/table_based_rqs [build #46 on

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082010622 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, List

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082005656 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082004856 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082003715 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java: ## @@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082003715 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java: ## @@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082003004 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[jira] [Updated] (HBASE-27575) Bump future from 0.18.2 to 0.18.3 in /dev-support

2023-01-19 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27575: - Summary: Bump future from 0.18.2 to 0.18.3 in /dev-support (was: Bump future

[jira] [Updated] (HBASE-27566) Bump gitpython from 3.1.29 to 3.1.30 in /dev-support

2023-01-19 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27566: - Labels: patch-available (was: ) > Bump gitpython from 3.1.29 to 3.1.30 in

[GitHub] [hbase] taklwu commented on pull request #4980: Bump future from 0.18.2 to 0.18.3 in /dev-support

2023-01-19 Thread GitBox
taklwu commented on PR #4980: URL: https://github.com/apache/hbase/pull/4980#issuecomment-1397731165 should we edit the title of this PR and add HBASE-27575 as prefix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397716885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s |

[GitHub] [hbase] bbeaudreault commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397708589 Thanks for doing this @rda3mon -- i made a few small comments, and then I think we should be good. Extra reminder: make sure to run `mvn spotless:apply` after making the

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081946531 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java: ## @@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397705029 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[]

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[]

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081934099 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[jira] [Comment Edited] (HBASE-27539) Encapsulate and centralise access to ref count through StoreFileInfo

2023-01-19 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678929#comment-17678929 ] Tak-Lon (Stephen) Wu edited comment on HBASE-27539 at 1/19/23 10:23 PM:

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081932511 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[jira] [Reopened] (HBASE-27539) Encapsulate and centralise access to ref count through StoreFileInfo

2023-01-19 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reopened HBASE-27539: -- hi [~comnetwork] , [~wchevreuil]  , we're preparing for the 2.5.3 release and I

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[]

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081929395 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081926702 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397679103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 52s |

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397532353 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[jira] [Commented] (HBASE-27493) Allow namespace admins to clone snapshots created by them

2023-01-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678853#comment-17678853 ] Hudson commented on HBASE-27493: Results for branch master [build #758 on

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397469665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397433875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4986: URL: https://github.com/apache/hbase/pull/4986#discussion_r1081645332 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java: ## @@ -387,59 +390,45 @@ private static boolean hasNoReferences(final

[GitHub] [hbase] virajjasani commented on a diff in pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
virajjasani commented on code in PR #4986: URL: https://github.com/apache/hbase/pull/4986#discussion_r1081618087 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java: ## @@ -387,59 +390,45 @@ private static boolean hasNoReferences(final Pair

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397354936 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[jira] [Created] (HBASE-27580) Reverse scan over rows with tags throw exceptions when using DataBlockEncoding

2023-01-19 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-27580: - Summary: Reverse scan over rows with tags throw exceptions when using DataBlockEncoding Key: HBASE-27580 URL: https://issues.apache.org/jira/browse/HBASE-27580

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397182983 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s |

[GitHub] [hbase] joshelser commented on a diff in pull request #4979: HBASE-27574 Implement ClusterManager interface for Kubernetes

2023-01-19 Thread GitBox
joshelser commented on code in PR #4979: URL: https://github.com/apache/hbase/pull/4979#discussion_r1081422560 ## hbase-it/src/test/java/org/apache/hadoop/hbase/KubernetesClusterManager.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (HBASE-27579) CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27579: -- Status: Patch Available (was: Open) I decided to not touch openRegionFromFileSystem.

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397114998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] bbeaudreault opened a new pull request, #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
bbeaudreault opened a new pull request, #4986: URL: https://github.com/apache/hbase/pull/4986 There already existed a robust reference check method for cleaning splits, `checkDaughterInFs`. I cleaned that up a little bit and re-use it in cleanMergeRegion. This way both cleaning use the

[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1397095868 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s |

[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1397093394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397063707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 58s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397048241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table

2023-01-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678710#comment-17678710 ] Hudson commented on HBASE-27109: Results for branch HBASE-27109/table_based_rqs [build #45 on

[jira] [Assigned] (HBASE-27579) CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault reassigned HBASE-27579: - Assignee: Bryan Beaudreault > CatalogJanitor can cause data loss due to errors

[jira] [Commented] (HBASE-27579) CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678673#comment-17678673 ] Bryan Beaudreault commented on HBASE-27579: --- Agreed. There is another usage of

[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1396837398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1396777434 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[jira] [Commented] (HBASE-27216) Revisit the ReplicationSyncUp tool

2023-01-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678608#comment-17678608 ] Duo Zhang commented on HBASE-27216: --- I've implemented the add missing replication queue logic and

[GitHub] [hbase] ragarkar commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
ragarkar commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1396733383 rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache9 closed pull request #4947: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache9 closed pull request #4947: HBASE-27216 Revisit the ReplicationSyncUp tool URL: https://github.com/apache/hbase/pull/4947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache9 commented on pull request #4947: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache9 commented on PR #4947: URL: https://github.com/apache/hbase/pull/4947#issuecomment-1396705734 Close in favor of #4966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache-HBase commented on pull request #4985: HBASE-27578 Upgrade hbase-thirdparty to 4.1.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4985: URL: https://github.com/apache/hbase/pull/4985#issuecomment-1396643022 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |