[GitHub] [hbase] ragarkar commented on a diff in pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-02-28 Thread via GitHub
ragarkar commented on code in PR #4799: URL: https://github.com/apache/hbase/pull/4799#discussion_r1121272883 ## hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java: ## @@ -553,6 +569,108 @@ enum LocalityType { RACK } + publi

[GitHub] [hbase] Apache-HBase commented on pull request #5067: HBASE-27532 Add block bytes scanned metrics

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5067: URL: https://github.com/apache/hbase/pull/5067#issuecomment-1449427530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5067: HBASE-27532 Add block bytes scanned metrics

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5067: URL: https://github.com/apache/hbase/pull/5067#issuecomment-1449418839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[jira] [Commented] (HBASE-27650) Merging empty regions corrupts meta cache

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694861#comment-17694861 ] Hudson commented on HBASE-27650: Results for branch branch-2 [build #755 on bui

[jira] [Commented] (HBASE-27655) Remove the empty path annotation from ClusterMetricsResource

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694864#comment-17694864 ] Hudson commented on HBASE-27655: Results for branch branch-2 [build #755 on bui

[jira] [Commented] (HBASE-27666) Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694865#comment-17694865 ] Hudson commented on HBASE-27666: Results for branch branch-2 [build #755 on bui

[jira] [Commented] (HBASE-24781) Clean up peer metrics when disabling peer

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694863#comment-17694863 ] Hudson commented on HBASE-24781: Results for branch branch-2 [build #755 on bui

[jira] [Commented] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694862#comment-17694862 ] Hudson commented on HBASE-27668: Results for branch branch-2 [build #755 on bui

[GitHub] [hbase] haohao0103 commented on a diff in pull request #5064: JIRAID:HBASE-27670

2023-02-28 Thread via GitHub
haohao0103 commented on code in PR #5064: URL: https://github.com/apache/hbase/pull/5064#discussion_r1121169968 ## hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java: ## @@ -203,20 +202,21 @@ public static FSDataOutputStream create(Configuration conf, FileSyst

[GitHub] [hbase] Apache9 commented on a diff in pull request #5064: JIRAID:HBASE-27670

2023-02-28 Thread via GitHub
Apache9 commented on code in PR #5064: URL: https://github.com/apache/hbase/pull/5064#discussion_r1121060856 ## hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java: ## @@ -203,20 +202,21 @@ public static FSDataOutputStream create(Configuration conf, FileSystem

[jira] [Commented] (HBASE-24781) Clean up peer metrics when disabling peer

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694842#comment-17694842 ] Hudson commented on HBASE-24781: Results for branch branch-2.4 [build #523 on b

[jira] [Commented] (HBASE-27650) Merging empty regions corrupts meta cache

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694841#comment-17694841 ] Hudson commented on HBASE-27650: Results for branch branch-2.4 [build #523 on b

[jira] [Commented] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694840#comment-17694840 ] Hudson commented on HBASE-27668: Results for branch branch-2.4 [build #523 on b

[GitHub] [hbase] Apache-HBase commented on pull request #5067: HBASE-27532 Add block bytes scanned metrics

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5067: URL: https://github.com/apache/hbase/pull/5067#issuecomment-1449273595 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

[jira] [Updated] (HBASE-27532) Add block bytes scanned metrics

2023-02-28 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27532: -- Labels: patch-available (was: ) Status: Patch Available (was: Open) > Add block

[jira] [Assigned] (HBASE-27532) Add block bytes scanned metrics

2023-02-28 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault reassigned HBASE-27532: - Assignee: Bryan Beaudreault > Add block bytes scanned metrics > ---

[GitHub] [hbase] bbeaudreault opened a new pull request, #5067: HBASE-27532 Add block bytes scanned metrics

2023-02-28 Thread via GitHub
bbeaudreault opened a new pull request, #5067: URL: https://github.com/apache/hbase/pull/5067 - Adds `countofBlockBytesScanned` to ScanMetrics, and incorporates that into TestScannerBlockSizeLimits assertions. - Renames server side RpcCall's counter from `responseBlockBytes` to `blockByt

[GitHub] [hbase] haohao0103 commented on pull request #5064: JIRAID:HBASE-27670

2023-02-28 Thread via GitHub
haohao0103 commented on PR #5064: URL: https://github.com/apache/hbase/pull/5064#issuecomment-1449169806 @Apache9 Hello, I have fixed this error, thank you very much for your patience, some places are not familiar with the first submission. thanks!!! -- This is an automated message from t

[GitHub] [hbase] Apache-HBase commented on pull request #5066: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5066: URL: https://github.com/apache/hbase/pull/5066#issuecomment-1448962754 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5066: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5066: URL: https://github.com/apache/hbase/pull/5066#issuecomment-1448931670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

[jira] [Commented] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694720#comment-17694720 ] Hudson commented on HBASE-27668: Results for branch branch-2.5 [build #307 on b

[jira] [Commented] (HBASE-24781) Clean up peer metrics when disabling peer

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694721#comment-17694721 ] Hudson commented on HBASE-24781: Results for branch branch-2.5 [build #307 on b

[jira] [Commented] (HBASE-27650) Merging empty regions corrupts meta cache

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694719#comment-17694719 ] Hudson commented on HBASE-27650: Results for branch branch-2.5 [build #307 on b

[jira] [Commented] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694712#comment-17694712 ] Hudson commented on HBASE-27668: Results for branch master [build #785 on build

[jira] [Commented] (HBASE-27650) Merging empty regions corrupts meta cache

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694711#comment-17694711 ] Hudson commented on HBASE-27650: Results for branch master [build #785 on build

[jira] [Commented] (HBASE-27655) Remove the empty path annotation from ClusterMetricsResource

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694709#comment-17694709 ] Hudson commented on HBASE-27655: Results for branch master [build #785 on build

[jira] [Commented] (HBASE-27660) Ignore invalid hostname when getNetworkInterfaces

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694710#comment-17694710 ] Hudson commented on HBASE-27660: Results for branch master [build #785 on build

[jira] [Commented] (HBASE-24781) Clean up peer metrics when disabling peer

2023-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694713#comment-17694713 ] Hudson commented on HBASE-24781: Results for branch master [build #785 on build

[jira] [Updated] (HBASE-27666) Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-28 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27666: -- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.5.4 R

[GitHub] [hbase] bbeaudreault merged pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-28 Thread via GitHub
bbeaudreault merged PR #5056: URL: https://github.com/apache/hbase/pull/5056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1448681260 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1448675841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5066: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5066: URL: https://github.com/apache/hbase/pull/5066#issuecomment-1448659789 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docke

[GitHub] [hbase-connectors] dependabot[bot] commented on pull request #100: Bump junit from 4.12 to 4.13.1

2023-02-28 Thread via GitHub
dependabot[bot] commented on PR #100: URL: https://github.com/apache/hbase-connectors/pull/100#issuecomment-1448647177 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versi

[GitHub] [hbase-connectors] petersomogyi closed pull request #100: Bump junit from 4.12 to 4.13.1

2023-02-28 Thread via GitHub
petersomogyi closed pull request #100: Bump junit from 4.12 to 4.13.1 URL: https://github.com/apache/hbase-connectors/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [hbase-connectors] petersomogyi commented on pull request #100: Bump junit from 4.12 to 4.13.1

2023-02-28 Thread via GitHub
petersomogyi commented on PR #100: URL: https://github.com/apache/hbase-connectors/pull/100#issuecomment-1448647123 #112 fixes this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [hbase] meszibalu merged pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
meszibalu merged PR #5065: URL: https://github.com/apache/hbase/pull/5065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apach

[jira] [Resolved] (HBASE-27678) Update checkstyle in hbase-connectors

2023-02-28 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-27678. --- Fix Version/s: hbase-connectors-1.1.0 Resolution: Fixed Merged to master. > Update c

[GitHub] [hbase-connectors] petersomogyi merged pull request #111: HBASE-27678 Update checkstyle to 8.45.1

2023-02-28 Thread via GitHub
petersomogyi merged PR #111: URL: https://github.com/apache/hbase-connectors/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #112: HBASE-27879 Bump junit to 4.13.2

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-connectors/pull/112#issuecomment-1448577887 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 8s

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448549135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker

[GitHub] [hbase] bbeaudreault commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
bbeaudreault commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1448527178 I wasn't sure if we could somehow use a mocked address, but didn't have much of any idea beyond that :). If nothing comes to mind and you verified in a cluster, then LGTM -- This is

[GitHub] [hbase] wchevreuil commented on a diff in pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-02-28 Thread via GitHub
wchevreuil commented on code in PR #4799: URL: https://github.com/apache/hbase/pull/4799#discussion_r1120400988 ## hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java: ## @@ -452,7 +459,10 @@ protected List balanceTable(TableName tab

[jira] [Updated] (HBASE-27679) Bump junit to 4.13.2 in hbase-connectors

2023-02-28 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-27679: -- Summary: Bump junit to 4.13.2 in hbase-connectors (was: Bump junit to 4.13.2) > Bump junit t

[jira] [Created] (HBASE-27679) Bump junit to 4.13.2

2023-02-28 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-27679: - Summary: Bump junit to 4.13.2 Key: HBASE-27679 URL: https://issues.apache.org/jira/browse/HBASE-27679 Project: HBase Issue Type: Task Components:

[GitHub] [hbase] Apache-HBase commented on pull request #5064: JIRAID:HBASE-27670

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5064: URL: https://github.com/apache/hbase/pull/5064#issuecomment-1448390863 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1448385481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5064: JIRAID:HBASE-27670

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5064: URL: https://github.com/apache/hbase/pull/5064#issuecomment-1448325341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1448294196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docke

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #111: HBASE-27678 Update checkstyle to 8.45.1

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #111: URL: https://github.com/apache/hbase-connectors/pull/111#issuecomment-1448278871 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1448267000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1448264762 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[GitHub] [hbase-connectors] dependabot[bot] commented on pull request #102: Bump checkstyle from 8.28 to 8.29

2023-02-28 Thread via GitHub
dependabot[bot] commented on PR #102: URL: https://github.com/apache/hbase-connectors/pull/102#issuecomment-1448245472 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versi

[GitHub] [hbase-connectors] petersomogyi commented on pull request #102: Bump checkstyle from 8.28 to 8.29

2023-02-28 Thread via GitHub
petersomogyi commented on PR #102: URL: https://github.com/apache/hbase-connectors/pull/102#issuecomment-1448245358 Superseded by #111. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [hbase-connectors] petersomogyi closed pull request #102: Bump checkstyle from 8.28 to 8.29

2023-02-28 Thread via GitHub
petersomogyi closed pull request #102: Bump checkstyle from 8.28 to 8.29 URL: https://github.com/apache/hbase-connectors/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (HBASE-24452) Try github ci for hbase-connectors

2023-02-28 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-24452. --- Resolution: Won't Do > Try github ci for hbase-connectors >

[GitHub] [hbase-connectors] petersomogyi closed pull request #69: HBASE-24452 Try github ci for hbase-connectors

2023-02-28 Thread via GitHub
petersomogyi closed pull request #69: HBASE-24452 Try github ci for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Created] (HBASE-27678) Update checkstyle in hbase-connectors

2023-02-28 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-27678: - Summary: Update checkstyle in hbase-connectors Key: HBASE-27678 URL: https://issues.apache.org/jira/browse/HBASE-27678 Project: HBase Issue Type: Task

[jira] [Updated] (HBASE-27655) Remove the empty path annotation from ClusterMetricsResource

2023-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27655: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the contribution [

[jira] [Updated] (HBASE-27655) Remove the empty path annotation from ClusterMetricsResource

2023-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27655: - Fix Version/s: 2.6.0 2.5.4 > Remove the empty path annotation from ClusterMet

[GitHub] [hbase] ndimiduk merged pull request #5061: Backport "HBASE-27655 Remove the empty path annotation from ClusterMetricsResource" to branch-2.5

2023-02-28 Thread via GitHub
ndimiduk merged PR #5061: URL: https://github.com/apache/hbase/pull/5061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

[GitHub] [hbase] ndimiduk merged pull request #5060: Backport "HBASE-27655 Remove the empty path annotation from ClusterMetricsResource" to branch-2

2023-02-28 Thread via GitHub
ndimiduk merged PR #5060: URL: https://github.com/apache/hbase/pull/5060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448162279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

[GitHub] [hbase] wchevreuil commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-02-28 Thread via GitHub
wchevreuil commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1448139983 > An update on testing. In addition to adding a unit test which considers different combinations of prefetch ratio on the currently hosting region server as well as historical prefetch r

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448096871 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448090194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448087711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1448085724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1448085509 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[GitHub] [hbase] meszibalu commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
meszibalu commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1448052232 > I agree with covering this with a unit test but I don't see how we can do that. @meszibalu Were you able to verify this change on an HBase cluster? Yes, I validated it. -- This

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448029214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448025560 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448019133 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5064: JIRAID:HBASE-27670

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5064: URL: https://github.com/apache/hbase/pull/5064#issuecomment-1448014037 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[GitHub] [hbase] Apache9 commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-28 Thread via GitHub
Apache9 commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1448000341 The PR is big, but most files are just boiler plate changes as we changed the class name for reading a WAL file. The most important things are: 1. Introduced two types of WAL r

[GitHub] [hbase] sunhelly commented on a diff in pull request #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2023-02-28 Thread via GitHub
sunhelly commented on code in PR #4536: URL: https://github.com/apache/hbase/pull/4536#discussion_r1119905433 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java: ## @@ -768,7 +768,11 @@ public boolean next(List outResult, ScannerContext scanner

[jira] [Created] (HBASE-27677) ReplaySyncReplicationWALCallable should consider WAL files which are not closed cleanly

2023-02-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27677: - Summary: ReplaySyncReplicationWALCallable should consider WAL files which are not closed cleanly Key: HBASE-27677 URL: https://issues.apache.org/jira/browse/HBASE-27677 Pro

[jira] [Resolved] (HBASE-24781) Clean up peer metrics when disabling peer

2023-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24781. --- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.4.17 2.

[jira] [Assigned] (HBASE-24781) Clean up peer metrics when disabling peer

2023-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24781: - Assignee: Yuta Imazu > Clean up peer metrics when disabling peer >

[GitHub] [hbase] mosmeh commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-02-28 Thread via GitHub
mosmeh commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1447839824 @Apache9 Here it is: https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mosmeh -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [hbase] Apache-HBase commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
Apache-HBase commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1447820433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[jira] [Created] (HBASE-27676) Scan handlers in the RPC executor should match at least one scan queues

2023-02-28 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-27676: -- Summary: Scan handlers in the RPC executor should match at least one scan queues Key: HBASE-27676 URL: https://issues.apache.org/jira/browse/HBASE-27676 Project: HBase

[GitHub] [hbase] meszibalu commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
meszibalu commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1447768627 > Is there any test we can easily add for this case? It's too bad this wasn't caught by tests It requires a test case where we connect to hbase from an IP address which is not loca