[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1506385825 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1506378224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1506245519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

[GitHub] [hbase] virajjasani commented on pull request #5155: HBASE-27536: Include more request information in slowlog for Scans

virajjasani commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1505906522 Thanks a lot, as always!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [hbase] Apache-HBase commented on pull request #5173: HBASE-27791 Upgrade vega and its related js libraries

Apache-HBase commented on PR #5173: URL: https://github.com/apache/hbase/pull/5173#issuecomment-1505872192 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505855574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505854462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505853183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5165: HBASE-27727 Implement filesystem based Replication peer storage

Apache-HBase commented on PR #5165: URL: https://github.com/apache/hbase/pull/5165#issuecomment-1505844982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5173: HBASE-27791 Upgrade vega and its related js libraries

Apache-HBase commented on PR #5173: URL: https://github.com/apache/hbase/pull/5173#issuecomment-1505759013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

[GitHub] [hbase] bbeaudreault commented on pull request #5155: HBASE-27536: Include more request information in slowlog for Scans

bbeaudreault commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1505723808 @virajjasani don't worry, I can take care of it. We're doing a quick end-to-end test internally before merging, just to make sure there aren't any small tweaks to make before committin

[GitHub] [hbase] virajjasani commented on pull request #5155: HBASE-27536: add Scan to slow log payload

virajjasani commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1505722441 Sorry, I could not get to my desk unfortunately hence will mostly merge this tomorrow morning unless it is already merged. Thanks a lot @rmdmattingly @bbeaudreault -- This is an a

[GitHub] [hbase] virajjasani commented on pull request #5167: HBASE-27698 Migrate meta locations from zookeeper to master data may …

virajjasani commented on PR #5167: URL: https://github.com/apache/hbase/pull/5167#issuecomment-1505718931 Thank you @chrajeshbabu. It seems the changes make sense from the upgrade viewpoint. On the other hand, if this rare scenario were to happen on a healthy 2.x cluster, does this change m

[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1505678441 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5165: HBASE-27727 Implement filesystem based Replication peer storage

Apache-HBase commented on PR #5165: URL: https://github.com/apache/hbase/pull/5165#issuecomment-1505578471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505491735 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505491815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505491787 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505441176 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505441507 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1505440057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker

[GitHub] [hbase] hgromer commented on a diff in pull request #5051: HBASE-26874 VerifyReplication recompare async

hgromer commented on code in PR #5051: URL: https://github.com/apache/hbase/pull/5051#discussion_r1164242877 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplicationRecompareRunnable.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Soft

[GitHub] [hbase] Apache9 commented on pull request #5121: HBASE-27733

Apache9 commented on PR #5121: URL: https://github.com/apache/hbase/pull/5121#issuecomment-1505395868 Ping @wchevreuil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [hbase] Apache9 commented on a diff in pull request #5170: HBASE-27667 Normalizer can skip picking presplit regions while prepar…

Apache9 commented on code in PR #5170: URL: https://github.com/apache/hbase/pull/5170#discussion_r1164230992 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java: ## @@ -246,23 +251,35 @@ public List computePlansForTable(final Tabl

[GitHub] [hbase] Apache9 commented on pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism

Apache9 commented on PR #5144: URL: https://github.com/apache/hbase/pull/5144#issuecomment-1505366757 This is only for http? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hbase] hgromer commented on a diff in pull request #5051: HBASE-26874 VerifyReplication recompare async

hgromer commented on code in PR #5051: URL: https://github.com/apache/hbase/pull/5051#discussion_r1164210517 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplicationRecompareRunnable.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apach

[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1505362090 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

[GitHub] [hbase] Apache9 commented on a diff in pull request #5168: HBASE-27785 Encapsulate and centralize totalBufferUsed in Replication…

Apache9 commented on code in PR #5168: URL: https://github.com/apache/hbase/pull/5168#discussion_r1164170325 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java: ## @@ -1070,4 +1070,21 @@ MetricsReplicationGlobalSourceSour

[GitHub] [hbase] Apache9 commented on a diff in pull request #5165: HBASE-27727 Implement filesystem based Replication peer storage

Apache9 commented on code in PR #5165: URL: https://github.com/apache/hbase/pull/5165#discussion_r1164156948 ## hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerStorageType.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [hbase] Apache-HBase commented on pull request #5173: HBASE-27791 Upgrade vega and its related js libraries

Apache-HBase commented on PR #5173: URL: https://github.com/apache/hbase/pull/5173#issuecomment-1505303219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

[GitHub] [hbase] bsglz commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

bsglz commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1505279572 Added perf test class named PerfTestCellComparator. Below is once running result: