[GitHub] [hbase] Apache-HBase commented on pull request #5317: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5317: URL: https://github.com/apache/hbase/pull/5317#issuecomment-1631800813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5317: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5317: URL: https://github.com/apache/hbase/pull/5317#issuecomment-1631598709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker

[jira] [Commented] (HBASE-27657) Connection and Request Attributes

2023-07-11 Thread Ray Mattingly (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742194#comment-17742194 ] Ray Mattingly commented on HBASE-27657: --- Thanks for the feedback here, that's a fa

[jira] [Commented] (HBASE-27897) ConnectionImplementation#locateRegionInMeta should pause and retry when taking user region lock failed

2023-07-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742189#comment-17742189 ] Hudson commented on HBASE-27897: Results for branch branch-2.4 [build #586 on b

[GitHub] [hbase] Apache-HBase commented on pull request #5317: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5317: URL: https://github.com/apache/hbase/pull/5317#issuecomment-1631524831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5319: HBASE-27968 add JvmPauseMonitor in hbase-client

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5319: URL: https://github.com/apache/hbase/pull/5319#issuecomment-1631523809 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5319: HBASE-27968 add JvmPauseMonitor in hbase-client

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5319: URL: https://github.com/apache/hbase/pull/5319#issuecomment-1631506709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

[jira] [Created] (HBASE-27971) MetaRWQueueRpcExecutor should extend FastPathRWQueueRpcExecutor

2023-07-11 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-27971: - Summary: MetaRWQueueRpcExecutor should extend FastPathRWQueueRpcExecutor Key: HBASE-27971 URL: https://issues.apache.org/jira/browse/HBASE-27971 Project: HB

[GitHub] [hbase] Apache-HBase commented on pull request #5319: HBASE-27968 add JvmPauseMonitor in hbase-client

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5319: URL: https://github.com/apache/hbase/pull/5319#issuecomment-1631177273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5317: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5317: URL: https://github.com/apache/hbase/pull/5317#issuecomment-1631156214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5317: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5317: URL: https://github.com/apache/hbase/pull/5317#issuecomment-1630978862 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

[jira] [Commented] (HBASE-27657) Connection and Request Attributes

2023-07-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742037#comment-17742037 ] Duo Zhang commented on HBASE-27657: --- I still do not get the point here... If you want

[jira] [Created] (HBASE-27970) Make sync replication also work with FSHLog

2023-07-11 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27970: - Summary: Make sync replication also work with FSHLog Key: HBASE-27970 URL: https://issues.apache.org/jira/browse/HBASE-27970 Project: HBase Issue Type: Improvement

[jira] [Resolved] (HBASE-27897) ConnectionImplementation#locateRegionInMeta should pause and retry when taking user region lock failed

2023-07-11 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-27897. --- Resolution: Fixed Merted the addendum to branch-2.4. Thanks for the review, [~zhangduo]! >

[GitHub] [hbase] Apache9 commented on a diff in pull request #5317: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2023-07-11 Thread via GitHub
Apache9 commented on code in PR #5317: URL: https://github.com/apache/hbase/pull/5317#discussion_r1259767865 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -414,6 +485,23 @@ protected final int getPreallocatedEventCount() {

[jira] [Resolved] (HBASE-27969) TableReplicationQueueStorage.hasData does not work as expected

2023-07-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27969. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-3. Thanks [~heliangjun]

[GitHub] [hbase] Apache9 merged pull request #5321: HBASE-27969 TableReplicationQueueStorage.hasData does not work as exp…

2023-07-11 Thread via GitHub
Apache9 merged PR #5321: URL: https://github.com/apache/hbase/pull/5321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

[jira] [Resolved] (HBASE-27798) Client side should back off based on wait interval in RpcThrottlingException

2023-07-11 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-27798. --- Release Note: When throttling quotas are enabled, clients will now respect the wait

[GitHub] [hbase] bbeaudreault merged pull request #5320: [branch-2] HBASE-27798: Client side should back off based on wait interval in RpcThrottlingException

2023-07-11 Thread via GitHub
bbeaudreault merged PR #5320: URL: https://github.com/apache/hbase/pull/5320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

[GitHub] [hbase] Apache-HBase commented on pull request #5322: HBASE-27897 ConnectionImplementation#locateRegionInMeta should pause and retry when taking user region lock failed - addendum

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5322: URL: https://github.com/apache/hbase/pull/5322#issuecomment-1630725824 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5322: HBASE-27897 ConnectionImplementation#locateRegionInMeta should pause and retry when taking user region lock failed - addendum

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5322: URL: https://github.com/apache/hbase/pull/5322#issuecomment-1630708039 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5322: HBASE-27897 ConnectionImplementation#locateRegionInMeta should pause and retry when taking user region lock failed - addendum

2023-07-11 Thread via GitHub
Apache-HBase commented on PR #5322: URL: https://github.com/apache/hbase/pull/5322#issuecomment-1630704559 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

[jira] [Reopened] (HBASE-27897) ConnectionImplementation#locateRegionInMeta should pause and retry when taking user region lock failed

2023-07-11 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-27897: --- An incorrect cherry-pick to branch-2.4 causes test failures. > ConnectionImplementation#locateR

[GitHub] [hbase-filesystem] petersomogyi commented on a diff in pull request #40: HBASE-27884: Use log4j2 instead of log4j for logging.

2023-07-11 Thread via GitHub
petersomogyi commented on code in PR #40: URL: https://github.com/apache/hbase-filesystem/pull/40#discussion_r1259601448 ## hbase-oss/pom.xml: ## @@ -346,11 +370,35 @@ slf4j-log4j12 ${slf4j.version} test + Review Comment: Isn't `slf4j-log4j12` a lo

[GitHub] [hbase] bsglz commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-11 Thread via GitHub
bsglz commented on PR #5318: URL: https://github.com/apache/hbase/pull/5318#issuecomment-1630289365 > If this is a bug, I think we should try to fix the bug itself, instead of turning off a feature? Make sense. But i could't find another way to fix it except this one:HBASE-26987, any