[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1698540196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[jira] [Assigned] (HBASE-28046) Adding capability to move_servers_rsgroup for all servers without explicitly passing servers

2023-08-29 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain reassigned HBASE-28046: -- Assignee: Nikita Pande > Adding capability to move_servers_rsgroup for all servers without

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1698249538 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1698238786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1698046984 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1698053215 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Updated] (HBASE-27743) Enhancements for the persistent cache

2023-08-29 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27743: - Summary: Enhancements for the persistent cache (was: Update the list of

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1697976588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1697921325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1697924673 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[jira] [Comment Edited] (HBASE-28050) RSProcedureDispatcher to fail-fast for SaslException

2023-08-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760044#comment-17760044 ] Viraj Jasani edited comment on HBASE-28050 at 8/29/23 6:25 PM: --- The

[jira] [Comment Edited] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2023-08-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760052#comment-17760052 ] Viraj Jasani edited comment on HBASE-28048 at 8/29/23 6:24 PM: --- Let's

[jira] [Commented] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2023-08-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760052#comment-17760052 ] Viraj Jasani commented on HBASE-28048: -- Let's assume we are moving all regions from server A to

[jira] [Comment Edited] (HBASE-28050) RSProcedureDispatcher to fail-fast for SaslException

2023-08-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760044#comment-17760044 ] Viraj Jasani edited comment on HBASE-28050 at 8/29/23 5:21 PM: --- The

[jira] [Commented] (HBASE-28050) RSProcedureDispatcher to fail-fast for SaslException

2023-08-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760044#comment-17760044 ] Viraj Jasani commented on HBASE-28050: -- The changes are not complicated but this requires thorough

[jira] [Created] (HBASE-28050) RSProcedureDispatcher to fail-fast for SaslException

2023-08-29 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-28050: Summary: RSProcedureDispatcher to fail-fast for SaslException Key: HBASE-28050 URL: https://issues.apache.org/jira/browse/HBASE-28050 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1697784860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Updated] (HBASE-27966) HBase Master/RS JVM metrics populated incorrectly

2023-08-29 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27966: --- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Updated] (HBASE-27966) HBase Master/RS JVM metrics populated incorrectly

2023-08-29 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27966: --- Fix Version/s: 2.6.0 2.5.6 > HBase Master/RS JVM metrics populated incorrectly >

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1697564366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] anmolnar commented on pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

2023-08-29 Thread via GitHub
anmolnar commented on PR #5370: URL: https://github.com/apache/hbase/pull/5370#issuecomment-1697515119 @Apache9 ptal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1697452208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1697443109 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1697442069 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5260: HBASE-27766 Support steal job queue mode for read RPC queues of RWQue…

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5260: URL: https://github.com/apache/hbase/pull/5260#issuecomment-1697327847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5375: HBASE-28037 Replication stuck after switching to new WAL but the queue is empty

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5375: URL: https://github.com/apache/hbase/pull/5375#issuecomment-1697252537 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5375: HBASE-28037 Replication stuck after switching to new WAL but the queue is empty

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5375: URL: https://github.com/apache/hbase/pull/5375#issuecomment-1697251082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5370: URL: https://github.com/apache/hbase/pull/5370#issuecomment-1697248313 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5370: URL: https://github.com/apache/hbase/pull/5370#issuecomment-1697237522 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5370: URL: https://github.com/apache/hbase/pull/5370#issuecomment-1697235088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] Apache-HBase commented on pull request #5374: HBASE-28047 Deadlock when opening mob files

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5374: URL: https://github.com/apache/hbase/pull/5374#issuecomment-1697224668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache-HBase commented on pull request #5260: HBASE-27766 Support steal job queue mode for read RPC queues of RWQue…

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5260: URL: https://github.com/apache/hbase/pull/5260#issuecomment-1697215036 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[jira] [Resolved] (HBASE-27998) Enhance region metrics to include prefetch ratio for each region

2023-08-29 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-27998. -- Resolution: Done Merged into the feature branch. > Enhance region metrics to

[GitHub] [hbase] wchevreuil commented on pull request #5342: HBASE-27998 Enhance region metrics to include prefetch ratio for each…

2023-08-29 Thread via GitHub
wchevreuil commented on PR #5342: URL: https://github.com/apache/hbase/pull/5342#issuecomment-1697143016 The latest UT failures seem unrelated. I can't reproduce the spotless failures, so let's get this merged. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #5374: HBASE-28047 Deadlock when opening mob files

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5374: URL: https://github.com/apache/hbase/pull/5374#issuecomment-1697120465 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5375: HBASE-28037 Replication stuck after switching to new WAL but the queue is empty

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5375: URL: https://github.com/apache/hbase/pull/5375#issuecomment-1697014619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[jira] [Commented] (HBASE-28037) Replication stuck after switching to new WAL but the queue is empty

2023-08-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759861#comment-17759861 ] Xiaolin Ha commented on HBASE-28037: Seems brings by HBASE-25596, we should stop the source reader

[GitHub] [hbase] Apache-HBase commented on pull request #5260: HBASE-27766 Support steal job queue mode for read RPC queues of RWQue…

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5260: URL: https://github.com/apache/hbase/pull/5260#issuecomment-1696906377 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[jira] [Commented] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2023-08-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759850#comment-17759850 ] Duo Zhang commented on HBASE-28048: --- Aborting master does not help here, the new master will still try

[jira] [Commented] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2023-08-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759843#comment-17759843 ] Viraj Jasani commented on HBASE-28048: -- I agree, we already have such logic for 

[GitHub] [hbase] sunhelly commented on pull request #5260: HBASE-27766 Support steal job queue mode for read RPC queues of RWQue…

2023-08-29 Thread via GitHub
sunhelly commented on PR #5260: URL: https://github.com/apache/hbase/pull/5260#issuecomment-1696862050 > Do we have any perf numbers here? Yes, I will prepare performance data shortly. Thanks. @Apache9 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] sunhelly commented on a diff in pull request #5260: HBASE-27766 Support steal job queue mode for read RPC queues of RWQue…

2023-08-29 Thread via GitHub
sunhelly commented on code in PR #5260: URL: https://github.com/apache/hbase/pull/5260#discussion_r1308284609 ## hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/StealRpcJobQueue.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2023-08-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759836#comment-17759836 ] Duo Zhang commented on HBASE-28048: --- The key here is that, we are not safe to give up if we are not

[GitHub] [hbase] Apache-HBase commented on pull request #5374: HBASE-28047 Deadlock when opening mob files

2023-08-29 Thread via GitHub
Apache-HBase commented on PR #5374: URL: https://github.com/apache/hbase/pull/5374#issuecomment-1696839235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[jira] [Resolved] (HBASE-27073) TestReplicationValueCompressedWAL.testMultiplePuts is flaky

2023-08-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27073. --- Fix Version/s: (was: 2.6.0) (was: 2.5.6) (was:

[jira] [Commented] (HBASE-27073) TestReplicationValueCompressedWAL.testMultiplePuts is flaky

2023-08-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759834#comment-17759834 ] Duo Zhang commented on HBASE-27073: --- The flaky dashboard is OK now. Let me resolve. Thanks all for