[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5373: HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow

bbeaudreault commented on code in PR #5373: URL: https://github.com/apache/hbase/pull/5373#discussion_r1320637680 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java: ## @@ -486,44 +490,51 @@ public boolean shouldUseScanner(Scan scan, HStore

[GitHub] [hbase] Apache9 commented on pull request #5356: Hbase-28014: Transient underlying HDFS failure causes permanent replciation failure between 2 HBase Clusters

Apache9 commented on PR #5356: URL: https://github.com/apache/hbase/pull/5356#issuecomment-1712537097 Thanks for opening a PR. In HBase, we usually first open a PR against the master branch, and then cherry-pick to other branches. So please open a PR against master branch? Branch-2.0

[GitHub] [hbase] Apache9 commented on pull request #5358: Hbase-28030: Adding unit test for FileNotFoundException when split a wal in SplitLogWorker

Apache9 commented on PR #5358: URL: https://github.com/apache/hbase/pull/5358#issuecomment-1712536861 Thanks for opening a PR. In HBase, we usually first open a PR against the master branch, and then cherry-pick to other branches. So please open a PR against master branch? Or does thi

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1712535754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1712534039 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1712491370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1712485320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1712484674 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1712444563 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke