Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on code in PR #5502: URL: https://github.com/apache/hbase/pull/5502#discussion_r1382350515 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java: ## @@ -133,7 +137,13 @@ protected Flow executeFromState(final MasterProc

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r138235 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final String humanR

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793397029 ··· 2023-11-03T19:10:49,850 INFO [RS_OPEN_REGION-regionserver/021d69fb7740:0-0 {event_type=M_RS_OPEN_REGION, pid=905}] regionserver.HRegionServer(2186): Post open deploy tasks for Test

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793397862 Ah the log is too big so it has been truncated... Let me see if I can reproduce the problem locally... -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793413736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793415768 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
chaijunjie0101 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r1382380098 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final String

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793429551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793430561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793431347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793436111 OK, we can see that ``` 2023-11-03T19:10:25,517 DEBUG [RegionServerTracker-0 {}] procedure2.ProcedureExecutor(1032): Stored pid=675, state=RUNNABLE:SERVER_CRASH_START, hasLock=fal

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793444763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
shahrs87 commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793489303 Thank you @Apache9 for your feedback and your requested comments are very detailed. Made the changes. Can you please review again? Thank you ! -- This is an automated message from the A

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793495071 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793497213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793497710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

[jira] [Commented] (HBASE-24179) Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x

2023-11-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782922#comment-17782922 ] Hudson commented on HBASE-24179: Results for branch branch-2.5 [build #429 on b

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793549379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docke

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793549851 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

[jira] [Created] (HBASE-28187) NPE when flush a non-existing column family

2023-11-04 Thread Ke Han (Jira)
Ke Han created HBASE-28187: -- Summary: NPE when flush a non-existing column family Key: HBASE-28187 URL: https://issues.apache.org/jira/browse/HBASE-28187 Project: HBase Issue Type: Bug R

[jira] [Updated] (HBASE-28187) NPE when flushing a non-existing column family

2023-11-04 Thread Ke Han (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated HBASE-28187: --- Summary: NPE when flushing a non-existing column family (was: NPE when flush a non-existing column family)

[jira] [Updated] (HBASE-28187) NPE when flushing a non-existing column family

2023-11-04 Thread Ke Han (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated HBASE-28187: --- Description: Flush a columnfamily that doesn't exist in the table will cause NPE ERROR in both shell and th

[jira] [Updated] (HBASE-28187) NPE when flushing a non-existing column family

2023-11-04 Thread Ke Han (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated HBASE-28187: --- Description: Flush a columnfamily that doesn't exist in the table will cause NPE ERROR in both shell and th

[jira] [Commented] (HBASE-24179) Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x

2023-11-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782944#comment-17782944 ] Hudson commented on HBASE-24179: Results for branch branch-2.4 [build #646 on b