Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1794182480 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 11s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1794181007 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5504: URL: https://github.com/apache/hbase/pull/5504#issuecomment-1794140066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5504: URL: https://github.com/apache/hbase/pull/5504#issuecomment-1794126435 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5505: URL: https://github.com/apache/hbase/pull/5505#issuecomment-1794119741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5505: URL: https://github.com/apache/hbase/pull/5505#issuecomment-1794118954 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[jira] [Commented] (HBASE-28174) DELETE endpoint in REST API does not support deleting binary row keys/columns

2023-11-05 Thread James Udiljak (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783094#comment-17783094 ] James Udiljak commented on HBASE-28174: --- I have submitted a draft PR:

Re: [PR] HBASE-28174 [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5501: URL: https://github.com/apache/hbase/pull/5501#issuecomment-1794114939 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28174 [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5501: URL: https://github.com/apache/hbase/pull/5501#issuecomment-1794112547 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 5s |

Re: [PR] HBASE-28174 [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5501: URL: https://github.com/apache/hbase/pull/5501#issuecomment-1794112162 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[jira] [Created] (HBASE-28188) Narrow the netty3 dependency scope

2023-11-05 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28188: - Summary: Narrow the netty3 dependency scope Key: HBASE-28188 URL: https://issues.apache.org/jira/browse/HBASE-28188 Project: HBase Issue Type: Task

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1794029877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
virajjasani commented on code in PR #5503: URL: https://github.com/apache/hbase/pull/5503#discussion_r1382734340 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java: ## @@ -470,7 +470,27 @@ private Pair

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache9 commented on code in PR #5505: URL: https://github.com/apache/hbase/pull/5505#discussion_r1382731051 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java: ## @@ -258,7 +258,26 @@ private void dequeueCurrentLog() throws

Re: [PR] HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms. [hbase]

2023-11-05 Thread via GitHub
virajjasani commented on code in PR #2924: URL: https://github.com/apache/hbase/pull/2924#discussion_r1382730988 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java: ## @@ -104,6 +108,55 @@ protected void

[jira] [Comment Edited] (HBASE-28174) DELETE endpoint in REST API does not support deleting binary row keys/columns

2023-11-05 Thread James Udiljak (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783073#comment-17783073 ] James Udiljak edited comment on HBASE-28174 at 11/6/23 2:37 AM: It seems

[jira] [Commented] (HBASE-28174) DELETE endpoint in REST API does not support deleting binary row keys/columns

2023-11-05 Thread James Udiljak (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783073#comment-17783073 ] James Udiljak commented on HBASE-28174: --- It seems the issue was that I was building the project on

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-11-05 Thread via GitHub
virajjasani commented on code in PR #5481: URL: https://github.com/apache/hbase/pull/5481#discussion_r1382729277 ## hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/RpcLogDetails.java: ## @@ -60,6 +64,18 @@ public RpcLogDetails(RpcCall rpcCall, Message param,

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
Apache9 merged PR #5494: URL: https://github.com/apache/hbase/pull/5494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5504: URL: https://github.com/apache/hbase/pull/5504#issuecomment-1793983646 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 29s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5505: URL: https://github.com/apache/hbase/pull/5505#issuecomment-1793979472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

[PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
shahrs87 opened a new pull request, #5505: URL: https://github.com/apache/hbase/pull/5505 master branch PR: https://github.com/apache/hbase/pull/5503 branch-2 PR: https://github.com/apache/hbase/pull/5504 branc -- This is an automated message from the Apache Git Service. To respond

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
shahrs87 commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793946159 PR for branch-2: https://github.com/apache/hbase/pull/5504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
shahrs87 opened a new pull request, #5504: URL: https://github.com/apache/hbase/pull/5504 PR for master branch: https://github.com/apache/hbase/pull/5503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
chaijunjie0101 commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793942515 > Please fix the checkstyle issue? The line is too long? you are right. pushed it again and passed -- This is an automated message from the Apache Git Service. To respond

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
chaijunjie0101 commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793942020 > Please fix the checkstyle issue? The line is too long? you are right.pushed it again and passed -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache9 commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793925161 The code is bit different on branch-2.5 and branch-2.4, please open a separated PR for against branch-2.5? Thanks. -- This is an automated message from the Apache Git Service. To

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793910593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793908482 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 11s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793847279 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 1s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793813887 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 9s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793811867 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 58s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793811093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[jira] [Updated] (HBASE-28187) NPE when flushing a non-existing column family

2023-11-05 Thread Ke Han (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated HBASE-28187: --- Description: Flush a columnfamily that doesn't exist in the table will cause NPE ERROR in both shell and

[jira] [Updated] (HBASE-28187) NPE when flushing a non-existing column family

2023-11-05 Thread Ke Han (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated HBASE-28187: --- Affects Version/s: 2.5.5 2.4.17 > NPE when flushing a non-existing column family >

[jira] [Updated] (HBASE-28187) NPE when flushing a non-existing column family

2023-11-05 Thread Ke Han (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated HBASE-28187: --- Description: Flush a columnfamily that doesn't exist in the table will cause NPE ERROR in both shell and

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-05 Thread via GitHub
Apache9 commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793690523 Please fix the checkstyle issue? The line is too long? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL