Re: [PR] HBASE-28199 Phase I: Suspend TRSP and SCP when updating meta [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5520: URL: https://github.com/apache/hbase/pull/5520#issuecomment-189011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-28199 Phase I: Suspend TRSP and SCP when updating meta [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5520: URL: https://github.com/apache/hbase/pull/5520#issuecomment-1822215552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 10s | Docke

[jira] [Commented] (HBASE-28210) There could be holes in stack ids when loading procedures

2023-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788628#comment-17788628 ] Hudson commented on HBASE-28210: Results for branch branch-2 [build #929 on bui

[jira] [Commented] (HBASE-28210) There could be holes in stack ids when loading procedures

2023-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788614#comment-17788614 ] Hudson commented on HBASE-28210: Results for branch branch-2.4 [build #654 on b

Re: [PR] HBASE-28199 Phase I: Suspend TRSP and SCP when updating meta [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5520: URL: https://github.com/apache/hbase/pull/5520#issuecomment-1822034289 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

[jira] [Resolved] (HBASE-28210) There could be holes in stack ids when loading procedures

2023-11-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28210. --- Resolution: Fixed > There could be holes in stack ids when loading procedures >

Re: [PR] HBASE-28210 Addendum fix TestProcedureAdmin [hbase]

2023-11-21 Thread via GitHub
Apache9 merged PR #5532: URL: https://github.com/apache/hbase/pull/5532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821712463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821687097 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-11-21 Thread via GitHub
taklwu commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1821582805 https://issues.apache.org/jira/browse/HBASE-28031 is looking at the `TestClusterScopeQuotaThrottle` failure @jojochuang can you have another look ? -- This is an automated message from

[jira] [Commented] (HBASE-21785) master reports open regions as RITs and also messes up rit age metric

2023-11-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788526#comment-17788526 ] Viraj Jasani commented on HBASE-21785: -- Agree, this deserves to be rolled out with

[jira] [Commented] (HBASE-21785) master reports open regions as RITs and also messes up rit age metric

2023-11-21 Thread David Manning (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788523#comment-17788523 ] David Manning commented on HBASE-21785: --- [~sershe] This says fixed in 2.2.0, but I

Re: [PR] HBASE-28210 Addendum fix TestProcedureAdmin [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5532: URL: https://github.com/apache/hbase/pull/5532#issuecomment-1821554311 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 23s | Docke

Re: [PR] HBASE-28210 Addendum fix TestProcedureAdmin [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5532: URL: https://github.com/apache/hbase/pull/5532#issuecomment-1821549535 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s | Docke

[jira] [Commented] (HBASE-28210) There could be holes in stack ids when loading procedures

2023-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788516#comment-17788516 ] Hudson commented on HBASE-28210: Results for branch branch-3 [build #88 on buil

[jira] [Commented] (HBASE-28210) There could be holes in stack ids when loading procedures

2023-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788507#comment-17788507 ] Hudson commented on HBASE-28210: Results for branch master [build #949 on build

[jira] [Commented] (HBASE-28210) There could be holes in stack ids when loading procedures

2023-11-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788506#comment-17788506 ] Hudson commented on HBASE-28210: Results for branch branch-2.5 [build #438 on b

Re: [PR] HBASE-28186 Rebase CacheAwareBalance related commits into master branch [hbase]

2023-11-21 Thread via GitHub
taklwu merged PR #5527: URL: https://github.com/apache/hbase/pull/5527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.o

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821382224 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
wchevreuil commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821288528 > To be honest I can not fully understand why the description on jira will lead to code change in this PR... Especially you mentioned we may still fail to cache the entry so the entry in

Re: [PR] HBASE-28210 Addendum fix TestProcedureAdmin [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5532: URL: https://github.com/apache/hbase/pull/5532#issuecomment-1821210319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821154169 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821147797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
Apache9 commented on code in PR #5530: URL: https://github.com/apache/hbase/pull/5530#discussion_r1400744146 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -221,13 +221,14 @@ public class BucketCache implements BlockCache, HeapSize

[PR] HBASE-28210 Addendum fix TestProcedureAdmin [hbase]

2023-11-21 Thread via GitHub
Apache9 opened a new pull request, #5532: URL: https://github.com/apache/hbase/pull/5532 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[jira] [Reopened] (HBASE-28210) There could be holes in stack ids when loading procedures

2023-11-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-28210: --- TestProcedureAdmin is failing. Let me think how to fix the test. > There could be holes in stack ids w

Re: [PR] Minor improvements to the README of hbck2 [hbase-operator-tools]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #138: URL: https://github.com/apache/hbase-operator-tools/pull/138#issuecomment-1821051673 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0

Re: [PR] Minor improvements to the README of hbck2 [hbase-operator-tools]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #138: URL: https://github.com/apache/hbase-operator-tools/pull/138#issuecomment-1821025731 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1

Re: [PR] Minor improvements to the README of hbck2 [hbase-operator-tools]

2023-11-21 Thread via GitHub
lfrancke commented on code in PR #138: URL: https://github.com/apache/hbase-operator-tools/pull/138#discussion_r1400653190 ## hbase-hbck2/README.md: ## @@ -22,17 +22,15 @@ _HBCK2_ is the repair tool for Apache HBase clusters. Problems in operation are bugs. The need for an _

Re: [PR] HBASE-28199 Phase I: Suspend TRSP and SCP when updating meta [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5520: URL: https://github.com/apache/hbase/pull/5520#issuecomment-1820900910 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker

Re: [PR] HBASE-28199 Phase I: Suspend TRSP and SCP when updating meta [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5520: URL: https://github.com/apache/hbase/pull/5520#issuecomment-1820827010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1820786996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28199 Phase I: Suspend TRSP and SCP when updating meta [hbase]

2023-11-21 Thread via GitHub
Apache-HBase commented on PR #5520: URL: https://github.com/apache/hbase/pull/5520#issuecomment-1820483864 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

Re: [PR] HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline [hbase]

2023-11-21 Thread via GitHub
lfrancke commented on PR #5515: URL: https://github.com/apache/hbase/pull/5515#issuecomment-1820469675 Ah! Yes, sorry. We have a [patch](https://github.com/stackabletech/docker-images/blob/main/hbase/stackable/patches/2.4.12/004-HBASE-25336-2.4.12.patch) for that as well and can put

Re: [PR] HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline [hbase]

2023-11-21 Thread via GitHub
Apache9 commented on PR #5515: URL: https://github.com/apache/hbase/pull/5515#issuecomment-1820454903 See HBASE-25335. I think at least we should also backport HBASE-25336? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline [hbase]

2023-11-21 Thread via GitHub
lfrancke commented on PR #5515: URL: https://github.com/apache/hbase/pull/5515#issuecomment-1820449836 Yep, we find that without it, running 2.4.x on Kubernetes is very unstable across restarts because of DNS issues. We're also happy to just maintain the patch on our end for the rest