Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1837394688 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5507: URL: https://github.com/apache/hbase/pull/5507#issuecomment-1837393085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 49s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1837391480 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-02 Thread via GitHub
zhuyaogai commented on code in PR #5507: URL: https://github.com/apache/hbase/pull/5507#discussion_r1413012164 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.java: ## @@ -51,6 +60,56 @@ public static void setUpBeforeClass() throws

[jira] [Commented] (HBASE-25549) Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms.

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792477#comment-17792477 ] Hudson commented on HBASE-25549: Results for branch branch-2.6 [build #5 on

[jira] [Commented] (HBASE-28212) Do not need to maintain rollback step when root procedure does not support rollback

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792478#comment-17792478 ] Hudson commented on HBASE-28212: Results for branch branch-2.6 [build #5 on

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1837334676 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1837319685 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1837317526 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 20s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1837280134 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1412892101 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java: ## @@ -135,11 +136,17 @@ public static List

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2023-12-02 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1412892078 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DualFileStoreEngine.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (HBASE-25549) Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms.

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792441#comment-17792441 ] Hudson commented on HBASE-25549: Results for branch branch-2.5 [build #444 on

[jira] [Commented] (HBASE-28212) Do not need to maintain rollback step when root procedure does not support rollback

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792440#comment-17792440 ] Hudson commented on HBASE-28212: Results for branch branch-2.5 [build #444 on

[jira] [Commented] (HBASE-25549) Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms.

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792432#comment-17792432 ] Hudson commented on HBASE-25549: Results for branch branch-3 [build #95 on

[jira] [Commented] (HBASE-28222) Leak in ExportSnapshot during verifySnapshot on S3A

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792430#comment-17792430 ] Hudson commented on HBASE-28222: Results for branch branch-3 [build #95 on

[jira] [Commented] (HBASE-28212) Do not need to maintain rollback step when root procedure does not support rollback

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792431#comment-17792431 ] Hudson commented on HBASE-28212: Results for branch branch-3 [build #95 on

[jira] [Commented] (HBASE-28222) Leak in ExportSnapshot during verifySnapshot on S3A

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792427#comment-17792427 ] Hudson commented on HBASE-28222: Results for branch master [build #956 on

[jira] [Commented] (HBASE-28212) Do not need to maintain rollback step when root procedure does not support rollback

2023-12-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792428#comment-17792428 ] Hudson commented on HBASE-28212: Results for branch master [build #956 on

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1837240362 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1837232947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 10s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-12-02 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1837186264 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 14s |

Re: [PR] HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. [hbase]

2023-12-02 Thread via GitHub
Apache9 commented on code in PR #5507: URL: https://github.com/apache/hbase/pull/5507#discussion_r1412810438 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.java: ## @@ -51,6 +60,56 @@ public static void setUpBeforeClass() throws

Re: [PR] HBASE-28187 NPE when flushing a non-existing column family [hbase]

2023-12-02 Thread via GitHub
Apache9 commented on PR #5553: URL: https://github.com/apache/hbase/pull/5553#issuecomment-1837146983 Looking at the jira description, I think we should add the check at master side? We should reject the request at very beginning. -- This is an automated message from the Apache Git

[jira] [Resolved] (HBASE-28212) Do not need to maintain rollback step when root procedure does not support rollback

2023-12-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28212. --- Resolution: Fixed Pushed the addendum to branch-2.6. > Do not need to maintain rollback step when

Re: [PR] HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure [hbase]

2023-12-02 Thread via GitHub
Apache9 commented on code in PR #5548: URL: https://github.com/apache/hbase/pull/5548#discussion_r1412795917 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/FlushRegionProcedure.java: ## @@ -88,6 +88,12 @@ protected Procedure[] execute(MasterProcedureEnv

[jira] [Reopened] (HBASE-28212) Do not need to maintain rollback step when root procedure does not support rollback

2023-12-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-28212: --- Seems I missed branch-2.6 > Do not need to maintain rollback step when root procedure does not support

[jira] [Resolved] (HBASE-28212) Do not need to maintain rollback step when root procedure does not support rollback

2023-12-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28212. --- Resolution: Fixed > Do not need to maintain rollback step when root procedure does not support >