stoty commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590543304
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java:
##
@@ -58,10 +61,11 @@
*
*/
@XmlRootElement(name = "Cell")
-@XmlAccessorType(XmlAccessT
[
https://issues.apache.org/jira/browse/HBASE-28563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843627#comment-17843627
]
Istvan Toth commented on HBASE-28563:
-
Background:
The daemon bug is fixed in ZK 3.9
stoty commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590543304
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java:
##
@@ -58,10 +61,11 @@
*
*/
@XmlRootElement(name = "Cell")
-@XmlAccessorType(XmlAccessT
stoty commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590542362
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ProtobufStreamingOutput.java:
##
@@ -91,15 +89,18 @@ private void writeToStream(CellSetModel model, String
content
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095197152
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s | Docke
Apache-HBase commented on PR #5875:
URL: https://github.com/apache/hbase/pull/5875#issuecomment-2095195742
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 27s | Docke
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095193271
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docke
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095174322
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s | Docke
[
https://issues.apache.org/jira/browse/HBASE-28566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28566:
---
Labels: pull-request-available (was: )
> Remove ZKDataMigrator
> -
>
>
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095119600
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docke
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095119436
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docke
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095118959
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s | Docke
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095118598
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docke
vincentpoon commented on code in PR #5874:
URL: https://github.com/apache/hbase/pull/5874#discussion_r1590489672
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java:
##
@@ -460,6 +460,9 @@ public List getMetaReplicaNodes() throws
KeeperException {
vincentpoon commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095102342
Let me attempt to summarize the cases:
- `/hbase/meta-region-server` exists - node is returned all the way ZKUtil
-> ZKWatcher -> MetaRegionLocationCache
- `/hbase` exists but
Apache9 commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095097362
> I am in favor of keeping patch like this, so that we don't have to keep
calling listChildren until `/hbase/meta-region-server` gets created. I know you
have valid concern about not re-thr
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095090843
I am in favor of keeping patch like this, so that we don't have to keep
calling listChildren until `/hbase/meta-region-server` gets created. I know you
have valid concern about not re-t
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095081066
Btw just in case if we end up updating
`MetaRegionLocationCache#loadMetaLocationsFromZk`, we might have to keep
`retryCounter.sleepUntilNextRetry()` out of catching KeeperException.
-
vincentpoon commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095068099
> It is just a bit strange that in ZKUtil we eat the NoNodeException while
at the upper layer we create a new NoNodeException and throw it...
I think the original author of `getMe
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095061777
Oh, I see you are talking about breaking this loop:
```
try {
znodes = watcher.getMetaReplicaNodesAndWatchChildren();
break;
} catch (Ke
Apache9 commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590472140
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableScanResource.java:
##
@@ -87,12 +85,12 @@ public RowModel next() {
if ((rs == null) || (count <
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095055933
> Better just return null in ZKWatcher, and in MetaRegionLocationCache, we
do not break the loop if the return value is null.
We need to retry in this case, that's the main differ
Apache9 commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095053926
> Sure but right now the problem is `ZKWatcher#filterMetaReplicaNodes`
returns empty List if the input nodes is null. So `MetaRegionLocationCache`
can't tell the difference between:
>
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095050613
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s | Docke
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095050352
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docke
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095049657
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docke
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095049227
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s | Docke
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095045853
I agree, we will need to change ZKWatcher one way or another, and currently
this is the only caller
--
This is an automated message from the Apache Git Service.
To respond to the mess
vincentpoon commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095044667
Sure but right now the problem is `ZKWatcher#filterMetaReplicaNodes` returns
empty List if the input nodes is null. So `MetaRegionLocationCache` can't tell
the difference between:
-
Apache9 commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095042089
I think we should change the logic in MetaRegionLocationCache instead of in
ZKWatcher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095038518
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docke
[
https://issues.apache.org/jira/browse/HBASE-28567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28567:
---
Labels: pull-request-available (was: )
> Race condition causes MetaRegionLocationCache to n
vincentpoon opened a new pull request, #5874:
URL: https://github.com/apache/hbase/pull/5874
…t watcher to populate meta location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Vincent Poon created HBASE-28567:
Summary: Race condition causes MetaRegionLocationCache to never
set watcher to populate meta location
Key: HBASE-28567
URL: https://issues.apache.org/jira/browse/HBASE-28567
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094945213
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 36s | Docker
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094935716
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094928036
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docker
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094926368
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s | Docker
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094917136
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s | Docke
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094910461
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docker
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094908672
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s | Docker
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094903126
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s | Docker
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094892007
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094844472
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s | Docker
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094839432
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docke
Duo Zhang created HBASE-28566:
-
Summary: Remove ZKDataMigrator
Key: HBASE-28566
URL: https://issues.apache.org/jira/browse/HBASE-28566
Project: HBase
Issue Type: Sub-task
Components: Zo
[
https://issues.apache.org/jira/browse/HBASE-28566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-28566:
-
Assignee: Duo Zhang
> Remove ZKDataMigrator
> -
>
> Key: HB
[
https://issues.apache.org/jira/browse/HBASE-28479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-28479:
--
Status: Patch Available (was: Open)
> Change the deprecation cycle for HasMasterServices and HasRegio
[
https://issues.apache.org/jira/browse/HBASE-28480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-28480:
--
Status: Patch Available (was: Open)
> Remove deprecated methods in RegionCoprocessorHost for 3.0.0
>
[
https://issues.apache.org/jira/browse/HBASE-28479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-28479:
-
Assignee: Duo Zhang
> Change the deprecation cycle for HasMasterServices and HasRegionServerSer
[
https://issues.apache.org/jira/browse/HBASE-28480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28480:
---
Labels: pull-request-available (was: )
> Remove deprecated methods in RegionCoprocessorHost
Apache9 opened a new pull request, #5873:
URL: https://github.com/apache/hbase/pull/5873
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
Apache9 commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1590326516
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper 3.
[
https://issues.apache.org/jira/browse/HBASE-28479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28479:
---
Labels: pull-request-available (was: )
> Change the deprecation cycle for HasMasterServices
Apache9 opened a new pull request, #5872:
URL: https://github.com/apache/hbase/pull/5872
…sRegionServerServices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094817759
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s | Docke
[
https://issues.apache.org/jira/browse/HBASE-28565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843561#comment-17843561
]
Duo Zhang commented on HBASE-28565:
---
The map reduce job is also a pain here.
There ar
57 matches
Mail list logo
