Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
virajjasani commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111746391 Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be appli

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
Apache9 commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111748836 > Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be applicabl

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1601087841 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -48,17 +52,38 @@ class DefaultStoreFileManager implements StoreFile

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
virajjasani commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111800160 > > Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be app

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-15 Thread via GitHub
q977734161 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2111806293 > Ping @q977734161 ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-05-15 Thread via GitHub
Apache9 commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111814481 > > > Both approaches have their own drawbacks. I still wonder what we can do here for ConnectionRegistry timeouts, given that Zookeeper response might never come back for timer to be appli

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601142345 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo, C

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601144798 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo, C

[jira] [Work started] (HBASE-28463) Time Based Priority for BucketCache

2024-05-15 Thread Janardhan Hungund (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28463 started by Janardhan Hungund. - > Time Based Priority for BucketCache > -

[jira] [Commented] (HBASE-28436) Use connection url to specify the connection registry information

2024-05-15 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846560#comment-17846560 ] ruanhui commented on HBASE-28436: - I just have a idea that maybe we can set a shorter de

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
vinayakphegde commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601338343 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileIn

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo, C

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo, C

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo, C

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo, C

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
vinayakphegde commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601501477 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileIn

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
petersomogyi commented on code in PR #5881: URL: https://github.com/apache/hbase/pull/5881#discussion_r1601501495 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java: ## @@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster, HttpUriRequest me

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
stoty commented on code in PR #5881: URL: https://github.com/apache/hbase/pull/5881#discussion_r1601523125 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java: ## @@ -176,22 +229,56 @@ public Client(Cluster cluster, Configuration conf, boolean sslEnabled

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
stoty commented on code in PR #5881: URL: https://github.com/apache/hbase/pull/5881#discussion_r1601547952 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java: ## @@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster, HttpUriRequest method, H

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-15 Thread via GitHub
2005hithlj commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1601555207 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-15 Thread via GitHub
2005hithlj commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1601578510 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java: ## @@ -162,8 +162,8 @@ public void testSelectiveFlushWhenEnabled() th

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112448624 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s | Docke

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112451591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112452475 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112453219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

[jira] [Assigned] (HBASE-28471) Release 2.4.18

2024-05-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28471: - Assignee: Duo Zhang > Release 2.4.18 > -- > > Key: HBASE-28471 >

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
wchevreuil commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601716156 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

[jira] [Updated] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Csaba Ringhofer (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Ringhofer updated HBASE-28595: Summary: Losing exception from scan RPC can lead to partial results (was: Loosing excepti

[jira] [Created] (HBASE-28595) Loosing exception from scan RPC can lead to partial results

2024-05-15 Thread Csaba Ringhofer (Jira)
Csaba Ringhofer created HBASE-28595: --- Summary: Loosing exception from scan RPC can lead to partial results Key: HBASE-28595 URL: https://issues.apache.org/jira/browse/HBASE-28595 Project: HBase

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846649#comment-17846649 ] Duo Zhang commented on HBASE-28595: --- By design, if the server side has already closed

[jira] [Assigned] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil reassigned HBASE-28595: Assignee: Csaba Ringhofer > Losing exception from scan RPC can lead to pa

[jira] [Updated] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-28595: - Description: This was discovered in Apache Impala using HBase 2.2 based branch h

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846652#comment-17846652 ] Wellington Chevreuil commented on HBASE-28595: -- {quote} By design, if the s

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846653#comment-17846653 ] Wellington Chevreuil commented on HBASE-28595: -- Also, it seems we keep clos

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846656#comment-17846656 ] Duo Zhang commented on HBASE-28595: --- In HBASE-17489, for keeping compatiblity with 1.x

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846657#comment-17846657 ] Duo Zhang commented on HBASE-28595: --- {quote} Also, it seems we keep closed scanners fo

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-15 Thread via GitHub
ndimiduk merged PR #5871: URL: https://github.com/apache/hbase/pull/5871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

[jira] [Updated] (HBASE-28502) Backup manifest of full backup contains incomplete table list

2024-05-15 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28502: - Status: Patch Available (was: Open) > Backup manifest of full backup contains incomplete table

[jira] [Updated] (HBASE-28502) Backup manifest of full backup contains incomplete table list

2024-05-15 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28502: - Fix Version/s: 4.0.0-alpha-1 > Backup manifest of full backup contains incomplete table list > -

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-15 Thread via GitHub
ndimiduk commented on PR #5871: URL: https://github.com/apache/hbase/pull/5871#issuecomment-2112749361 Merged to master. I'll start backporting and holler if I have any issues. Thanks for the contribution @DieterDP-ng and for the review @rmdmattingly ! -- This is an automated message from

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Csaba Ringhofer (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846668#comment-17846668 ] Csaba Ringhofer commented on HBASE-28595: - Thanks [~zhangduo] for the quick resp

[PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
ndimiduk opened a new pull request, #5900: URL: https://github.com/apache/hbase/pull/5900 In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete

[PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
ndimiduk opened a new pull request, #5901: URL: https://github.com/apache/hbase/pull/5901 In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

2024-05-15 Thread via GitHub
jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1601814522 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo hFileInfo, C

[PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
ndimiduk opened a new pull request, #5902: URL: https://github.com/apache/hbase/pull/5902 In older versions of HBase's backup mechanism, a manifest was written per table being backed up. This was since refactored to one manifest per backup, but the manifest code was not updated. A concrete

[jira] [Updated] (HBASE-28502) Backup manifest of full backup contains incomplete table list

2024-05-15 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28502: - Fix Version/s: 2.7.0 3.0.0-beta-2 2.6.1

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846674#comment-17846674 ] Wellington Chevreuil commented on HBASE-28595: -- [~csringhofer] , it seems t

[jira] [Comment Edited] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Csaba Ringhofer (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846668#comment-17846668 ] Csaba Ringhofer edited comment on HBASE-28595 at 5/15/24 3:23 PM:

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112856270 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5901: URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112857551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112874843 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112876132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-3 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5900: URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112877030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5901: URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112891097 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docke

Re: [PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5902: URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112892247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

Re: [PR] Backport "HBASE-28502 Cleanup old backup manifest logic (#5871)" to branch-2 [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5901: URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112896360 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docke

[PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache9 opened a new pull request, #5903: URL: https://github.com/apache/hbase/pull/5903 … when closing unused region replicas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (HBASE-28582) ModifyTableProcedure should not reset TRSP on region node when closing unused region replicas

2024-05-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28582: --- Labels: pull-request-available (was: ) > ModifyTableProcedure should not reset TRSP on regi

[jira] [Commented] (HBASE-28592) Backport HBASE-26525 Use unique thread name for group WALs

2024-05-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846688#comment-17846688 ] Duo Zhang commented on HBASE-28592: --- So we missed the parent commit for branch-2? That

[jira] [Commented] (HBASE-28592) Backport HBASE-26525 Use unique thread name for group WALs

2024-05-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846690#comment-17846690 ] Duo Zhang commented on HBASE-28592: --- I think we should just reopen the parent issue an

Re: [PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5902: URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112905858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docke

Re: [PR] HBASE-28502 Cleanup old backup manifest logic (#5871) [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5902: URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112909831 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

[PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
csringhofer opened a new pull request, #5904: URL: https://github.com/apache/hbase/pull/5904 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Updated] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28595: --- Labels: pull-request-available (was: ) > Losing exception from scan RPC can lead to partial

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Csaba Ringhofer (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846696#comment-17846696 ] Csaba Ringhofer commented on HBASE-28595: - The related classes are already remov

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2112980831 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docke

[jira] [Updated] (HBASE-28467) Integration of time-based priority caching into write and read code paths.

2024-05-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28467: --- Labels: pull-request-available (was: ) > Integration of time-based priority caching into wr

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112982784 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112989343 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docke

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113000337 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docke

[jira] [Created] (HBASE-28596) Optimise BucketCache usage upon regions splits/merges.

2024-05-15 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-28596: Summary: Optimise BucketCache usage upon regions splits/merges. Key: HBASE-28596 URL: https://issues.apache.org/jira/browse/HBASE-28596 Project: HBase

[jira] [Updated] (HBASE-28596) Optimise BucketCache usage upon regions splits/merges.

2024-05-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28596: --- Labels: pull-request-available (was: ) > Optimise BucketCache usage upon regions splits/mer

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
wchevreuil commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1601975139 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113039642 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113044620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113047961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113050194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113063306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113070051 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113094212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113097479 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113102062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113103339 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-15 Thread via GitHub
virajjasani merged PR #5307: URL: https://github.com/apache/hbase/pull/5307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apa

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-15 Thread via GitHub
virajjasani merged PR #5899: URL: https://github.com/apache/hbase/pull/5899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apa

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113363345 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113365350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113412114 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846755#comment-17846755 ] Michael Smith commented on HBASE-28595: --- I have a setup that reproduces this issue

[jira] [Comment Edited] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846755#comment-17846755 ] Michael Smith edited comment on HBASE-28595 at 5/15/24 9:00 PM: --

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
DieterDP-ng commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113452806 @rmdmattingly rebased the PR after addressing the `getAncestors` concerns. The test failure in previous version is a flaky test, it also occurs in https://github.com/apache/hbase/pull/5

[jira] [Comment Edited] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846755#comment-17846755 ] Michael Smith edited comment on HBASE-28595 at 5/15/24 9:04 PM: --

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113491628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113495636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113496816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113502179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docke

[jira] [Resolved] (HBASE-27938) Enable PE to load any custom implementation of tests at runtime

2024-05-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27938. -- Fix Version/s: 2.7.0 3.0.0-beta-2 2.6.1

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846774#comment-17846774 ] Duo Zhang commented on HBASE-28595: --- [~MikaelSmith] Connection can be broken in any re

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2113930166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-15 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1602560727 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -48,17 +52,38 @@ class DefaultStoreFileManager implements StoreFi

  1   2   >