Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088475
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088119
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088089
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114087829
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846804#comment-17846804
]
Csaba Ringhofer commented on HBASE-28595:
-
About the test scenario:
I would separate closing the
Apache9 commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1602580409
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java:
##
@@ -50,15 +50,15 @@ public interface StoreFileManager {
*/
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846799#comment-17846799
]
Csaba Ringhofer commented on HBASE-28595:
-
>a simple fix would be that, only record a closed
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965661
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965652
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965649
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5545:
URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965547
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1602564157
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java:
##
@@ -50,15 +50,15 @@ public interface StoreFileManager {
*/
kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1602560727
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java:
##
@@ -48,17 +52,38 @@ class DefaultStoreFileManager implements
Apache-HBase commented on PR #5883:
URL: https://github.com/apache/hbase/pull/5883#issuecomment-2113930166
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846774#comment-17846774
]
Duo Zhang commented on HBASE-28595:
---
[~MikaelSmith] Connection can be broken in any reason, it is not
[
https://issues.apache.org/jira/browse/HBASE-27938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani resolved HBASE-27938.
--
Fix Version/s: 2.7.0
3.0.0-beta-2
2.6.1
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113502179
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113496816
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113495636
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113491628
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 5s |
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846755#comment-17846755
]
Michael Smith edited comment on HBASE-28595 at 5/15/24 9:04 PM:
I have a
DieterDP-ng commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113452806
@rmdmattingly rebased the PR after addressing the `getAncestors` concerns.
The test failure in previous version is a flaky test, it also occurs in
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846755#comment-17846755
]
Michael Smith edited comment on HBASE-28595 at 5/15/24 9:00 PM:
I have a
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846755#comment-17846755
]
Michael Smith commented on HBASE-28595:
---
I have a setup that reproduces this issue:
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113412114
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113365350
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2113363345
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
virajjasani merged PR #5899:
URL: https://github.com/apache/hbase/pull/5899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
virajjasani merged PR #5307:
URL: https://github.com/apache/hbase/pull/5307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113103339
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113102062
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113097479
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5906:
URL: https://github.com/apache/hbase/pull/5906#issuecomment-2113094212
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113070051
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113063306
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113050194
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5905:
URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113047961
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113044620
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113039642
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
wchevreuil commented on code in PR #5905:
URL: https://github.com/apache/hbase/pull/5905#discussion_r1601975139
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long
[
https://issues.apache.org/jira/browse/HBASE-28596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28596:
---
Labels: pull-request-available (was: )
> Optimise BucketCache usage upon regions
Wellington Chevreuil created HBASE-28596:
Summary: Optimise BucketCache usage upon regions splits/merges.
Key: HBASE-28596
URL: https://issues.apache.org/jira/browse/HBASE-28596
Project: HBase
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2113000337
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112989343
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5904:
URL: https://github.com/apache/hbase/pull/5904#issuecomment-2112982784
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
[
https://issues.apache.org/jira/browse/HBASE-28467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28467:
---
Labels: pull-request-available (was: )
> Integration of time-based priority caching into
Apache-HBase commented on PR #5903:
URL: https://github.com/apache/hbase/pull/5903#issuecomment-2112980831
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846696#comment-17846696
]
Csaba Ringhofer commented on HBASE-28595:
-
The related classes are already removed on master
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28595:
---
Labels: pull-request-available (was: )
> Losing exception from scan RPC can lead to
csringhofer opened a new pull request, #5904:
URL: https://github.com/apache/hbase/pull/5904
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Apache-HBase commented on PR #5902:
URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112909831
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5902:
URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112905858
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
[
https://issues.apache.org/jira/browse/HBASE-28592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846690#comment-17846690
]
Duo Zhang commented on HBASE-28592:
---
I think we should just reopen the parent issue and cherry-pick
[
https://issues.apache.org/jira/browse/HBASE-28592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846688#comment-17846688
]
Duo Zhang commented on HBASE-28592:
---
So we missed the parent commit for branch-2? That's bad.
>
[
https://issues.apache.org/jira/browse/HBASE-28582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28582:
---
Labels: pull-request-available (was: )
> ModifyTableProcedure should not reset TRSP on
Apache9 opened a new pull request, #5903:
URL: https://github.com/apache/hbase/pull/5903
… when closing unused region replicas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Apache-HBase commented on PR #5901:
URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112896360
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s |
Apache-HBase commented on PR #5902:
URL: https://github.com/apache/hbase/pull/5902#issuecomment-2112892247
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 50s |
Apache-HBase commented on PR #5901:
URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112891097
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112877030
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112876132
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112874843
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5901:
URL: https://github.com/apache/hbase/pull/5901#issuecomment-2112857551
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5900:
URL: https://github.com/apache/hbase/pull/5900#issuecomment-2112856270
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846668#comment-17846668
]
Csaba Ringhofer edited comment on HBASE-28595 at 5/15/24 3:23 PM:
--
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846674#comment-17846674
]
Wellington Chevreuil commented on HBASE-28595:
--
[~csringhofer] , it seems this still the
[
https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-28502:
-
Fix Version/s: 2.7.0
3.0.0-beta-2
2.6.1
ndimiduk opened a new pull request, #5902:
URL: https://github.com/apache/hbase/pull/5902
In older versions of HBase's backup mechanism, a manifest was written per
table being backed up. This was since refactored to one manifest per backup,
but the manifest code was not updated. A concrete
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601814522
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
ndimiduk opened a new pull request, #5901:
URL: https://github.com/apache/hbase/pull/5901
In older versions of HBase's backup mechanism, a manifest was written per
table being backed up. This was since refactored to one manifest per backup,
but the manifest code was not updated. A concrete
ndimiduk opened a new pull request, #5900:
URL: https://github.com/apache/hbase/pull/5900
In older versions of HBase's backup mechanism, a manifest was written per
table being backed up. This was since refactored to one manifest per backup,
but the manifest code was not updated. A concrete
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846668#comment-17846668
]
Csaba Ringhofer commented on HBASE-28595:
-
Thanks [~zhangduo] for the quick response!
Uploaded
ndimiduk commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2112749361
Merged to master. I'll start backporting and holler if I have any issues.
Thanks for the contribution @DieterDP-ng and for the review @rmdmattingly !
--
This is an automated message
[
https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-28502:
-
Status: Patch Available (was: Open)
> Backup manifest of full backup contains incomplete table
[
https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-28502:
-
Fix Version/s: 4.0.0-alpha-1
> Backup manifest of full backup contains incomplete table list
>
ndimiduk merged PR #5871:
URL: https://github.com/apache/hbase/pull/5871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846657#comment-17846657
]
Duo Zhang commented on HBASE-28595:
---
{quote}
Also, it seems we keep closed scanners for the time
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846656#comment-17846656
]
Duo Zhang commented on HBASE-28595:
---
In HBASE-17489, for keeping compatiblity with 1.x client, we
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846653#comment-17846653
]
Wellington Chevreuil commented on HBASE-28595:
--
Also, it seems we keep closed scanners for
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846652#comment-17846652
]
Wellington Chevreuil commented on HBASE-28595:
--
{quote}
By design, if the server side has
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-28595:
-
Description:
This was discovered in Apache Impala using HBase 2.2 based branch
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil reassigned HBASE-28595:
Assignee: Csaba Ringhofer
> Losing exception from scan RPC can lead to
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846649#comment-17846649
]
Duo Zhang commented on HBASE-28595:
---
By design, if the server side has already closed the scanner, the
Csaba Ringhofer created HBASE-28595:
---
Summary: Loosing exception from scan RPC can lead to partial
results
Key: HBASE-28595
URL: https://issues.apache.org/jira/browse/HBASE-28595
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Csaba Ringhofer updated HBASE-28595:
Summary: Losing exception from scan RPC can lead to partial results (was:
Loosing
wchevreuil commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601716156
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
[
https://issues.apache.org/jira/browse/HBASE-28471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-28471:
-
Assignee: Duo Zhang
> Release 2.4.18
> --
>
> Key: HBASE-28471
>
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112453219
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112452475
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112451591
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5881:
URL: https://github.com/apache/hbase/pull/5881#issuecomment-2112448624
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
2005hithlj commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1601578510
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java:
##
@@ -162,8 +162,8 @@ public void testSelectiveFlushWhenEnabled()
2005hithlj commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1601555207
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -686,12 +686,6 @@ public void abortCacheFlush(byte[]
stoty commented on code in PR #5881:
URL: https://github.com/apache/hbase/pull/5881#discussion_r1601547952
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java:
##
@@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster,
HttpUriRequest method,
stoty commented on code in PR #5881:
URL: https://github.com/apache/hbase/pull/5881#discussion_r1601523125
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java:
##
@@ -176,22 +229,56 @@ public Client(Cluster cluster, Configuration conf,
boolean
petersomogyi commented on code in PR #5881:
URL: https://github.com/apache/hbase/pull/5881#discussion_r1601501495
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java:
##
@@ -377,19 +476,59 @@ public HttpResponse execute(Cluster cluster,
HttpUriRequest
vinayakphegde commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601501477
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
jhungund commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1601360335
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -2203,6 +2204,21 @@ public Optional shouldCacheFile(HFileInfo
hFileInfo,
1 - 100 of 112 matches
Mail list logo
