Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-31 Thread via GitHub
NihalJain commented on PR #6127: URL: https://github.com/apache/hbase/pull/6127#issuecomment-2259884410 Hi just updating how I have been testing out this version bump. Following are the things i have tested: 1. HBase Shell sanity commands in a standalone on Mac and distributed cluste

[jira] [Commented] (HBASE-28250) Bump jruby to 9.4.8.0 to fix snakeyaml CVE

2024-07-31 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869838#comment-17869838 ] Nihal Jain commented on HBASE-28250: Posted on PR how have tested the changes: http

Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-31 Thread via GitHub
NihalJain commented on PR #6127: URL: https://github.com/apache/hbase/pull/6127#issuecomment-2259892942 > Please fix the whilespace issue and also open a PR against branch-2. Thank @Apache9 for the review, will fix whitespace. Which all branches should we target? Just branch-2 righ

Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-31 Thread via GitHub
ndimiduk commented on PR #6127: URL: https://github.com/apache/hbase/pull/6127#issuecomment-2260177337 Thanks for the thorough testing here. This looks very promising! Re: autocomplete and colors, can we disable them by default and document how to reenable them for the brave? -- Th

Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-31 Thread via GitHub
ndimiduk commented on PR #6127: URL: https://github.com/apache/hbase/pull/6127#issuecomment-2260179642 Should this PR also update all the internal rb scripts to use `java_import` as appropriate? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-31 Thread via GitHub
mnpoonia commented on PR #6129: URL: https://github.com/apache/hbase/pull/6129#issuecomment-2260181907 Had a offline discussion with @Umeshkumar9414 and this logic has a flaw. Instead of using master start code we should be using master active time for fencing otherwise we will end up in a

Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-31 Thread via GitHub
Apache9 commented on PR #6129: URL: https://github.com/apache/hbase/pull/6129#issuecomment-2260212672 > Had a offline discussion with @Umeshkumar9414 and this logic has a flaw. Instead of using master start code we should be using master active time for fencing otherwise we will end up in a

[jira] [Commented] (HBASE-28690) Aborting Active HMaster is not rejecting reportRegionStateTransition if procedure is initialised by next Active master

2024-07-31 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869873#comment-17869873 ] Aman Poonia commented on HBASE-28690: - {noformat} I was also curious apart from cl

Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-31 Thread via GitHub
mnpoonia commented on PR #6129: URL: https://github.com/apache/hbase/pull/6129#issuecomment-2260286887 @Apache9 - the problem with master start code is that if we are running 5 masters and one of the master which have highest start code creates the procedure and aborts. Now since all other

Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-31 Thread via GitHub
2005hithlj commented on code in PR #6131: URL: https://github.com/apache/hbase/pull/6131#discussion_r1698423825 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreDriver.java: ## @@ -124,8 +124,8 @@ private int parseAndRun() throws IOException { if (cmd.h

Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-31 Thread via GitHub
2005hithlj commented on code in PR #6131: URL: https://github.com/apache/hbase/pull/6131#discussion_r1698430916 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java: ## @@ -142,6 +142,12 @@ public void execute() throws IOException { thro

[jira] [Commented] (HBASE-27901) [Close-WAL-Writer-178] wal.AsyncFSWAL: close old writer failed

2024-07-31 Thread SunQiang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869889#comment-17869889 ] SunQiang commented on HBASE-27901: -- in hbase-site.xml you can add a parameter :     

[jira] [Commented] (HBASE-27886) wal.AbstractProtobufLogWriter: Failed to write trailer, non-fatal, continuing

2024-07-31 Thread SunQiang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869891#comment-17869891 ] SunQiang commented on HBASE-27886: -- What happened to the HBase system that caused this

Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-31 Thread via GitHub
NihalJain commented on PR #6127: URL: https://github.com/apache/hbase/pull/6127#issuecomment-2260461031 Hi Nick thanks for taking time to review this PR. > Re: autocomplete and colors, can we disable them by default and document how to reenable them for the brave? I can thi

Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-31 Thread via GitHub
NihalJain commented on code in PR #6131: URL: https://github.com/apache/hbase/pull/6131#discussion_r1698469419 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java: ## @@ -142,6 +142,12 @@ public void execute() throws IOException { throw

Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-31 Thread via GitHub
Apache9 commented on PR #6129: URL: https://github.com/apache/hbase/pull/6129#issuecomment-2260471977 > @Apache9 - the problem with master start code is that if we are running 5 masters and one of the master which have highest start code creates the procedure and aborts. Now since all other

Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-31 Thread via GitHub
2005hithlj commented on PR #6131: URL: https://github.com/apache/hbase/pull/6131#issuecomment-2260493359 @NihalJain Thanks for your review. @DieterDP-ng has verified "Setting the queue through the configuration does work.", and the changes here is also simple and clear. Besides, the UT for

Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-31 Thread via GitHub
2005hithlj merged PR #6131: URL: https://github.com/apache/hbase/pull/6131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apac

[jira] [Commented] (HBASE-28587) Remove deprecated methods in Cell

2024-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870015#comment-17870015 ] Hudson commented on HBASE-28587: Results for branch branch-3 [build #264 on bui

[jira] [Commented] (HBASE-28729) Change the generic type of List in InternalScanner.next

2024-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870016#comment-17870016 ] Hudson commented on HBASE-28729: Results for branch branch-3 [build #264 on bui

[jira] [Commented] (HBASE-28587) Remove deprecated methods in Cell

2024-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870020#comment-17870020 ] Hudson commented on HBASE-28587: Results for branch master [build #1135 on buil

[jira] [Commented] (HBASE-28729) Change the generic type of List in InternalScanner.next

2024-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870021#comment-17870021 ] Hudson commented on HBASE-28729: Results for branch master [build #1135 on buil

Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-31 Thread via GitHub
Umeshkumar9414 commented on code in PR #6129: URL: https://github.com/apache/hbase/pull/6129#discussion_r1698997639 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java: ## @@ -2567,6 +2573,17 @@ public ReportProcedureDoneResponse reportProcedureD

Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-31 Thread via GitHub
Umeshkumar9414 commented on code in PR #6129: URL: https://github.com/apache/hbase/pull/6129#discussion_r1698998000 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java: ## @@ -2254,7 +2255,7 @@ public void postOpenDeployTasks(final PostOpenDepl

Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-31 Thread via GitHub
Umeshkumar9414 commented on PR #6129: URL: https://github.com/apache/hbase/pull/6129#issuecomment-2261265069 Yeah, I will change this to use masterActiveTime -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (HBASE-28389) HBase backup yarn queue parameter ignored

2024-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870083#comment-17870083 ] Hudson commented on HBASE-28389: Results for branch branch-2.6 [build #179 on b

[jira] [Resolved] (HBASE-28389) HBase backup yarn queue parameter ignored

2024-07-31 Thread Liangjun He (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liangjun He resolved HBASE-28389. - Fix Version/s: 2.7.0 3.0.0-beta-2 2.6.1 Resolution:

[jira] [Commented] (HBASE-28389) HBase backup yarn queue parameter ignored

2024-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870105#comment-17870105 ] Hudson commented on HBASE-28389: Results for branch branch-2 [build #1120 on bu