[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223675#comment-16223675 ] Anoop Sam John commented on HBASE-19047: Pushed to branch-2+ . Thanks for the reviews and

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Resolution: Fixed Hadoop Flags: Incompatible change,Reviewed (was: Incompatible

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223376#comment-16223376 ] Anoop Sam John commented on HBASE-19052: This comparator name change is the only thing we did as

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Attachment: HBASE-19047_V5.patch > CP exposed Scanner types should not extend Shipper >

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222728#comment-16222728 ] Anoop Sam John commented on HBASE-19047: Sorry Stack for not making it clear. I was saying abt

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222682#comment-16222682 ] Anoop Sam John commented on HBASE-19052: bq.What happens if trailer has

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222672#comment-16222672 ] Anoop Sam John commented on HBASE-19092: I dont think this patch is complete. Also we need a LP

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221804#comment-16221804 ] Anoop Sam John commented on HBASE-18995: Can u try with name as HBASE-18995_002-branch-2.patch ?

[jira] [Commented] (HBASE-19035) Miss metrics when coprocessor use region scanner to read data

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221801#comment-16221801 ] Anoop Sam John commented on HBASE-19035: +1. Lets unify it where the metrics are updated. For

[jira] [Updated] (HBASE-19035) Miss metrics when coprocessor use region scanner to read data

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19035: --- Fix Version/s: 2.0.0-beta-1 > Miss metrics when coprocessor use region scanner to read data

[jira] [Updated] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18906: --- Resolution: Fixed Hadoop Flags: Reviewed Release Note: Provided an API in Region

[jira] [Updated] (HBASE-13346) Clean up Filter package for post 1.0 s/KeyValue/Cell/g

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-13346: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch

[jira] [Commented] (HBASE-13346) Clean up Filter package for post 1.0 s/KeyValue/Cell/g

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221738#comment-16221738 ] Anoop Sam John commented on HBASE-13346: +1. QA seems fine. > Clean up Filter package for post

[jira] [Commented] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221721#comment-16221721 ] Anoop Sam John commented on HBASE-18906:

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221572#comment-16221572 ] Anoop Sam John commented on HBASE-19047: bq.Are we trying to hide Shipper functionality from CPs?

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221564#comment-16221564 ] Anoop Sam John commented on HBASE-19092: Tag was just a class in 0.98 and even in 1.x also I

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Attachment: HBASE-19047_V4.patch > CP exposed Scanner types should not extend Shipper >

[jira] [Commented] (HBASE-19033) Allow CP users to change versions and TTL before opening StoreScanner

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220813#comment-16220813 ] Anoop Sam John commented on HBASE-19033: ScanOptions -> I was thinking why to have this extra

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Attachment: HBASE-19047_V4.patch I thought of changing this way but then just forgot.

[jira] [Commented] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220720#comment-16220720 ] Anoop Sam John commented on HBASE-18906: Will restore javadoc on commit. Waiting for QA. Whats

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220315#comment-16220315 ] Anoop Sam John commented on HBASE-19092: Only Tag interface has to be exposed not the impl

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Attachment: HBASE-19047_V3.patch As per comments from Duo > CP exposed Scanner types should

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220292#comment-16220292 ] Anoop Sam John commented on HBASE-19047: Ya on the returned scanner if that is Shipper instance,

[jira] [Updated] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18906: --- Attachment: HBASE-18906_V2.patch > Provide Region#waitForFlushes API >

[jira] [Commented] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220100#comment-16220100 ] Anoop Sam John commented on HBASE-18906: I will change it to return a boolean. True means the

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220085#comment-16220085 ] Anoop Sam John commented on HBASE-19047: Well , I thought abt the case u said. That the core

[jira] [Commented] (HBASE-19090) Add config 'hbase.systemtables.compacting.memstore.type' to hbase-default.xml

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220067#comment-16220067 ] Anoop Sam John commented on HBASE-19090: +1 > Add config

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220032#comment-16220032 ] Anoop Sam John commented on HBASE-19092: This is about making some new things for CP expose and

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Attachment: HBASE-19047_V2.patch > CP exposed Scanner types should not extend Shipper >

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220026#comment-16220026 ] Anoop Sam John commented on HBASE-19047: [~Apache9] U ok to commit this? On post hook not allow

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220010#comment-16220010 ] Anoop Sam John commented on HBASE-18995: bq.So any name for the InternalCellUtil ? Will change it

[jira] [Commented] (HBASE-19033) Allow CP users to change versions and TTL before opening StoreScanner

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220008#comment-16220008 ] Anoop Sam John commented on HBASE-19033: So for control of TTL/versions etc at time of

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219994#comment-16219994 ] Anoop Sam John commented on HBASE-18995: I would say make this new Internal Util class as Private

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219916#comment-16219916 ] Anoop Sam John commented on HBASE-19047: post hook I believe people were using to create wrapper

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Attachment: HBASE-19047_V2.patch Added comments around the Shipper type casting. > CP

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219308#comment-16219308 ] Anoop Sam John commented on HBASE-19047: bq.Whats going on in Export? Calling Scanner CP hooks?

[jira] [Commented] (HBASE-19048) Cleanup MasterObserver hooks which takes IA private params

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219263#comment-16219263 ] Anoop Sam John commented on HBASE-19048: +1. We can work with follow-on issue as needed. Also

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219215#comment-16219215 ] Anoop Sam John commented on HBASE-18995: Just summarizing the points from RB comments and

[jira] [Commented] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219188#comment-16219188 ] Anoop Sam John commented on HBASE-18906: bq.Do you know if Phoenix still has access to memstore

[jira] [Commented] (HBASE-17290) Potential loss of data for replication of bulk loaded hfiles

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218709#comment-16218709 ] Anoop Sam John commented on HBASE-17290: Sorry for asking it too late. When write marker cell

[jira] [Commented] (HBASE-18994) Decide if META/System tables should use Compacting Memstore or Default Memstore

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218181#comment-16218181 ] Anoop Sam John commented on HBASE-18994: +1 for dev@ discussion.. Ya we should not allow this. >

[jira] [Commented] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218175#comment-16218175 ] Anoop Sam John commented on HBASE-18906: bq.Yeah, how does this relate to HBASE-18905? 18905

[jira] [Commented] (HBASE-18994) Decide if META/System tables should use Compacting Memstore or Default Memstore

2017-10-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218152#comment-16218152 ] Anoop Sam John commented on HBASE-18994: We might not have to add this in hbase-default.xml I

[jira] [Updated] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18906: --- Description: Expose an API for the CPs to wait for all on going flushes in a Region. The API

[jira] [Updated] (HBASE-18906) Provide Region#waitForFlushes API

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18906: --- Summary: Provide Region#waitForFlushes API (was: Investigate Phoenix usages of

[jira] [Updated] (HBASE-18906) Investigate Phoenix usages of Region#waitForXXX APIs

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18906: --- Attachment: HBASE-18906.patch > Investigate Phoenix usages of Region#waitForXXX APIs >

[jira] [Updated] (HBASE-18906) Investigate Phoenix usages of Region#waitForXXX APIs

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18906: --- Status: Patch Available (was: Open) > Investigate Phoenix usages of Region#waitForXXX APIs

[jira] [Commented] (HBASE-18906) Investigate Phoenix usages of Region#waitForXXX APIs

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218091#comment-16218091 ] Anoop Sam John commented on HBASE-18906: For flush if there is already a snapshot in progress, we

[jira] [Commented] (HBASE-19048) Cleanup MasterObserver hooks which takes IA private params

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218087#comment-16218087 ] Anoop Sam John commented on HBASE-19048: bq.One weird thing is necessity of a 1 second pause

[jira] [Commented] (HBASE-13346) Clean up Filter package for post 1.0 s/KeyValue/Cell/g

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217412#comment-16217412 ] Anoop Sam John commented on HBASE-13346: Same package name. But the file to be moved from

[jira] [Commented] (HBASE-19048) Cleanup MasterObserver hooks which takes IA private params

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217340#comment-16217340 ] Anoop Sam John commented on HBASE-19048: If we really dont want any other CP usages of these

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217332#comment-16217332 ] Anoop Sam John commented on HBASE-19047: At this time of assign Shipper, we have the scanner

[jira] [Commented] (HBASE-18946) Stochastic load balancer assigns replica regions to the same RS

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216905#comment-16216905 ] Anoop Sam John commented on HBASE-18946: bq.When the Balancer is passed a List, could it look at

[jira] [Commented] (HBASE-19072) Missing break in catch block of InterruptedException in HRegion#waitForFlushes()

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216711#comment-16216711 ] Anoop Sam John commented on HBASE-19072: Same needed in waitForFlushesAndCompactions also. >

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Hadoop Flags: Incompatible change Status: Patch Available (was: Open) > CP

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Attachment: HBASE-19047.patch > CP exposed Scanner types should not extend Shipper >

[jira] [Commented] (HBASE-18994) Decide if META/System tables should use Compacting Memstore or Default Memstore

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216594#comment-16216594 ] Anoop Sam John commented on HBASE-18994: Again the naming consistency as pointed by Chia-Ping is

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216403#comment-16216403 ] Anoop Sam John commented on HBASE-19047: Not alternate solutions. Those are steps to impl this.

[jira] [Updated] (HBASE-19047) CP exposed Scanner types should not extend Shipper

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19047: --- Description: Shipper is a IA.Private interface and very much internal.. Right now CP

[jira] [Commented] (HBASE-18994) Decide if META/System tables should use Compacting Memstore or Default Memstore

2017-10-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216379#comment-16216379 ] Anoop Sam John commented on HBASE-18994: This config decides memstore impl class for all system

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216353#comment-16216353 ] Anoop Sam John commented on HBASE-18905: Yes. Internally when we do flush/compaction, the Dummy

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216242#comment-16216242 ] Anoop Sam John commented on HBASE-18905: The tracker is not some thing the core makes and pass to

[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215028#comment-16215028 ] Anoop Sam John commented on HBASE-19057: Change in docket file is as per the recent change in

[jira] [Commented] (HBASE-19057) Fix other code review comments about FilterList Improvement

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214990#comment-16214990 ] Anoop Sam John commented on HBASE-19057: As discussed above, better we keep the original way of

[jira] [Updated] (HBASE-19067) Do not expose getHDFSBlockDistribution in StoreFile

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19067: --- Resolution: Fixed Hadoop Flags: Incompatible change,Reviewed (was: Incompatible

[jira] [Commented] (HBASE-18906) Investigate Phoenix usages of Region#waitForXXX APIs

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214954#comment-16214954 ] Anoop Sam John commented on HBASE-18906: The Phoenix usage is like a time bound wait.. So

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214948#comment-16214948 ] Anoop Sam John commented on HBASE-18905: Quick go over the patch, looks good.. Same approach as

[jira] [Updated] (HBASE-19067) Do not expose getHDFSBlockDistribution in StoreFile

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19067: --- Hadoop Flags: Incompatible change Status: Patch Available (was: Open) > Do not

[jira] [Updated] (HBASE-19067) Do not expose getHDFSBlockDistribution in StoreFile

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19067: --- Attachment: HBASE-19067.patch [~Apache9] Simple patch. > Do not expose

[jira] [Updated] (HBASE-19067) Do not expose getHDFSBlockDistribution in StoreFile

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19067: --- Description: StoreFile is exposed for CPs and this is having HDFSBlocksDistribution

[jira] [Created] (HBASE-19067) Do not expose getHDFSBlockDistribution in StoreFile

2017-10-23 Thread Anoop Sam John (JIRA)
Anoop Sam John created HBASE-19067: -- Summary: Do not expose getHDFSBlockDistribution in StoreFile Key: HBASE-19067 URL: https://issues.apache.org/jira/browse/HBASE-19067 Project: HBase

[jira] [Updated] (HBASE-19046) RegionObserver#postCompactSelection Avoid passing shaded ImmutableList param

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19046: --- Resolution: Fixed Hadoop Flags: Incompatible change,Reviewed Release Note:

[jira] [Updated] (HBASE-19046) RegionObserver#postCompactSelection Avoid passing shaded ImmutableList param

2017-10-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19046: --- Summary: RegionObserver#postCompactSelection Avoid passing shaded ImmutableList param

[jira] [Commented] (HBASE-19046) RegionObserver#postCompactSelection Passing an ImmutableList param of PB type

2017-10-22 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214687#comment-16214687 ] Anoop Sam John commented on HBASE-19046: Test failure seems not at all related.. [~chia7712] May

[jira] [Updated] (HBASE-19046) RegionObserver#postCompactSelection Passing an ImmutableList param of PB type

2017-10-22 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19046: --- Attachment: HBASE-19046.patch > RegionObserver#postCompactSelection Passing an

[jira] [Commented] (HBASE-19057) Merge branch HBASE-18410 to master branch

2017-10-22 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214380#comment-16214380 ] Anoop Sam John commented on HBASE-19057: [~openinx] Checked the test case and got it.. So the

[jira] [Commented] (HBASE-19057) Merge branch HBASE-18410 to master branch

2017-10-21 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213998#comment-16213998 ] Anoop Sam John commented on HBASE-19057: bq.Actually, we have some type of filter , such as

[jira] [Commented] (HBASE-19046) RegionObserver#postCompactSelection Passing an ImmutableList param of PB type

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213067#comment-16213067 ] Anoop Sam John commented on HBASE-19046: compaction.getRequest().getFiles() returns Collection

[jira] [Updated] (HBASE-19046) RegionObserver#postCompactSelection Passing an ImmutableList param of PB type

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19046: --- Status: Patch Available (was: Open) > RegionObserver#postCompactSelection Passing an

[jira] [Updated] (HBASE-19046) RegionObserver#postCompactSelection Passing an ImmutableList param of PB type

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19046: --- Attachment: HBASE-19046.patch The actual object being passed to CP is same. Only the CP

[jira] [Resolved] (HBASE-19045) Deprecate RegionObserver#postInstantiateDeleteTracker

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John resolved HBASE-19045. Resolution: Fixed Hadoop Flags: Reviewed Pushed to branch-2 and master. Thanks Stack

[jira] [Updated] (HBASE-19045) Deprecate RegionObserver#postInstantiateDeleteTracker

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19045: --- Attachment: HBASE-19045.patch Simple patch. > Deprecate

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212946#comment-16212946 ] Anoop Sam John commented on HBASE-19052: +1 > FixedFileTrailer should recognize

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212454#comment-16212454 ] Anoop Sam John commented on HBASE-19052: 2.0 based HFiles handling is already there in

[jira] [Commented] (HBASE-19057) Merge branch HBASE-18410 to master branch

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212352#comment-16212352 ] Anoop Sam John commented on HBASE-19057: - Seem filterKeyValue(Cell) can be moved to

[jira] [Commented] (HBASE-10367) RegionServer graceful stop / decommissioning

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212270#comment-16212270 ] Anoop Sam John commented on HBASE-10367: Ya saw another jira now where AC hooks are added. Thanks

[jira] [Commented] (HBASE-18873) Hide protobufs in GlobalQuotaSettings

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212191#comment-16212191 ] Anoop Sam John commented on HBASE-18873: I think this make sense. I can see some private marked

[jira] [Commented] (HBASE-10367) RegionServer graceful stop / decommissioning

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212181#comment-16212181 ] Anoop Sam John commented on HBASE-10367: Sorry did not check this patch any time.. Just seeing

[jira] [Commented] (HBASE-19050) Improve javadoc of Scan#setMvccReadPoint

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211504#comment-16211504 ] Anoop Sam John commented on HBASE-19050: This is for continuing with the same readPnt when there

[jira] [Comment Edited] (HBASE-19052) Backport CellComparatorImpl related changes to branch-1.x

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211498#comment-16211498 ] Anoop Sam John edited comment on HBASE-19052 at 10/19/17 6:24 PM: -- The

[jira] [Commented] (HBASE-19052) Backport CellComparatorImpl related changes to branch-1.x

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211498#comment-16211498 ] Anoop Sam John commented on HBASE-19052: The fix for 1.x will contain only the FFT change where

[jira] [Comment Edited] (HBASE-15172) Support setting storage policy in bulkload

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210858#comment-16210858 ] Anoop Sam John edited comment on HBASE-15172 at 10/19/17 10:40 AM: ---

[jira] [Commented] (HBASE-15172) Support setting storage policy in bulkload

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210858#comment-16210858 ] Anoop Sam John commented on HBASE-15172: bq.normal HFiles, if there's special configuration for

[jira] [Commented] (HBASE-19048) Cleanup MasterObserver hooks which takes IA private params

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210857#comment-16210857 ] Anoop Sam John commented on HBASE-19048: cc [~stack] > Cleanup MasterObserver hooks which takes

[jira] [Updated] (HBASE-19048) Cleanup MasterObserver hooks which takes IA private params

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19048: --- Description: These are the ones in MasterObserver {code} preAbortProcedure

[jira] [Created] (HBASE-19048) Cleanup MasterObserver hooks which takes IA private params

2017-10-19 Thread Anoop Sam John (JIRA)
Anoop Sam John created HBASE-19048: -- Summary: Cleanup MasterObserver hooks which takes IA private params Key: HBASE-19048 URL: https://issues.apache.org/jira/browse/HBASE-19048 Project: HBase

[jira] [Comment Edited] (HBASE-18169) Coprocessor fix and cleanup before 2.0.0 release

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210818#comment-16210818 ] Anoop Sam John edited comment on HBASE-18169 at 10/19/17 10:31 AM: ---

[jira] [Commented] (HBASE-18169) Coprocessor fix and cleanup before 2.0.0 release

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210833#comment-16210833 ] Anoop Sam John commented on HBASE-18169: StoreFile is exposed for CPs and this is having

[jira] [Commented] (HBASE-18169) Coprocessor fix and cleanup before 2.0.0 release

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210821#comment-16210821 ] Anoop Sam John commented on HBASE-18169: Also [~Apache9], postStoreFileReaderOpen having params

[jira] [Commented] (HBASE-18169) Coprocessor fix and cleanup before 2.0.0 release

2017-10-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210818#comment-16210818 ] Anoop Sam John commented on HBASE-18169: preWALRestore and postWALRestore having a WALKey param

<    9   10   11   12   13   14   15   16   17   18   >