[
https://issues.apache.org/jira/browse/HBASE-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834162#comment-15834162
]
Heng Chen edited comment on HBASE-17503 at 1/23/17 10:05 AM:
-
{code}
+void
[
https://issues.apache.org/jira/browse/HBASE-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834162#comment-15834162
]
Heng Chen commented on HBASE-17503:
---
{code}
+void Configuration::SetInt(const std::string , const
[
https://issues.apache.org/jira/browse/HBASE-17096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-17096:
--
Fix Version/s: 0.98.24
Status: Patch Available (was: Open)
> checkAndMutateApi doesn't
[
https://issues.apache.org/jira/browse/HBASE-17096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-17096:
--
Attachment: HBASE-17096-0.98.v2.patch
Really sorry for this issue, i miss the condition in request of
[
https://issues.apache.org/jira/browse/HBASE-17096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667090#comment-15667090
]
Heng Chen commented on HBASE-17096:
---
Let me check it. :)
> checkAndMutateApi doesn't work correctly
[
https://issues.apache.org/jira/browse/HBASE-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665637#comment-15665637
]
Heng Chen commented on HBASE-17092:
---
+1
> Both LoadIncrementalHFiles#doBulkLoad() methods should set
[
https://issues.apache.org/jira/browse/HBASE-17037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659254#comment-15659254
]
Heng Chen commented on HBASE-17037:
---
+1 for it.
> Enhance LoadIncrementalHFiles API to convey loaded
[
https://issues.apache.org/jira/browse/HBASE-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624262#comment-15624262
]
Heng Chen commented on HBASE-16938:
---
The patch looks OK to me. It extracts the updater to be one tool,
[
https://issues.apache.org/jira/browse/HBASE-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624032#comment-15624032
]
Heng Chen commented on HBASE-16938:
---
It is OK for me to make the Updater to be one tool.
>
[
https://issues.apache.org/jira/browse/HBASE-16973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622248#comment-15622248
]
Heng Chen commented on HBASE-16973:
---
Notice that HBase-11544 has been only applied on branch-1.1.x, So
[
https://issues.apache.org/jira/browse/HBASE-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620914#comment-15620914
]
Heng Chen commented on HBASE-16954:
---
commit to master
> Unify HTable#checkAndDelete with AP
>
[
https://issues.apache.org/jira/browse/HBASE-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620917#comment-15620917
]
Heng Chen commented on HBASE-16954:
---
Thanks [~chia7712] for your patch.
> Unify HTable#checkAndDelete
[
https://issues.apache.org/jira/browse/HBASE-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16954:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/HBASE-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613849#comment-15613849
]
Heng Chen commented on HBASE-16954:
---
+1
> Unify HTable#checkAndDelete with AP
>
[
https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612286#comment-15612286
]
Heng Chen commented on HBASE-16610:
---
Thanks [~chia7712] for your attention. I am little busy recently,
[
https://issues.apache.org/jira/browse/HBASE-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612277#comment-15612277
]
Heng Chen commented on HBASE-16593:
---
Of course we could do it. Go for it. [~chia7712] :)
> Unify
[
https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581074#comment-15581074
]
Heng Chen commented on HBASE-16698:
---
patch for branch-1 LGTM. +1
We will open it by default on
[
https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581067#comment-15581067
]
Heng Chen commented on HBASE-16698:
---
{quote}
so in my analysis, waiting for sync and waiting for latch
[
https://issues.apache.org/jira/browse/HBASE-16853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580931#comment-15580931
]
Heng Chen commented on HBASE-16853:
---
+1
> Regions are assigned to Region Servers in /hbase/draining
[
https://issues.apache.org/jira/browse/HBASE-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574695#comment-15574695
]
Heng Chen commented on HBASE-16653:
---
NO. Not do it. And old rs can't parse NS information due to it
[
https://issues.apache.org/jira/browse/HBASE-16821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574683#comment-15574683
]
Heng Chen commented on HBASE-16821:
---
Any differenece between v1 and v2?
> Enhance
[
https://issues.apache.org/jira/browse/HBASE-16785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574538#comment-15574538
]
Heng Chen commented on HBASE-16785:
---
It worked! Cheering!
+1 for patch
> We are not running all
[
https://issues.apache.org/jira/browse/HBASE-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574527#comment-15574527
]
Heng Chen commented on HBASE-16653:
---
Old RS can't parse peer information with namespace.
> Backport
[
https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574517#comment-15574517
]
Heng Chen edited comment on HBASE-16698 at 10/14/16 7:24 AM:
-
I think
[
https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574517#comment-15574517
]
Heng Chen commented on HBASE-16698:
---
I think [~allan163] you are right.
It is different between
[
https://issues.apache.org/jira/browse/HBASE-16821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574105#comment-15574105
]
Heng Chen commented on HBASE-16821:
---
+1 for it. LGTM.
> Enhance LoadIncrementalHFiles to convey
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Fix Version/s: (was: 1.1.8)
(was: 1.2.5)
> Timeout logic in AsyncProcess is
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574102#comment-15574102
]
Heng Chen commented on HBASE-16664:
---
I see it. If so, i suggest we just leave operationTimeout
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574072#comment-15574072
]
Heng Chen commented on HBASE-16664:
---
I think we should add the setXXTimeout interface in Table for
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574052#comment-15574052
]
Heng Chen commented on HBASE-16664:
---
branch-1.1 and branch-1.2 patch seems not fix "setXXXTimeout not
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Fix Version/s: 1.1.8
1.2.5
> Timeout logic in AsyncProcess is broken
>
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574033#comment-15574033
]
Heng Chen commented on HBASE-16664:
---
OH, sorry, miss the two patch, let me commit them.
> Timeout
[
https://issues.apache.org/jira/browse/HBASE-16832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573956#comment-15573956
]
Heng Chen commented on HBASE-16832:
---
Thanks [~aoxiang]. +1 for it.
> Reduce the default number of
[
https://issues.apache.org/jira/browse/HBASE-16832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573922#comment-15573922
]
Heng Chen commented on HBASE-16832:
---
[~te...@apache.org] do you know why DEFAULT_HBASE_META_VERSIONS is
[
https://issues.apache.org/jira/browse/HBASE-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573914#comment-15573914
]
Heng Chen commented on HBASE-16653:
---
Due to we modify proto object of ReplicationPeerConfig (add
[
https://issues.apache.org/jira/browse/HBASE-16832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573810#comment-15573810
]
Heng Chen commented on HBASE-16832:
---
The default value of major_compaction for your cluster is 7 days?
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572129#comment-15572129
]
Heng Chen commented on HBASE-16807:
---
commit to all branches
> RegionServer will fail to report new
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16807:
--
Fix Version/s: 1.1.8
1.2.5
> RegionServer will fail to report new active Hmaster
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16807:
--
Fix Version/s: 0.98.24
1.3.1
1.4.0
> RegionServer will fail to
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572030#comment-15572030
]
Heng Chen commented on HBASE-16807:
---
Will you upload patch for branch-1.1 and branch-1.2 ?
>
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572025#comment-15572025
]
Heng Chen commented on HBASE-16807:
---
That's great you have patch for branch-1+, let me commit it.
>
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Release Note:
This issue fix three bugs:
1. rpcTimeout configuration not work for one rpc call in AP
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Release Note:
This issue fix three bugs:
1. rpcTimeout configuration not work for one rpc call in AP
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Release Note:
This issue fix three bugs:
1.
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571706#comment-15571706
]
Heng Chen commented on HBASE-16664:
---
push to branch-1.3
> Timeout logic in AsyncProcess is broken
>
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571528#comment-15571528
]
Heng Chen commented on HBASE-16807:
---
push to master. Thanks all the guys!
> RegionServer will fail to
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16807:
--
Resolution: Fixed
Release Note: push to master. Thanks all the guys!
Status: Resolved
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Attachment: HBASE-16664-branch-1.3.v3.patch
> Timeout logic in AsyncProcess is broken
>
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571399#comment-15571399
]
Heng Chen commented on HBASE-16664:
---
Failed testcase of patch v2 on branch-1 is not related. Most of
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Attachment: HBASE-16664-branch-1.v3.patch
upload patch v3 for branch-1, remove unused tracker.start
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Fix Version/s: 1.3.1
1.4.0
2.0.0
> Timeout logic in AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570846#comment-15570846
]
Heng Chen commented on HBASE-16807:
---
Got it. +1 for it.
> RegionServer will fail to report new active
[
https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570840#comment-15570840
]
Heng Chen commented on HBASE-16698:
---
Numbers seems 20 regions on one RS. If you have time, please
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570829#comment-15570829
]
Heng Chen commented on HBASE-16807:
---
You patch seems just skip the cache without consider
[
https://issues.apache.org/jira/browse/HBASE-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570822#comment-15570822
]
Heng Chen commented on HBASE-16653:
---
Let me take a look of patch v3. Need some time.
> Backport
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570746#comment-15570746
]
Heng Chen commented on HBASE-16664:
---
Failed test cases for v7 seems not related. If you are not hurry,
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567915#comment-15567915
]
Heng Chen commented on HBASE-16664:
---
remove the line in MultiServerCallable.call in branch-1 patch
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567826#comment-15567826
]
Heng Chen commented on HBASE-16664:
---
As for operationTimeout meaning, yeah, the operation should from
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567778#comment-15567778
]
Heng Chen commented on HBASE-16664:
---
it should be better for tracker.start() moved into
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567711#comment-15567711
]
Heng Chen commented on HBASE-16664:
---
OK. If all your guys agree with operation timeout should be
[
https://issues.apache.org/jira/browse/HBASE-16807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567648#comment-15567648
]
Heng Chen commented on HBASE-16807:
---
Just skip the cache is OK here?
> RegionServer will fail to
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567527#comment-15567527
]
Heng Chen commented on HBASE-16664:
---
{quote}
Then just set operation timeout to Long.MAX_VALUE and use
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567465#comment-15567465
]
Heng Chen commented on HBASE-16664:
---
{quote}
We can not tell users "some operations don't support a
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567451#comment-15567451
]
Heng Chen commented on HBASE-16664:
---
{quote}
And I think for a user, I call the batch method, or the
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567420#comment-15567420
]
Heng Chen edited comment on HBASE-16664 at 10/12/16 3:34 AM:
-
The typical
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567420#comment-15567420
]
Heng Chen commented on HBASE-16664:
---
The typical case in our application is something like
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567379#comment-15567379
]
Heng Chen commented on HBASE-16664:
---
Normally we share one HTable object in our application. It is
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567343#comment-15567343
]
Heng Chen commented on HBASE-16664:
---
For example, in our production cluster, we set operation timeout
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567319#comment-15567319
]
Heng Chen commented on HBASE-16664:
---
I think the reason we did not set total timeout for batch is that
[
https://issues.apache.org/jira/browse/HBASE-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534842#comment-15534842
]
Heng Chen commented on HBASE-16653:
---
As [~enis] mentioned, we should leave the deprecated method here
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529035#comment-15529035
]
Heng Chen commented on HBASE-16664:
---
Yes, the timeout logic has conflicts. After HBASE-16607,
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528946#comment-15528946
]
Heng Chen edited comment on HBASE-16664 at 9/28/16 8:49 AM:
So we could
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528946#comment-15528946
]
Heng Chen commented on HBASE-16664:
---
So we could modify the operation timeout judgement logic in
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528761#comment-15528761
]
Heng Chen commented on HBASE-16664:
---
{quote}
As I said, we can not use RetryingTimeTracker because it
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16664:
--
Attachment: 1.patch
1.patch (Maybe compile failed, very rough patch) could describe my thought
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528636#comment-15528636
]
Heng Chen commented on HBASE-16664:
---
{quote}
one is we use remaining time as the rpc timeout in
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528595#comment-15528595
]
Heng Chen commented on HBASE-16664:
---
Just skim the patch, not see the big difference with the
[
https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528581#comment-15528581
]
Heng Chen commented on HBASE-16698:
---
{quote}
so the main problem is sequential appends and the logic
[
https://issues.apache.org/jira/browse/HBASE-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524987#comment-15524987
]
Heng Chen commented on HBASE-16698:
---
How much the performance will be downgrade when ops are just for
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16665:
--
Resolution: Fixed
Assignee: Heng Chen
Hadoop Flags: Reviewed
Fix Version/s: 2.0.0
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520300#comment-15520300
]
Heng Chen commented on HBASE-16664:
---
Not sure what is your patch want to do.
But if you want the
[
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520289#comment-15520289
]
Heng Chen commented on HBASE-16664:
---
{quote}
The tracker must be started from beginning, not each call.
[
https://issues.apache.org/jira/browse/HBASE-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16677:
--
Resolution: Fixed
Assignee: Guang Yang
Hadoop Flags: Reviewed
Fix Version/s:
[
https://issues.apache.org/jira/browse/HBASE-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520064#comment-15520064
]
Heng Chen commented on HBASE-16677:
---
works locally. Push to master and branch-1
> Add table size
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519903#comment-15519903
]
Heng Chen commented on HBASE-16665:
---
will commit it if no other concerns.
> Check whether
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518113#comment-15518113
]
Heng Chen commented on HBASE-16665:
---
hadoop.hbase.client.TestBlockEvictionFromClient failed w/ or w/o
[
https://issues.apache.org/jira/browse/HBASE-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16677:
--
Fix Version/s: 1.2.4
1.1.7
1.3.1
1.4.0
[
https://issues.apache.org/jira/browse/HBASE-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518100#comment-15518100
]
Heng Chen commented on HBASE-16677:
---
LGTM. +1
Let me test it locally and commit it. Thanks
[
https://issues.apache.org/jira/browse/HBASE-16702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16702:
--
Description:
Heng Chen created HBASE-16702:
-
Summary: TestBlockEvictionFromClient is broken
Key: HBASE-16702
URL: https://issues.apache.org/jira/browse/HBASE-16702
Project: HBase
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16665:
--
Attachment: HBASE-16665.v3.patch
> Check whether KeyValueUtil.createXXX could be replaced by CellUtil
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516028#comment-15516028
]
Heng Chen commented on HBASE-16665:
---
Sounds reasonable. Empty byte[] will be better.
> Check whether
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516005#comment-15516005
]
Heng Chen commented on HBASE-16665:
---
v2 Fix failed testcase
> Check whether KeyValueUtil.createXXX
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heng Chen updated HBASE-16665:
--
Attachment: HBASE-16665.v2.patch
> Check whether KeyValueUtil.createXXX could be replaced by CellUtil
[
https://issues.apache.org/jira/browse/HBASE-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515236#comment-15515236
]
Heng Chen commented on HBASE-16677:
---
+1 for patch v3, Not see regions hidden in your upload pic?
[
https://issues.apache.org/jira/browse/HBASE-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512545#comment-15512545
]
Heng Chen commented on HBASE-16677:
---
That is a good point. We have the same pain on production cluster
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512417#comment-15512417
]
Heng Chen commented on HBASE-16665:
---
Will open another issue for cleanup, keep this issue small and
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512330#comment-15512330
]
Heng Chen edited comment on HBASE-16665 at 9/22/16 6:22 AM:
Another thoughts
[
https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512330#comment-15512330
]
Heng Chen commented on HBASE-16665:
---
Another thoughts about KeyValueUtil and CellUtil, we'd better to
[
https://issues.apache.org/jira/browse/HBASE-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512318#comment-15512318
]
Heng Chen commented on HBASE-16670:
---
sounds reasonable. Will be more friendly to our users. +1
>
1 - 100 of 1722 matches
Mail list logo
