[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2016-01-02 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076751#comment-15076751 ] Lars Hofhansl commented on HBASE-15059: --- Ping... :) Good to commit V2? > Allow 0.94 to compile

[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-31 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076053#comment-15076053 ] Lars Hofhansl commented on HBASE-15059: --- [~stack] you OK with committing V2? > Allow 0.94 to

[jira] [Commented] (HBASE-15061) Refactor StoreFileScanner creation to builder pattern

2015-12-31 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075836#comment-15075836 ] Lars Hofhansl commented on HBASE-15061: --- This is in a semi-hot code path (done for every Get

[jira] [Updated] (HBASE-14468) Compaction improvements: FIFO compaction policy

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14468: -- Attachment: 14468-0.98.txt For what's it worth, here's a 0.98 patch for your consideration.

[jira] [Created] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-30 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-15059: - Summary: Allow 0.94 to compile against Hadoop 2.7.x Key: HBASE-15059 URL: https://issues.apache.org/jira/browse/HBASE-15059 Project: HBase Issue Type: Bug

[jira] [Updated] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15059: -- Fix Version/s: 0.94.28 > Allow 0.94 to compile against Hadoop 2.7.x >

[jira] [Updated] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15059: -- Description: Currently HBase 0.94 cannot be compiled against Hadoop 2.7. > Allow 0.94 to

[jira] [Updated] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15054: -- Fix Version/s: 0.94.28 > Allow 0.94 to compile with JDK8 > --- > >

[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075517#comment-15075517 ] Lars Hofhansl commented on HBASE-15059: --- Thanks. What do you think about this change? Need to

[jira] [Updated] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15054: -- Release Note: This change replaces public boolean remove(K key, V value) in PoolMap with

[jira] [Updated] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15054: -- Release Note: This change replaces {{public boolean remove(K key, V value)}} in {{PoolMap}}

[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075526#comment-15075526 ] Lars Hofhansl commented on HBASE-15059: --- bq. Too big a change for point release. Will make it so

[jira] [Updated] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15059: -- Attachment: 15059.txt Simple patch. Can I just remove TimeStampingFileContext?! It's not used

[jira] [Assigned] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl reassigned HBASE-15054: - Assignee: Lars Hofhansl > Allow 0.94 to compile with JDK8 >

[jira] [Commented] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075466#comment-15075466 ] Lars Hofhansl commented on HBASE-15054: --- Thanks [~stack], pushed to 0.94. > Allow 0.94 to compile

[jira] [Commented] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075410#comment-15075410 ] Lars Hofhansl commented on HBASE-15054: --- [~stack], [~apurtell], [~busbey], any concerns? Could

[jira] [Updated] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x

2015-12-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15059: -- Attachment: 15059-v2.txt V2. This is needed to actually run it. Notice that I force the

[jira] [Created] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-29 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-15054: - Summary: Allow 0.94 to compile with JDK8 Key: HBASE-15054 URL: https://issues.apache.org/jira/browse/HBASE-15054 Project: HBase Issue Type: Bug

[jira] [Updated] (HBASE-15054) Allow 0.94 to compile with JDK8

2015-12-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-15054: -- Attachment: 15054.txt Simple patch. Will break if somebody inherited from pool map, should

[jira] [Commented] (HBASE-15046) Perf test doing all mutation steps under row lock

2015-12-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074710#comment-15074710 ] Lars Hofhansl commented on HBASE-15046: --- Hey [~stack]. I'm very interested in this. Wanna huddle

[jira] [Commented] (HBASE-14468) Compaction improvements: FIFO compaction policy

2015-12-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074732#comment-15074732 ] Lars Hofhansl commented on HBASE-14468: --- This is almost strictly add-on. We can backport to 0.98 I

[jira] [Commented] (HBASE-15046) Perf test doing all mutation steps under row lock

2015-12-28 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073328#comment-15073328 ] Lars Hofhansl commented on HBASE-15046: --- It's this right now, though: # take rowlock # start mvcc #

[jira] [Commented] (HBASE-15046) Perf test doing all mutation steps under row lock

2015-12-28 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073563#comment-15073563 ] Lars Hofhansl commented on HBASE-15046: --- bq. Currently, sync WAL is not really 'sync' (it use

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071251#comment-15071251 ] Lars Hofhansl commented on HBASE-14822: --- Turns out HBase 1.0.x does not have the exception metrics,

[jira] [Commented] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071359#comment-15071359 ] Lars Hofhansl commented on HBASE-14940: --- TestFromClientSide passes. If anything was wrong this, I

[jira] [Commented] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071260#comment-15071260 ] Lars Hofhansl commented on HBASE-14940: --- Should we replace {source} unaligned = (Boolean)

[jira] [Comment Edited] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071260#comment-15071260 ] Lars Hofhansl edited comment on HBASE-14940 at 12/24/15 9:35 PM: - Should

[jira] [Commented] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071360#comment-15071360 ] Lars Hofhansl commented on HBASE-14940: --- And looks right in the debugger. > Make our unsafe based

[jira] [Updated] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14940: -- Release Note: (was: Pushed to 0.98 only.) > Make our unsafe based ops more safe >

[jira] [Resolved] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl resolved HBASE-14940. --- Resolution: Fixed Release Note: Pushed to 0.98 only. > Make our unsafe based ops more

[jira] [Commented] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071259#comment-15071259 ] Lars Hofhansl commented on HBASE-14940: --- Must have to do with compileSource being 1.6 in 0.98, and

[jira] [Commented] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071358#comment-15071358 ] Lars Hofhansl commented on HBASE-14940: --- +1 on addendum. I'm going to commit that to 0.98. (It

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071261#comment-15071261 ] Lars Hofhansl commented on HBASE-14822: --- Pushed addendum to all branches, I hope this is the last

[jira] [Commented] (HBASE-13477) Create metrics on failed requests

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071249#comment-15071249 ] Lars Hofhansl commented on HBASE-13477: --- So we decided not to have this 1.0.x? (just ran into this

[jira] [Commented] (HBASE-14940) Make our unsafe based ops more safe

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071256#comment-15071256 ] Lars Hofhansl commented on HBASE-14940: --- Looks like this break compilation in 0.98 now: {code}

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-master-addendum.txt Same for master. > Renewing leases of scanners doesn't

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071164#comment-15071164 ] Lars Hofhansl commented on HBASE-14822: --- Thanks [~samarthjain], that's what I just found. Looking

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-0.98-addendum.txt Addendum that fixes this for 0.98. Uses RS metrics in the

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071126#comment-15071126 ] Lars Hofhansl commented on HBASE-14822: --- Hmm... I thought you had tested this patch? Seems I cannot

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071131#comment-15071131 ] Lars Hofhansl commented on HBASE-14822: --- Hmm... I see that indeed each call increases the callSeq

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071162#comment-15071162 ] Lars Hofhansl commented on HBASE-14822: --- The test passes, because the scan is retried. Meh. I have

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065461#comment-15065461 ] Lars Hofhansl commented on HBASE-14822: --- pushed to master... Working on other branches now. >

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065451#comment-15065451 ] Lars Hofhansl commented on HBASE-14822: --- Yeah... Lemme push to all branches. > Renewing leases of

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-v5-1.3.txt Patch for 1.3 for reference > Renewing leases of scanners

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065467#comment-15065467 ] Lars Hofhansl commented on HBASE-14822: --- 1.3 and 1.2 done > Renewing leases of scanners doesn't

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Resolution: Fixed Hadoop Flags: Reviewed Release Note: And 1.1, 1.0, and 0.98.

[jira] [Commented] (HBASE-13796) ZKUtil doesn't clean quorum setting properly

2015-12-12 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054812#comment-15054812 ] Lars Hofhansl commented on HBASE-13796: --- Nice. Thanks [~gjacoby] > ZKUtil doesn't clean quorum

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-11 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054028#comment-15054028 ] Lars Hofhansl commented on HBASE-14822: --- We should be good with this: * The API already exists and

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-11 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-v5-0.98.txt Hopefully final version for 0.98. * Removes changes for

[jira] [Commented] (HBASE-14951) Make hbase.regionserver.maxlogs obsolete

2015-12-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052258#comment-15052258 ] Lars Hofhansl commented on HBASE-14951: --- Yeah. Would love to get rid of this config option. Where

[jira] [Commented] (HBASE-14953) HBaseInterClusterReplicationEndpoint: Do not retry the whole batch of edits in case of RejectedExecutionException

2015-12-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052262#comment-15052262 ] Lars Hofhansl commented on HBASE-14953: --- +1 on V2. I assume it still fixes the issue you've seen?

[jira] [Commented] (HBASE-14953) HBaseInterClusterReplicationEndpoint: Do not retry the whole batch of edits in case of RejectedExecutionException

2015-12-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052263#comment-15052263 ] Lars Hofhansl commented on HBASE-14953: --- If not objection I'm going to commit tomorrow. >

[jira] [Commented] (HBASE-14953) HBaseInterClusterReplicationEndpoint: Do not retry the whole batch of edits in case of RejectedExecutionException

2015-12-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050198#comment-15050198 ] Lars Hofhansl commented on HBASE-14953: --- Interesting, didn't think of that case. Amazing how many

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047239#comment-15047239 ] Lars Hofhansl commented on HBASE-14869: --- There's one last change I think we should do (Discussed

[jira] [Updated] (HBASE-14869) Better request latency histograms

2015-12-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14869: -- Attachment: 14869-v6-0.98.txt 0.98 version with that. Master coming. Going to commit later

[jira] [Updated] (HBASE-14869) Better request latency and size histograms

2015-12-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14869: -- Summary: Better request latency and size histograms (was: Better request latency histograms)

[jira] [Commented] (HBASE-14869) Better request latency and size histograms

2015-12-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047891#comment-15047891 ] Lars Hofhansl commented on HBASE-14869: --- Committed to the world. (Every branch needed a slight

[jira] [Updated] (HBASE-14869) Better request latency and size histograms

2015-12-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14869: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-05 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-v5.txt * fixes the long line * removed code for ClientSmallScanner (since

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042680#comment-15042680 ] Lars Hofhansl commented on HBASE-14822: --- Lemme make the master patch and see whether there's still

[jira] [Updated] (HBASE-14922) Delayed flush doesn't work causing flush storms.

2015-12-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14922: -- Attachment: 14922-fix.txt This fixes it for me. [~eclark] what do you think? > Delayed flush

[jira] [Commented] (HBASE-14922) Delayed flush doesn't work causing flush storms.

2015-12-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042720#comment-15042720 ] Lars Hofhansl commented on HBASE-14922: --- Looks like this break the mini cluster. I see a ton of

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-v4.txt Version for master. * uses same protobuf * passes TestReplicasClient,

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-v4-0.98.txt 0.98 version that simply adds a new PB flag. Master version

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039738#comment-15039738 ] Lars Hofhansl commented on HBASE-14869: --- Cool. Metric name's the only open issue. If nobody else

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-02 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037322#comment-15037322 ] Lars Hofhansl commented on HBASE-14822: --- Seems like I should regroup and just add another flag to

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-01 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035373#comment-15035373 ] Lars Hofhansl commented on HBASE-14822: --- Hmm... There's something with region replicas and the

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-12-01 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035329#comment-15035329 ] Lars Hofhansl commented on HBASE-14822: --- Lemme look at the test failures and javadoc errors. >

[jira] [Updated] (HBASE-14869) Better request latency histograms

2015-12-01 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14869: -- Status: Patch Available (was: Open) > Better request latency histograms >

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-30 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822.txt Master patch. > Renewing leases of scanners doesn't work >

[jira] [Updated] (HBASE-14869) Better request latency histograms

2015-11-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14869: -- Assignee: Vikas Vishwakarma (was: Lars Hofhansl) > Better request latency histograms >

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031322#comment-15031322 ] Lars Hofhansl commented on HBASE-14869: --- -v3 looks good to me. I wonder whether it's worth to make

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-28 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030687#comment-15030687 ] Lars Hofhansl commented on HBASE-14869: --- Why not subclass MutableHistogram? Would save a bunch of

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030186#comment-15030186 ] Lars Hofhansl commented on HBASE-14869: --- [~vik.karma] offered to finish this up. Thank you, sir! I

[jira] [Assigned] (HBASE-14869) Better request latency histograms

2015-11-25 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl reassigned HBASE-14869: - Assignee: Lars Hofhansl > Better request latency histograms >

[jira] [Updated] (HBASE-14869) Better request latency histograms

2015-11-25 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14869: -- Attachment: 14869-v1-0.98.txt Here's a patch that I tested a bit. Reports the right values.

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-25 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028244#comment-15028244 ] Lars Hofhansl commented on HBASE-14869: --- Hmm... Looking at all the metrics, I also see metrics

[jira] [Resolved] (HBASE-14777) Fix Inter Cluster Replication Future ordering issues

2015-11-25 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl resolved HBASE-14777. --- Resolution: Fixed Pushed to all branches. Thanks for bearing with me. > Fix Inter Cluster

[jira] [Commented] (HBASE-14777) Fix Inter Cluster Replication Future ordering issues

2015-11-25 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028183#comment-15028183 ] Lars Hofhansl commented on HBASE-14777: --- Cool... I'll commit this as an addendum to 1.2, 1.3, 2.0.

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026291#comment-15026291 ] Lars Hofhansl commented on HBASE-14869: --- Could also not report ranges without a hit, since we do

[jira] [Updated] (HBASE-14869) Better request latency histograms

2015-11-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14869: -- Attachment: 14869-test-0.98.txt Had a few minutes to work on this. Simple patch. _Totally

[jira] [Comment Edited] (HBASE-14777) Fix Inter Cluster Replication Future ordering issues

2015-11-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025078#comment-15025078 ] Lars Hofhansl edited comment on HBASE-14777 at 11/24/15 7:45 PM: - Any

[jira] [Commented] (HBASE-14777) Fix Inter Cluster Replication Future ordering issues

2015-11-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025078#comment-15025078 ] Lars Hofhansl commented on HBASE-14777: --- Any comments [~ashu210890], [~stack], [~eclark]? I'd like

[jira] [Commented] (HBASE-14777) Fix Inter Cluster Replication Future ordering issues

2015-11-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022613#comment-15022613 ] Lars Hofhansl commented on HBASE-14777: --- I guess I messed HBASE-12988 up. Sorry about that :( I'll

[jira] [Commented] (HBASE-14777) Fix Inter Cluster Replication Future ordering issues

2015-11-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023878#comment-15023878 ] Lars Hofhansl commented on HBASE-14777: --- In fact the first version of the patch used a

[jira] [Updated] (HBASE-14777) Fix Inter Cluster Replication Future ordering issues

2015-11-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14777: -- Attachment: 14777-alternative.txt May I offer this instead? * Uses a proper CompletionService

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021532#comment-15021532 ] Lars Hofhansl commented on HBASE-14869: --- So what are good default latency bands? What do people

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021079#comment-15021079 ] Lars Hofhansl commented on HBASE-14822: --- Any objections to -v3? Or is it time to add a new RPC for

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021078#comment-15021078 ] Lars Hofhansl commented on HBASE-14869: --- I think we have histograms for all these (put time, get

[jira] [Created] (HBASE-14869) Better request latency histograms

2015-11-21 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-14869: - Summary: Better request latency histograms Key: HBASE-14869 URL: https://issues.apache.org/jira/browse/HBASE-14869 Project: HBase Issue Type:

[jira] [Issue Comment Deleted] (HBASE-14735) Region may grow too big and can not be split

2015-11-21 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14735: -- Comment: was deleted (was: Should the problem block this jira issue? I haven't seen this

[jira] [Issue Comment Deleted] (HBASE-14735) Region may grow too big and can not be split

2015-11-21 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14735: -- Comment: was deleted (was: Should the problem block this jira issue? I haven't seen this

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Status: Open (was: Patch Available) > Renewing leases of scanners doesn't work >

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Status: Patch Available (was: Open) > Renewing leases of scanners doesn't work >

[jira] [Comment Edited] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014187#comment-15014187 ] Lars Hofhansl edited comment on HBASE-14822 at 11/19/15 7:25 PM: - This

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Status: Open (was: Patch Available) > Renewing leases of scanners doesn't work >

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Status: Patch Available (was: Open) > Renewing leases of scanners doesn't work >

[jira] [Commented] (HBASE-14791) Batch Deletes in MapReduce jobs (0.98)

2015-11-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014169#comment-15014169 ] Lars Hofhansl commented on HBASE-14791: --- Yeah! :) > Batch Deletes in MapReduce jobs (0.98) >

[jira] [Updated] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-14822: -- Attachment: 14822-0.98-v3.txt This patch should keep the behaviour the way it is. Can you try

[jira] [Commented] (HBASE-14822) Renewing leases of scanners doesn't work

2015-11-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014105#comment-15014105 ] Lars Hofhansl commented on HBASE-14822: --- I removed your patches [~samarthjain] to avoid confusion.

<    4   5   6   7   8   9   10   11   12   13   >