[jira] [Commented] (HBASE-20226) Performance Improvement Taking Large Snapshots In Remote Filesystems

2020-07-27 Thread Ted Yu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166082#comment-17166082 ] Ted Yu commented on HBASE-20226: {code} +if (v1Regions.size() > 0 || v2Regions.size(

[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer

2020-04-08 Thread Ted Yu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078854#comment-17078854 ] Ted Yu commented on HBASE-24137: Please find people who have touched this class to revie

[jira] [Commented] (HBASE-21619) Fix warning message caused by incorrect ternary operator evaluation

2018-12-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725397#comment-16725397 ] Ted Yu commented on HBASE-21619: lgtm > Fix warning message caused by incorrect ternary

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-12-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Status: Patch Available (was: Open) > Introduce WALIdentity interface > --- > >

[jira] [Commented] (HBASE-21479) Individual tests in TestHRegionReplayEvents class are failing

2018-12-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705903#comment-16705903 ] Ted Yu commented on HBASE-21479: Ran TestHRegionReplayEvents#testSkippingEditsWithSmall

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Fix Version/s: 1.4.9 1.3.3 > Remove in progress snapshot check in SnapshotFileCache#getUn

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: (was: 2.0.4) (

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Attachment: 21511.branch-1.v4.txt > Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFi

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Attachment: 21511.branch-1.v3.txt > Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFi

[jira] [Assigned] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-21511: -- Assignee: Ted Yu > Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles >

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Attachment: 21511.v3.txt > Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles > ---

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Attachment: 21511.v2.txt > Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles > ---

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Attachment: 21511.v2.txt > Race condition surrounding in progress snapshot handling in snapshot cache > lea

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Attachment: 21511.v1.txt > Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles > ---

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Attachment: (was: 21511.v1.txt) > Remove in progress snapshot check in SnapshotFileCache#getUnreferenced

[jira] [Created] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-24 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21511: -- Summary: Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles Key: HBASE-21511 URL: https://issues.apache.org/jira/browse/HBASE-21511 Project: HBase

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Status: Patch Available (was: Open) > Remove in progress snapshot check in SnapshotFileCache#getUnreference

[jira] [Updated] (HBASE-21511) Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles

2018-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21511: --- Attachment: 21511.v1.txt > Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles > ---

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697623#comment-16697623 ] Ted Yu commented on HBASE-21387: Ran the failed test locally with addendum which passed.

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Status: Patch Available (was: Reopened) > Race condition surrounding in progress snapshot handling in snaps

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697520#comment-16697520 ] Ted Yu commented on HBASE-21387: TestSnapshotFileCache fails across branches. https://b

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Attachment: 21387.addendum.txt > Race condition surrounding in progress snapshot handling in snapshot cache

[jira] [Reopened] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reopened HBASE-21387: > Race condition surrounding in progress snapshot handling in snapshot cache > leads to loss of snapshot file

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Hadoop Flags: Reviewed Release Note: To prevent race condition between in progress snapshot (performed b

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696227#comment-16696227 ] Ted Yu commented on HBASE-21387: Looks like catching FileNotFoundException is not enough

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Attachment: 21387-suggest.txt > Race condition surrounding in progress snapshot handling in snapshot cache

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693142#comment-16693142 ] Ted Yu commented on HBASE-21387: I was aware of the above JIRA. Thanks for the unit tes

[jira] [Commented] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI

2018-11-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690975#comment-16690975 ] Ted Yu commented on HBASE-21478: bq. what about adding another private member as a copy

[jira] [Updated] (HBASE-21141) Enable MOB in backup / restore test involving incremental backup

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21141: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-21482) TestHRegion fails due to 'Too many open files'

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689903#comment-16689903 ] Ted Yu commented on HBASE-21482: Toward the end of hbase-server/target/surefire-reports

[jira] [Commented] (HBASE-21141) Enable MOB in backup / restore test involving incremental backup

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689834#comment-16689834 ] Ted Yu commented on HBASE-21141: You can shrink the following into one line comment: {co

[jira] [Commented] (HBASE-21141) Enable MOB in backup / restore test involving incremental backup

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689825#comment-16689825 ] Ted Yu commented on HBASE-21141: w.r.t. the long method body, can you reduce method leng

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689816#comment-16689816 ] Ted Yu commented on HBASE-21246: Patch v43 is mostly formatting change on top of v41. >

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.43.txt > Introduce WALIdentity interface > --- > >

[jira] [Commented] (HBASE-21141) Enable MOB in backup / restore test involving incremental backup

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689701#comment-16689701 ] Ted Yu commented on HBASE-21141: We're close. {code} + // #3 - incremental backup f

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689656#comment-16689656 ] Ted Yu commented on HBASE-21387: Haven't got around to adding new unit test (without int

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688926#comment-16688926 ] Ted Yu commented on HBASE-21387: Looking at Zheng's suggestion for new unit test, bq. a

[jira] [Commented] (HBASE-21141) Enable MOB in backup / restore test involving incremental backup

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688648#comment-16688648 ] Ted Yu commented on HBASE-21141: {code} +mobHcd.setMobThreshold(0L); {code} Please i

[jira] [Commented] (HBASE-21482) TestHRegion fails due to 'Too many open files'

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688550#comment-16688550 ] Ted Yu commented on HBASE-21482: Didn't reproduce the test failure in branch-2. Apache

[jira] [Updated] (HBASE-21482) TestHRegion fails due to 'Too many open files'

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21482: --- Attachment: org.apache.hadoop.hbase.regionserver.TestHRegion.txt > TestHRegion fails due to 'Too many open f

[jira] [Updated] (HBASE-21482) TestHRegion fails due to 'Too many open files'

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21482: --- Attachment: org.apache.hadoop.hbase.regionserver.TestHRegion-output.txt > TestHRegion fails due to 'Too many

[jira] [Created] (HBASE-21482) TestHRegion fails due to 'Too many open files'

2018-11-15 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21482: -- Summary: TestHRegion fails due to 'Too many open files' Key: HBASE-21482 URL: https://issues.apache.org/jira/browse/HBASE-21482 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688506#comment-16688506 ] Ted Yu commented on HBASE-21246: Patch v41 fixes TestDLSAsyncFSWAL . TestDLSAsyncFSWAL#

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.41.txt > Introduce WALIdentity interface > --- > >

[jira] [Commented] (HBASE-21479) TestHRegionReplayEvents#testSkippingEditsWithSmallerSeqIdAfterRegionOpenEvent fails with IndexOutOfBoundsException

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688285#comment-16688285 ] Ted Yu commented on HBASE-21479: The single test used to pass. e.g. 243e6cc5293dc1e2a4df

[jira] [Updated] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21460: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-21479) TestHRegionReplayEvents#testSkippingEditsWithSmallerSeqIdAfterRegionOpenEvent fails with IndexOutOfBoundsException

2018-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688224#comment-16688224 ] Ted Yu commented on HBASE-21479: {code} Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3

[jira] [Commented] (HBASE-21479) TestHRegionReplayEvents#testSkippingEditsWithSmallerSeqIdAfterRegionOpenEvent fails with IndexOutOfBoundsException

2018-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687158#comment-16687158 ] Ted Yu commented on HBASE-21479: Progressively stepping back. At : 9012a0b123b3eea8b08c8

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687051#comment-16687051 ] Ted Yu commented on HBASE-21457: See my comment above: HBASE-21466 cleared the way. > B

[jira] [Updated] (HBASE-21479) TestHRegionReplayEvents#testSkippingEditsWithSmallerSeqIdAfterRegionOpenEvent fails with IndexOutOfBoundsException

2018-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21479: --- Attachment: testHRegionReplayEvents-output.txt > TestHRegionReplayEvents#testSkippingEditsWithSmallerSeqIdAf

[jira] [Created] (HBASE-21479) TestHRegionReplayEvents#testSkippingEditsWithSmallerSeqIdAfterRegionOpenEvent fails with IndexOutOfBoundsException

2018-11-14 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21479: -- Summary: TestHRegionReplayEvents#testSkippingEditsWithSmallerSeqIdAfterRegionOpenEvent fails with IndexOutOfBoundsException Key: HBASE-21479 URL: https://issues.apache.org/jira/browse/HBASE-

[jira] [Commented] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache

2018-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686827#comment-16686827 ] Ted Yu commented on HBASE-21460: bq. (instead of `hbase.bucketcache.bucket.size`) I don

[jira] [Commented] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI

2018-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686798#comment-16686798 ] Ted Yu commented on HBASE-21478: RSGroupInfo#getTables() references a SortedSet . Do you

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686778#comment-16686778 ] Ted Yu commented on HBASE-21246: There are fewer test failures with patch v39. Need to

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.39.txt > Introduce WALIdentity interface > --- > >

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685515#comment-16685515 ] Ted Yu commented on HBASE-21246: Patch v37 fixes infinite call in RegionGroupingProvider

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-11-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.37.txt > Introduce WALIdentity interface > --- > >

[jira] [Comment Edited] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685384#comment-16685384 ] Ted Yu edited comment on HBASE-21457 at 11/13/18 3:50 PM: -- Than

[jira] [Updated] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21457: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Comment Edited] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684625#comment-16684625 ] Ted Yu edited comment on HBASE-21387 at 11/13/18 2:18 AM: -- The

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684625#comment-16684625 ] Ted Yu commented on HBASE-21387: The only remaining comment was about a new test, right

[jira] [Updated] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21457: --- Attachment: 21457.v4.txt > BackupUtils#getWALFilesOlderThan refers to wrong FileSystem > ---

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.2.0 3.0.0

[jira] [Commented] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684378#comment-16684378 ] Ted Yu commented on HBASE-21466: Without the leading slash (ahead of 'tmp'), test would

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Attachment: 21466.v3.txt > WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir > ---

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684373#comment-16684373 ] Ted Yu commented on HBASE-21387: TestBlockEvictionFromClient failure was unrelated to pa

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684197#comment-16684197 ] Ted Yu commented on HBASE-21387: TestSnapshotFileCache failed due to NPE, as pointed out

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Attachment: 21387.v12.txt > Race condition surrounding in progress snapshot handling in snapshot cache > le

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Attachment: 21466.v3.txt > WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir > ---

[jira] [Commented] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684169#comment-16684169 ] Ted Yu commented on HBASE-21466: Patch v3 addresses review comments above. > WALProcedu

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Attachment: 21466.v2.txt > WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir > ---

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Attachment: (was: 21466.v1.txt) > WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdi

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683916#comment-16683916 ] Ted Yu commented on HBASE-21457: HBASE-21466 needs to be committed first. Without HBASE-

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Attachment: 21387.v11.txt > Race condition surrounding in progress snapshot handling in snapshot cache > le

[jira] [Comment Edited] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683206#comment-16683206 ] Ted Yu edited comment on HBASE-21387 at 11/12/18 5:22 AM: -- http

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683206#comment-16683206 ] Ted Yu commented on HBASE-21387: https://reviews.apache.org/r/69316/ Adding a test may

[jira] [Updated] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21387: --- Attachment: 21387.v10.txt > Race condition surrounding in progress snapshot handling in snapshot cache > le

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Summary: WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir (was: WALProcedureStore us

[jira] [Commented] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682946#comment-16682946 ] Ted Yu commented on HBASE-21466: Here is snippet from test output without fix: {code} 20

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is not under rootdir

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Description: In WALProcedureStore ctor , the fs field is initialized this way: {code} this.fs = walDir.g

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is on different FileSystem as rootdir

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Attachment: 21466.v1.txt > WALProcedureStore uses wrong FileSystem if wal.dir is on different FileSystem >

[jira] [Updated] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is on different FileSystem as rootdir

2018-11-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21466: --- Status: Patch Available (was: Open) > WALProcedureStore uses wrong FileSystem if wal.dir is on different Fi

[jira] [Created] (HBASE-21466) WALProcedureStore uses wrong FileSystem if wal.dir is on different FileSystem as rootdir

2018-11-11 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21466: -- Summary: WALProcedureStore uses wrong FileSystem if wal.dir is on different FileSystem as rootdir Key: HBASE-21466 URL: https://issues.apache.org/jira/browse/HBASE-21466 Project:

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682644#comment-16682644 ] Ted Yu commented on HBASE-21387: One more note about why I choose 21387.v9.txt as the ve

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682638#comment-16682638 ] Ted Yu commented on HBASE-21246: Currently there are about 69 failing test classes. Wor

[jira] [Updated] (HBASE-13468) hbase.zookeeper.quorum supports ipv6 address

2018-11-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-13468: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Updated] (HBASE-21341) DeadServer shouldn't import unshaded Preconditions

2018-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21341: --- Fix Version/s: 3.0.0 > DeadServer shouldn't import unshaded Preconditions >

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681979#comment-16681979 ] Ted Yu commented on HBASE-21246: Patch v34 is based on current master. Running test sui

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.34.txt > Introduce WALIdentity interface > --- > >

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681855#comment-16681855 ] Ted Yu commented on HBASE-21457: The master startup delay probably is related to procedu

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681852#comment-16681852 ] Ted Yu commented on HBASE-21457: The failed tests are already marked large test. Lookin

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681788#comment-16681788 ] Ted Yu commented on HBASE-21457: Shall we leave the test change to another JIRA ? > Bac

[jira] [Commented] (HBASE-21387) Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680721#comment-16680721 ] Ted Yu commented on HBASE-21387: [~openinx][~Apache9][~elserj] : Gentle ping. > Race co

[jira] [Updated] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21457: --- Attachment: 21457.v3.txt > BackupUtils#getWALFilesOlderThan refers to wrong FileSystem > ---

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680549#comment-16680549 ] Ted Yu commented on HBASE-21246: Looking at compilation errors for patch v22: 321 lines

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680531#comment-16680531 ] Ted Yu commented on HBASE-21457: The test passed during local run. Tests run: 1, Failur

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680500#comment-16680500 ] Ted Yu commented on HBASE-21457: I tried to retrieve output for the failed test but it l

[jira] [Commented] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680435#comment-16680435 ] Ted Yu commented on HBASE-21457: I did a search in hbase-backup module where we retrieve

[jira] [Updated] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21457: --- Attachment: 21457.v3.txt > BackupUtils#getWALFilesOlderThan refers to wrong FileSystem > ---

[jira] [Updated] (HBASE-21457) BackupUtils#getWALFilesOlderThan refers to wrong FileSystem

2018-11-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21457: --- Attachment: (was: 21457.v3.txt) > BackupUtils#getWALFilesOlderThan refers to wrong FileSystem >

  1   2   3   4   5   6   7   8   9   10   >