[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527219#comment-16527219
]
Ted Yu commented on HBASE-20357:
AccessControlClient is marked InterfaceAudience.Public
If this goes to
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20357:
---
Fix Version/s: 3.0.0
> AccessControlClient API Enhancement
> ---
>
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527214#comment-16527214
]
Ted Yu commented on HBASE-20357:
Just committed patch v3.
Please attach addendum.
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522157#comment-16522157
]
Ted Yu edited comment on HBASE-20357 at 6/29/18 2:50 AM:
-
[~pankaj2461]
Please
[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20791:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.2.0
3.0.0
[
https://issues.apache.org/jira/browse/HBASE-20806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526233#comment-16526233
]
Ted Yu commented on HBASE-20806:
Are you targeting 1.x or 2.0 for this work ?
Thanks
> Split style
[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526058#comment-16526058
]
Ted Yu commented on HBASE-20791:
{code}
[ERROR] Failed to execute goal
[
https://issues.apache.org/jira/browse/HBASE-15320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525956#comment-16525956
]
Ted Yu commented on HBASE-15320:
For
[
https://issues.apache.org/jira/browse/HBASE-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525904#comment-16525904
]
Ted Yu commented on HBASE-6028:
---
Mohit:
You don't need to remove previous patches.
They would give
[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20791:
---
Summary: RSGroupBasedLoadBalancer#setClusterMetrics should pass
ClusterMetrics to its internalBalancer
[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525771#comment-16525771
]
Ted Yu commented on HBASE-20791:
I did a search under hbase-server/src/test/ and found the following
[
https://issues.apache.org/jira/browse/HBASE-20798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20798:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks
[
https://issues.apache.org/jira/browse/HBASE-20798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20798:
---
Summary: Duplicate thread names of StoreFileOpenerThread and
StoreFileCloserThread (was: Duplicated
[
https://issues.apache.org/jira/browse/HBASE-20798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524969#comment-16524969
]
Ted Yu commented on HBASE-20798:
{code}
560 + this.region.getRegionInfo().getEncodedName() +
[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524592#comment-16524592
]
Ted Yu commented on HBASE-20791:
[~reidchan]:
Do you have other comments w.r.t. patch v2 ?
>
[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20791:
---
Attachment: 20791-master-v2.patch
> RSGroupBasedLoadBalancer#setClusterMetrics should pass ClusterMetrics
[
https://issues.apache.org/jira/browse/HBASE-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524446#comment-16524446
]
Ted Yu commented on HBASE-6028:
---
{code}
2018-06-26 13:37:22,042 ERROR
[
https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20789:
---
Attachment: bucket-33718.out
> TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky
>
[
https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524277#comment-16524277
]
Ted Yu commented on HBASE-20789:
[
https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524186#comment-16524186
]
Ted Yu commented on HBASE-20789:
Zack:
You can get test failure from:
[
https://issues.apache.org/jira/browse/HBASE-20791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523950#comment-16523950
]
Ted Yu commented on HBASE-20791:
Can you put the patch on review board after fixing failing tests ?
>
[
https://issues.apache.org/jira/browse/HBASE-20769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522195#comment-16522195
]
Ted Yu commented on HBASE-20769:
[~openinx]:
Can you take a look as well ?
If this is good by you, can
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522157#comment-16522157
]
Ted Yu commented on HBASE-20357:
Please fill out release note.
> AccessControlClient API Enhancement
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522152#comment-16522152
]
Ted Yu commented on HBASE-20357:
+1
> AccessControlClient API Enhancement
>
[
https://issues.apache.org/jira/browse/HBASE-20769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521806#comment-16521806
]
Ted Yu commented on HBASE-20769:
lgtm
Please wrap the long line.
> getSplits() has a out of bounds
[
https://issues.apache.org/jira/browse/HBASE-20403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520778#comment-16520778
]
Ted Yu commented on HBASE-20403:
+1
> Prefetch sometimes doesn't work with encrypted file system
>
[
https://issues.apache.org/jira/browse/HBASE-20357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520764#comment-16520764
]
Ted Yu commented on HBASE-20357:
There are 3 pairs of
bq. result.getParams().addExtraParam("filterUser",
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20740:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 3.0.0
Status: Resolved (was:
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20740:
---
Release Note:
Introduce CPRequestCostFunction for StochasticLoadBalancer, which will consider
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519759#comment-16519759
]
Ted Yu commented on HBASE-20740:
Please fill out release note.
> StochasticLoadBalancer should consider
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519749#comment-16519749
]
Ted Yu commented on HBASE-20740:
Test failure doesn't seem to be related.
Can you address checkstyle
[
https://issues.apache.org/jira/browse/HBASE-20769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519720#comment-16519720
]
Ted Yu commented on HBASE-20769:
When I ran the new test without fix:
{code}
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20740:
---
Attachment: 20740-master-v2.patch
> StochasticLoadBalancer should consider CoprocessorService request
[
https://issues.apache.org/jira/browse/HBASE-20748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20748:
---
Status: Open (was: Patch Available)
> HBaseContext bulkLoad: being able to use custom versions
>
[
https://issues.apache.org/jira/browse/HBASE-20532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20532:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks
[
https://issues.apache.org/jira/browse/HBASE-20532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20532:
---
Summary: Use try-with-resources in BackupSystemTable (was: Use try
-with-resources in BackupSystemTable)
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519544#comment-16519544
]
Ted Yu edited comment on HBASE-20734 at 6/21/18 4:07 PM:
-
In
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519544#comment-16519544
]
Ted Yu commented on HBASE-20734:
In WALSplitter#finishSplitLogFile :
Path rootdir =
[
https://issues.apache.org/jira/browse/HBASE-20532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519274#comment-16519274
]
Ted Yu commented on HBASE-20532:
lgtm
Please fix checkstyle warnings
> Use try -with-resources in
[
https://issues.apache.org/jira/browse/HBASE-20631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519088#comment-16519088
]
Ted Yu commented on HBASE-20631:
Please fix checkstyle warnings.
> B: Merge command enhancements
>
[
https://issues.apache.org/jira/browse/HBASE-15320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517749#comment-16517749
]
Ted Yu commented on HBASE-15320:
Unit test encountered:
{code}
[ERROR] Caused by:
[
https://issues.apache.org/jira/browse/HBASE-20743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516642#comment-16516642
]
Ted Yu commented on HBASE-20743:
Yes.
Here is excerpt from target/rat.txt :
{code}
[
https://issues.apache.org/jira/browse/HBASE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516625#comment-16516625
]
Ted Yu commented on HBASE-20542:
When I ran the test locally with patch, I saw the following in test
[
https://issues.apache.org/jira/browse/HBASE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516172#comment-16516172
]
Ted Yu commented on HBASE-20542:
{code}
+ public void waitForUpdates() {
+
[
https://issues.apache.org/jira/browse/HBASE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516158#comment-16516158
]
Ted Yu commented on HBASE-20542:
Took a quick look.
{code}
+while(!succ) {
+ currentActive =
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515979#comment-16515979
]
Ted Yu commented on HBASE-20734:
WALSplitter is annotated @InterfaceAudience.Private
It has information
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20734:
---
Fix Version/s: 3.0.0
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515908#comment-16515908
]
Ted Yu commented on HBASE-20208:
{code}
[ERROR]
[
https://issues.apache.org/jira/browse/HBASE-20208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20208:
---
Status: Open (was: Patch Available)
> Review of SequenceIdAccounting.java
>
[
https://issues.apache.org/jira/browse/HBASE-20748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515898#comment-16515898
]
Ted Yu commented on HBASE-20748:
As Chia-ping commented on the PR, PR is not integrated with QA bot.
[
https://issues.apache.org/jira/browse/HBASE-20748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515728#comment-16515728
]
Ted Yu commented on HBASE-20748:
Please also add a unit test utilizing the enhancement.
> HBaseContext
[
https://issues.apache.org/jira/browse/HBASE-20748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515727#comment-16515727
]
Ted Yu commented on HBASE-20748:
bq. method would throw back to
I think you meant 'fall back'
Your
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 1.4.6
2.1.0
Ted Yu created HBASE-20744:
--
Summary: Address FindBugs warnings in branch-1
Key: HBASE-20744
URL: https://issues.apache.org/jira/browse/HBASE-20744
Project: HBase
Issue Type: Bug
Ted Yu created HBASE-20743:
--
Summary: ASF License warnings for branch-1
Key: HBASE-20743
URL: https://issues.apache.org/jira/browse/HBASE-20743
Project: HBase
Issue Type: Bug
Reporter:
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514642#comment-16514642
]
Ted Yu commented on HBASE-20723:
Integrated to master and branch-1 , waiting for Jenkins result before
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514641#comment-16514641
]
Ted Yu commented on HBASE-20723:
I ran TestLoadIncrementalHFiles with patch in branch-1 which passed.
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.branch-2.txt
> Custom hbase.wal.dir results in data loss because we write recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514534#comment-16514534
]
Ted Yu commented on HBASE-20723:
Patch for branch-1 adds correction to TestWALFactory in the following
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.branch-1.txt
> Custom hbase.wal.dir results in data loss because we write recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Summary: Custom hbase.wal.dir results in data loss because we write
recovered edits into a different place
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v10.txt
> Custom hbase.wal.dir results in dataloss because we write recovered edits
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514438#comment-16514438
]
Ted Yu commented on HBASE-20723:
Rohan and I did more testing in Azure cluster (with config as shown in
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20740:
---
Summary: StochasticLoadBalancer should consider Coprocessor request count
when computing cost (was:
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513667#comment-16513667
]
Ted Yu commented on HBASE-20740:
bq. only have coprocessor requests
Please describe your use case in
[
https://issues.apache.org/jira/browse/HBASE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20740:
---
Status: Patch Available (was: Open)
> StochasticLoadBalancer should consider Coprocessor request count
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Summary: WALSplitter uses the rootDir, which is walDir, as the recovered
edits root path (was: WALSplitter
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Priority: Critical (was: Major)
Component/s: (was: hbase)
wal
> WALSplitter
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513205#comment-16513205
]
Ted Yu commented on HBASE-20734:
After HBASE-17437 was incorporated into 1.4 release, the recovered
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v9.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: (was: 20723.v9.txt)
> WALSplitter uses the rootDir, which is walDir, as the tableDir root
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513150#comment-16513150
]
Ted Yu commented on HBASE-20734:
Suppose the new region server only knows about the recovered edits dir
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513139#comment-16513139
]
Ted Yu commented on HBASE-20723:
Patch v9 removed the FileSystem parameter to getRegionSplitEditsPath()
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v9.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513077#comment-16513077
]
Ted Yu commented on HBASE-20734:
Moving recovered edits dir over to under wal.dir is the obvious action
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513075#comment-16513075
]
Ted Yu commented on HBASE-20723:
Patch v8 does variable renaming w.r.t. walDir.
> WALSplitter uses the
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v8.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513062#comment-16513062
]
Ted Yu commented on HBASE-20723:
bq. some indication of the number of records replayed
The above metric
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513043#comment-16513043
]
Ted Yu commented on HBASE-20723:
Patch v7 sets wal.dir to different location than rootdir in
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v7.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513023#comment-16513023
]
Ted Yu commented on HBASE-20723:
For #2 above, we already have JMX for :
{code}
"Replay_num_ops" :
[
https://issues.apache.org/jira/browse/HBASE-20676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20676:
---
Labels: snapshot (was: )
> Give .hbase-snapshot proper ownership upon directory creation
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512931#comment-16512931
]
Ted Yu commented on HBASE-20723:
Tried out multiwal :
{code}
diff --git
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512925#comment-16512925
]
Ted Yu commented on HBASE-20723:
Josh:
See my earlier comment w.r.t. the incorrect calculation of table
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v6.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512875#comment-16512875
]
Ted Yu commented on HBASE-20723:
I ran TestZooKeeper locally with patch v5 which passed.
> WALSplitter
Ted Yu created HBASE-20734:
--
Summary: Colocate recovered edits directory with hbase.wal.dir
Key: HBASE-20734
URL: https://issues.apache.org/jira/browse/HBASE-20734
Project: HBase
Issue Type:
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v5.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512240#comment-16512240
]
Ted Yu commented on HBASE-20532:
Can you see if the checkstyle warnings are related ?
> Use try
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512239#comment-16512239
]
Ted Yu commented on HBASE-20723:
TestWALFactory passes using patch v5 where table directory is located
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v5.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512232#comment-16512232
]
Ted Yu commented on HBASE-20723:
Looking at the change from HBASE-17437 in TestWALFactory :
{code}
-
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v4.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512220#comment-16512220
]
Ted Yu commented on HBASE-20723:
It turns out that retrieving conf from FileSystem may deviate from the
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v3.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511948#comment-16511948
]
Ted Yu commented on HBASE-20727:
lgtm
nit: FlushedSequenceIdFlusher class can be private.
> Persist
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Attachment: 20723.v2.txt
> WALSplitter uses the rootDir, which is walDir, as the tableDir root path.
>
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20723:
---
Status: Patch Available (was: Open)
> WALSplitter uses the rootDir, which is walDir, as the tableDir root
[
https://issues.apache.org/jira/browse/HBASE-20729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511931#comment-16511931
]
Ted Yu commented on HBASE-20729:
lgtm
Please remove unused imports.
> B BackupLogCleaner must ignore
[
https://issues.apache.org/jira/browse/HBASE-20630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-20630:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 3.0.0
Status: Resolved (was:
1001 - 1100 of 23635 matches
Mail list logo
