[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored

2018-09-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614551#comment-16614551 ] Ted Yu commented on HBASE-21160: Ran the test with patch locally which passed. > Assert

[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored

2018-09-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614279#comment-16614279 ] Ted Yu commented on HBASE-21160: As I said above, when there is no assertion at the end

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-09-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614222#comment-16614222 ] Ted Yu commented on HBASE-20734: I wouldn't have big chunk of time to review - working o

[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored

2018-09-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613541#comment-16613541 ] Ted Yu commented on HBASE-21160: If there is no assertion in the try block where Throwab

[jira] [Created] (HBASE-21194) Add TestCopyTable which exercises MOB feature

2018-09-12 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21194: -- Summary: Add TestCopyTable which exercises MOB feature Key: HBASE-21194 URL: https://issues.apache.org/jira/browse/HBASE-21194 Project: HBase Issue Type: Test

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-09-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Attachment: (was: 21097.v3.txt) > Flush pressure assertion may fail in testFlushThroughputTuning >

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-09-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Attachment: 21097.v4.txt > Flush pressure assertion may fail in testFlushThroughputTuning > ---

[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored

2018-09-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612119#comment-16612119 ] Ted Yu commented on HBASE-21160: Since the catch block currently re-throws IOException,

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-09-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Attachment: (was: 21097.v3.txt) > Flush pressure assertion may fail in testFlushThroughputTuning >

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-09-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Attachment: 21097.v3.txt > Flush pressure assertion may fail in testFlushThroughputTuning > ---

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-09-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Attachment: 21097.v3.txt > Flush pressure assertion may fail in testFlushThroughputTuning > ---

[jira] [Commented] (HBASE-21179) Fix the number of actions in responseTooSlow log

2018-09-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610426#comment-16610426 ] Ted Yu commented on HBASE-21179: Looks good. The "actions" can be written as "action(s)"

[jira] [Updated] (HBASE-21173) Remove the duplicate HRegion#close in TestHRegion

2018-09-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21173: --- Priority: Minor (was: Major) > Remove the duplicate HRegion#close in TestHRegion >

[jira] [Commented] (HBASE-21173) Remove the duplicate HRegion#close in TestHRegion

2018-09-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609869#comment-16609869 ] Ted Yu commented on HBASE-21173: +1 > Remove the duplicate HRegion#close in TestHRegion

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2018-09-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609624#comment-16609624 ] Ted Yu commented on HBASE-20952: Thanks for helpful comments. bq. comments nor copy/pas

[jira] [Created] (HBASE-21180) findbugs incurs DataflowAnalysisException for hbase-server module

2018-09-10 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21180: -- Summary: findbugs incurs DataflowAnalysisException for hbase-server module Key: HBASE-21180 URL: https://issues.apache.org/jira/browse/HBASE-21180 Project: HBase Issue

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2018-09-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609379#comment-16609379 ] Ted Yu commented on HBASE-20952: This is the google doc : https://docs.google.com/docum

[jira] [Created] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving

2018-09-09 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21175: -- Summary: Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving Key: HBASE-21175 URL: https://issues.apache.org/jira/browse/HBASE-21175 Project: HBase

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: (was: 21150.v6.txt) > Avoid delay in first flushes due to overheads in table metrics registr

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: (was: 21150.v7.txt) > Avoid delay in first flushes due to overheads in table metrics registr

[jira] [Comment Edited] (HBASE-16458) Shorten backup / restore test execution time

2018-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608470#comment-16608470 ] Ted Yu edited comment on HBASE-16458 at 9/9/18 4:29 PM: HBASE-16

[jira] [Commented] (HBASE-16458) Shorten backup / restore test execution time

2018-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608470#comment-16608470 ] Ted Yu commented on HBASE-16458: HBASE-16458-v2.patch was the last one from Vlad. Patch

[jira] [Updated] (HBASE-16458) Shorten backup / restore test execution time

2018-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16458: --- Attachment: (was: 16458.HBASE-7912.v5.txt) > Shorten backup / restore test execution time >

[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource

2018-09-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608469#comment-16608469 ] Ted Yu commented on HBASE-21174: +1, pending QA > [REST] Failed to parse empty qualifie

[jira] [Commented] (HBASE-21052) After restoring a snapshot, table.jsp page for the table gets stuck

2018-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608191#comment-16608191 ] Ted Yu commented on HBASE-21052: lgtm Test failure was not related. > After restoring

[jira] [Commented] (HBASE-16458) Shorten backup / restore test execution time

2018-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608182#comment-16608182 ] Ted Yu commented on HBASE-16458: >From the test console, you would see: {code} 17:01:53

[jira] [Commented] (HBASE-21173) Remove the duplicate HRegion#close in TestHRegion

2018-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608119#comment-16608119 ] Ted Yu commented on HBASE-21173: {code} region.close(); assertEquals(max, regi

[jira] [Updated] (HBASE-16458) Shorten backup / restore test execution time

2018-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16458: --- Attachment: 16458.v5.txt > Shorten backup / restore test execution time > --

[jira] [Commented] (HBASE-16458) Shorten backup / restore test execution time

2018-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608029#comment-16608029 ] Ted Yu commented on HBASE-16458: 16458.v4.txt for checkstyle warnings. > Shorten backup

[jira] [Updated] (HBASE-16458) Shorten backup / restore test execution time

2018-09-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16458: --- Attachment: 16458.v4.txt > Shorten backup / restore test execution time > --

[jira] [Commented] (HBASE-16458) Shorten backup / restore test execution time

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607893#comment-16607893 ] Ted Yu commented on HBASE-16458: Vlad: Can you take a look at 16458.v2.txt ? This is ba

[jira] [Updated] (HBASE-16458) Shorten backup / restore test execution time

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16458: --- Attachment: 16458.v2.txt > Shorten backup / restore test execution time > --

[jira] [Updated] (HBASE-16458) Shorten backup / restore test execution time

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16458: --- Attachment: 16458-v1.patch > Shorten backup / restore test execution time >

[jira] [Commented] (HBASE-16458) Shorten backup / restore test execution time

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607737#comment-16607737 ] Ted Yu commented on HBASE-16458: On Linux, with patch, from first test output: {code} 20

[jira] [Updated] (HBASE-20743) ASF License warnings for branch-1

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20743: --- Description: >From >https://builds.apache.org/job/HBase%20Nightly/job/branch-1/450/artifact/output-general/

[jira] [Updated] (HBASE-16458) Shorten backup / restore test execution time

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16458: --- Status: Patch Available (was: Reopened) > Shorten backup / restore test execution time > --

[jira] [Assigned] (HBASE-16458) Shorten backup / restore test execution time

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-16458: -- Assignee: Vladimir Rodionov (was: Ted Yu) Assigning to Vlad who has done experiments. > Shorten bac

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607321#comment-16607321 ] Ted Yu commented on HBASE-21149: For TestIncrementalBackupWithBulkLoad, we can keep the

[jira] [Commented] (HBASE-21158) Empty qualifier cell is always returned when using QualifierFilter

2018-09-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607234#comment-16607234 ] Ted Yu commented on HBASE-21158: +1 > Empty qualifier cell is always returned when usin

[jira] [Updated] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21138: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.2.0 1.5.0

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606438#comment-16606438 ] Ted Yu commented on HBASE-21138: Integrated to branch-2. Feel free to re-attach branch-

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606097#comment-16606097 ] Ted Yu commented on HBASE-21138: Patch doesn't apply to branch-2: {code} error: patch fa

[jira] [Commented] (HBASE-21001) ReplicationObserver fails to load in HBase 2.0.0

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606047#comment-16606047 ] Ted Yu commented on HBASE-21001: +1 Thanks for working late. > ReplicationObserver fail

[jira] [Commented] (HBASE-21001) ReplicationObserver fails to load in HBase 2.0.0

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606030#comment-16606030 ] Ted Yu commented on HBASE-21001: {code} 8686(plugins == "" ? "" : (plugi

[jira] [Commented] (HBASE-21001) ReplicationObserver fails to load in HBase 2.0.0

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605907#comment-16605907 ] Ted Yu commented on HBASE-21001: Looks good overall. {code} + if (!plugins.contains

[jira] [Resolved] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-21129. Resolution: Fixed > Clean up duplicate codes in #equals and #hashCode methods of Filter >

[jira] [Updated] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21129: --- Attachment: 21129.addendum > Clean up duplicate codes in #equals and #hashCode methods of Filter > -

[jira] [Created] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored

2018-09-06 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21160: -- Summary: Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored Key: HBASE-21160 URL: https://issues.apache.org/jira/browse/HBASE-21160

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605627#comment-16605627 ] Ted Yu commented on HBASE-21098: Please fix test failure. {code} Caused by: java.lang.Il

[jira] [Updated] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-09-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20917: --- Fix Version/s: (was: 2.0.2) > MetaTableMetrics#stop references uninitialized requestsMap for non-meta re

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605079#comment-16605079 ] Ted Yu commented on HBASE-21138: Planning to commit v3 tomorrow morning, if QA comes bac

[jira] [Commented] (HBASE-20578) Support region server group in target cluster

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605078#comment-16605078 ] Ted Yu commented on HBASE-20578: Ping [~albertlee...@gmail.com] > Support region server

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605012#comment-16605012 ] Ted Yu commented on HBASE-21138: Thanks for the new patch. Can you take a look at http

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604688#comment-16604688 ] Ted Yu commented on HBASE-21138: For TestHRegion#testGet_FamilyChecker, I think you inte

[jira] [Comment Edited] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604628#comment-16604628 ] Ted Yu edited comment on HBASE-21150 at 9/5/18 5:08 PM: bq. Wher

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604667#comment-16604667 ] Ted Yu commented on HBASE-20952: Updated description section of https://reviews.apache.o

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Resolution: Won't Fix Assignee: (was: Ted Yu) Fix Version/s: (was: 2.2.0)

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604628#comment-16604628 ] Ted Yu commented on HBASE-21150: bq. Where is evidence that the patch makes improvement?

[jira] [Comment Edited] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604443#comment-16604443 ] Ted Yu edited comment on HBASE-21150 at 9/5/18 4:07 PM: In patch

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v7.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604443#comment-16604443 ] Ted Yu commented on HBASE-21150: bq. do not like the ugly code. Can you tell me which p

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604409#comment-16604409 ] Ted Yu commented on HBASE-21150: I read the javadoc for {{submit}}: {code} * Submit

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604395#comment-16604395 ] Ted Yu commented on HBASE-21150: Looking at the javadoc for {{execute}}: {code} * E

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v6.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604373#comment-16604373 ] Ted Yu commented on HBASE-21150: In patch v5, I dropped the register() method from Metri

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v5.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604339#comment-16604339 ] Ted Yu commented on HBASE-21150: MetricsTableAggregateSource is marked Private. Adding t

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604116#comment-16604116 ] Ted Yu commented on HBASE-21150: I ran TestFromClientSide locally 3 times, TestFromClien

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v4.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604100#comment-16604100 ] Ted Yu commented on HBASE-21150: >From >https://builds.apache.org/job/PreCommit-HBASE-B

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Issue Type: Bug (was: Improvement) > Avoid delay in first flushes due to overheads in table metrics registr

[jira] [Commented] (HBASE-21140) Backport 'HBASE-21136 NPE in MetricsTableSourceImpl.updateFlushTime' to branch-1

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603836#comment-16603836 ] Ted Yu commented on HBASE-21140: bq. plus fixes from Ted Yu in HBASE-21150 When integr

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Fix Version/s: 2.2.0 3.0.0 Status: Patch Available (was: Reopened) > Avoid de

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v4.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Description: After HBASE-15728 is integrated, the lazy table metrics registration results in penalty for th

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603790#comment-16603790 ] Ted Yu commented on HBASE-21150: TestReplicationKillSlaveRSWithSeparateOldWALs passed lo

[jira] [Reopened] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reopened HBASE-21150: I didn't open this issue for backporting. HBASE-15728 is still in master and the delay in first flushes is s

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603782#comment-16603782 ] Ted Yu commented on HBASE-21150: bq. you use a thread pool to execute the registration

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v3.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v2.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: (was: 21150.v2.txt) > Avoid delay in first flushes due to overheads in table metrics registr

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v2.txt > Avoid delay in first flushes due to overheads in table metrics registration > ---

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603490#comment-16603490 ] Ted Yu commented on HBASE-21150: computeIfAbsent is not needed. See how my patch achieve

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to overheads in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603403#comment-16603403 ] Ted Yu commented on HBASE-21150: ConcurrentHashMap doesn't give us benefit in this case:

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to contention in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Status: Patch Available (was: Open) > Avoid delay in first flushes due to contention in table metrics regis

[jira] [Commented] (HBASE-21150) Avoid delay in first flushes due to contention in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603243#comment-16603243 ] Ted Yu commented on HBASE-21150: [~xucang] [~andrew.purt...@gmail.com]: Can you take a l

[jira] [Updated] (HBASE-21150) Avoid delay in first flushes due to contention in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21150: --- Attachment: 21150.v1.txt > Avoid delay in first flushes due to contention in table metrics registration > --

[jira] [Created] (HBASE-21150) Avoid delay in first flushes due to contention in table metrics registration

2018-09-04 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21150: -- Summary: Avoid delay in first flushes due to contention in table metrics registration Key: HBASE-21150 URL: https://issues.apache.org/jira/browse/HBASE-21150 Project: HBase

[jira] [Created] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-09-04 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21149: -- Summary: TestIncrementalBackupWithBulkLoad may fail due to file copy failure Key: HBASE-21149 URL: https://issues.apache.org/jira/browse/HBASE-21149 Project: HBase Issu

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-09-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602561#comment-16602561 ] Ted Yu commented on HBASE-21129: Failed test doesn't involve Filter. Go ahead with comm

[jira] [Updated] (HBASE-20952) Re-visit the WAL API

2018-09-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20952: --- Attachment: 20952.v1.txt > Re-visit the WAL API > > > Key: HBASE-20952

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2018-09-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602414#comment-16602414 ] Ted Yu commented on HBASE-20952: The mega patch would be the aggregate diff for all the

[jira] [Commented] (HBASE-21139) Concurrent invocations of MetricsTableAggregateSourceImpl.getOrCreateTableSource may return unregistered MetricsTableSource

2018-09-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602156#comment-16602156 ] Ted Yu commented on HBASE-21139: The lazy table metrics registration results in penalty

[jira] [Commented] (HBASE-20892) [UI] Start / End keys are empty on table.jsp

2018-09-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601765#comment-16601765 ] Ted Yu commented on HBASE-20892: lgtm > [UI] Start / End keys are empty on table.jsp >

[jira] [Created] (HBASE-21141) Enable MOB in backup / restore test involving incremental backup

2018-09-02 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21141: -- Summary: Enable MOB in backup / restore test involving incremental backup Key: HBASE-21141 URL: https://issues.apache.org/jira/browse/HBASE-21141 Project: HBase Issue T

[jira] [Created] (HBASE-21139) Concurrent invocations of MetricsTableAggregateSourceImpl.getOrCreateTableSource may return unregistered MetricsTableSource

2018-09-01 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21139: -- Summary: Concurrent invocations of MetricsTableAggregateSourceImpl.getOrCreateTableSource may return unregistered MetricsTableSource Key: HBASE-21139 URL: https://issues.apache.org/jira/brow

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599529#comment-16599529 ] Ted Yu commented on HBASE-21138: Agree with the plan. > Close HRegion instance at the e

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-08-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599350#comment-16599350 ] Ted Yu commented on HBASE-20734: I would go over the latest patch once more. It would b

[jira] [Commented] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599346#comment-16599346 ] Ted Yu commented on HBASE-21138: {code} 254 LOG.error("Error in closing region

[jira] [Created] (HBASE-21138) Close HRegion instance at the end of every test in TestHRegion

2018-08-31 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21138: -- Summary: Close HRegion instance at the end of every test in TestHRegion Key: HBASE-21138 URL: https://issues.apache.org/jira/browse/HBASE-21138 Project: HBase Issue Typ

<    1   2   3   4   5   6   7   8   9   10   >