[jira] [Commented] (HBASE-21052) After restoring a snapshot, table.jsp page for the table gets stuck

2018-08-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598804#comment-16598804 ] Ted Yu commented on HBASE-21052: Yes. Specify a relatively short timeout. Thanks > After restoring a

[jira] [Commented] (HBASE-21132) return wrong result in rest multiget

2018-08-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598536#comment-16598536 ] Ted Yu commented on HBASE-21132: +1 > return wrong result in rest multiget >

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-08-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598498#comment-16598498 ] Ted Yu commented on HBASE-21129: Test failures were not related. After addressing FindBugs warning,

[jira] [Commented] (HBASE-21052) After restoring a snapshot, table.jsp page for the table gets stuck

2018-08-31 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598455#comment-16598455 ] Ted Yu commented on HBASE-21052: For the new test, can you add assertion for how quickly

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-08-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598152#comment-16598152 ] Ted Yu commented on HBASE-21129: QA is back. Triggered a QA run. > Clean up duplicate codes in #equals

[jira] [Commented] (HBASE-21132) return wrong result in rest multiget

2018-08-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597464#comment-16597464 ] Ted Yu commented on HBASE-21132: lgtm > return wrong result in rest multiget >

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-08-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596634#comment-16596634 ] Ted Yu commented on HBASE-21129: Thanks for the quick turn around. lgtm, pending QA. > Clean up

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-08-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596620#comment-16596620 ] Ted Yu commented on HBASE-21129: For FirstKeyOnlyFilter, can you use foundKV ? I don't have suggestion

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

2018-08-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596463#comment-16596463 ] Ted Yu commented on HBASE-21129: For FamilyFilter.java, hashCode is dropped. This is because we are

[jira] [Resolved] (HBASE-14783) Proc-V2: Master aborts when downgrading from 1.3 to 1.1

2018-08-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-14783. Resolution: Later > Proc-V2: Master aborts when downgrading from 1.3 to 1.1 >

[jira] [Resolved] (HBASE-14716) Detection of orphaned table znode should cover table in Enabled state

2018-08-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved HBASE-14716. Resolution: Later > Detection of orphaned table znode should cover table in Enabled state >

[jira] [Comment Edited] (HBASE-21122) bulkload multi-version Cell supported in hbase-spark module

2018-08-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595329#comment-16595329 ] Ted Yu edited comment on HBASE-21122 at 8/28/18 5:19 PM: - I tried to run the

[jira] [Commented] (HBASE-21122) bulkload multi-version Cell supported in hbase-spark module

2018-08-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595329#comment-16595329 ] Ted Yu commented on HBASE-21122: I tried to run the added test alone: {code} [ERROR]

[jira] [Commented] (HBASE-21122) bulkload multi-version Cell supported in hbase-spark module

2018-08-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594453#comment-16594453 ] Ted Yu commented on HBASE-21122: Can you take a look at other tests under the same directory, such as:

[jira] [Commented] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594377#comment-16594377 ] Ted Yu commented on HBASE-21088: I would think those two branches should have this fix. > HStoreFile

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-08-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594333#comment-16594333 ] Ted Yu commented on HBASE-20734: Took a quick look at patch v6. {code} + public HRegionFileSystem

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.2.0 3.0.0

[jira] [Commented] (HBASE-21122) bulkload multi-version Cell supported in hbase-spark module

2018-08-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593740#comment-16593740 ] Ted Yu commented on HBASE-21122: Is it possible to add a test that verifies the added support ? >

[jira] [Commented] (HBASE-15410) Utilize the max seek value when all Filters in MUST_PASS_ALL FilterList return SEEK_NEXT_USING_HINT

2018-08-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592759#comment-16592759 ] Ted Yu commented on HBASE-15410: It seems the following two fields of FilterListBase: {code} protected

[jira] [Commented] (HBASE-15410) Utilize the max seek value when all Filters in MUST_PASS_ALL FilterList return SEEK_NEXT_USING_HINT

2018-08-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592754#comment-16592754 ] Ted Yu commented on HBASE-15410: Now that HBASE-19008 has been integrated, I wonder whether we can

[jira] [Updated] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21098: --- Release Note: It is recommended to place the working directory on-cluster on HDFS as doing so has shown a

[jira] [Commented] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591726#comment-16591726 ] Ted Yu commented on HBASE-21097: Ran the test with different memory settings: {code} 1979 mt

[jira] [Commented] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591720#comment-16591720 ] Ted Yu commented on HBASE-21097: Looks like using epsilon to judge how close the flush pressure would be

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Attachment: 21097.v2.txt > Flush pressure assertion may fail in testFlushThroughputTuning >

[jira] [Commented] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591426#comment-16591426 ] Ted Yu commented on HBASE-21097: Interesting. >From

[jira] [Commented] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591156#comment-16591156 ] Ted Yu commented on HBASE-20993: I tried running TestInsecureIPC in master branch but got compilation

[jira] [Commented] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591152#comment-16591152 ] Ted Yu commented on HBASE-20993: Looks good overall. For BlockingRpcConnection : {code} +

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591047#comment-16591047 ] Ted Yu commented on HBASE-21098: Can you put the above response in release note ? Please also look at

[jira] [Commented] (HBASE-21098) Improve Snapshot Performance with Temporary Snapshot Directory when rootDir on S3

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590904#comment-16590904 ] Ted Yu commented on HBASE-21098: {code} public static final String SNAPSHOT_WORKING_DIR =

[jira] [Commented] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590747#comment-16590747 ] Ted Yu commented on HBASE-21097: Thanks for checking. > Flush pressure assertion may fail in

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Resolution: Fixed Assignee: Ted Yu Hadoop Flags: Reviewed Fix Version/s: 2.2.0

[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590475#comment-16590475 ] Ted Yu edited comment on HBASE-19008 at 8/23/18 4:32 PM: - Reid: You can drop the

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590475#comment-16590475 ] Ted Yu commented on HBASE-19008: Reid: You can drop the changes to 19008-21.patch in patch v21 and apply

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Priority: Major (was: Minor) > Flush pressure assertion may fail in testFlushThroughputTuning >

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590414#comment-16590414 ] Ted Yu commented on HBASE-19008: TestFlushWithThroughputController is being handled in HBASE-21097 .

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Status: Patch Available (was: Open) > Flush pressure assertion may fail in testFlushThroughputTuning >

[jira] [Updated] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21097: --- Attachment: 21097.v1.txt > Flush pressure assertion may fail in testFlushThroughputTuning >

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589630#comment-16589630 ] Ted Yu commented on HBASE-19008: See:

[jira] [Commented] (HBASE-20942) Make RpcServer trace log length configurable

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589592#comment-16589592 ] Ted Yu commented on HBASE-20942: Krish: You can upload patch now. > Make RpcServer trace log length

[jira] [Assigned] (HBASE-20942) Make RpcServer trace log length configurable

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-20942: -- Assignee: Krish Dey > Make RpcServer trace log length configurable >

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589400#comment-16589400 ] Ted Yu commented on HBASE-19008: Reid: Please go ahead with merge. > Add missing equals or hashCode

[jira] [Created] (HBASE-21097) Flush pressure assertion may fail in testFlushThroughputTuning

2018-08-22 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21097: -- Summary: Flush pressure assertion may fail in testFlushThroughputTuning Key: HBASE-21097 URL: https://issues.apache.org/jira/browse/HBASE-21097 Project: HBase Issue

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Attachment: 21088.v4.txt > HStoreFile should be closed in HStore#hasReferences >

[jira] [Commented] (HBASE-21084) When cloning a snapshot including a split parent region, the split parent region of the cloned table will be online

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589092#comment-16589092 ] Ted Yu commented on HBASE-21084: lgtm > When cloning a snapshot including a split parent region, the

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Attachment: 21088.v3.txt > HStoreFile should be closed in HStore#hasReferences >

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588891#comment-16588891 ] Ted Yu commented on HBASE-19008: Test failures were not related to the patch. > Add missing equals or

[jira] [Commented] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1650#comment-1650 ] Ted Yu commented on HBASE-21088: As I explained at the end of this comment:

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Attachment: 21088.v2.txt > HStoreFile should be closed in HStore#hasReferences >

[jira] [Commented] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588290#comment-16588290 ] Ted Yu commented on HBASE-21088: The procedure test failures were not related to the patch. I ran

[jira] [Updated] (HBASE-20666) Unsuccessful table creation leaves entry in hbase:rsgroup table

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20666: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.2.0 3.0.0

[jira] [Updated] (HBASE-20666) Unsuccessful table creation leaves entry in hbase:rsgroup table

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20666: --- Summary: Unsuccessful table creation leaves entry in hbase:rsgroup table (was: Unsuccessful table creation

[jira] [Commented] (HBASE-20666) Unsuccessful table creation leaves entry in hbase:rsgroup table

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588204#comment-16588204 ] Ted Yu commented on HBASE-20666: +1 on v4. > Unsuccessful table creation leaves entry in hbase:rsgroup

[jira] [Commented] (HBASE-21071) HBaseTestingUtility::startMiniCluster() to use builder pattern

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588190#comment-16588190 ] Ted Yu commented on HBASE-21071: HBaseTestingUtility is annotated @InterfaceAudience.Public . Shouldn't

[jira] [Updated] (HBASE-21077) MR job launched by hbase incremental backup command failed with FileNotFoundException

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21077: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Updated] (HBASE-21077) MR job launched by hbase incremental backup command failed with FileNotFoundException

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21077: --- Reporter: Romil Choksi (was: Vladimir Rodionov) > MR job launched by hbase incremental backup command

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Attachment: 21088.v2.txt > HStoreFile should be closed in HStore#hasReferences >

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Description: {code} reloadedStoreFiles = loadStoreFiles(); return

[jira] [Commented] (HBASE-21077) MR job launched by hbase incremental backup command failed with FileNotFoundException

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587992#comment-16587992 ] Ted Yu commented on HBASE-21077: The comment doesn't seem to match the actual TTL value: {code} +//

[jira] [Commented] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587986#comment-16587986 ] Ted Yu commented on HBASE-21088: bq. Where did this issue come from? A bug found in a deploy? A debug

[jira] [Assigned] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-20968: -- Assignee: (was: Ted Yu) > list_procedures_test fails due to no matching regex >

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587900#comment-16587900 ] Ted Yu commented on HBASE-20968: I am looking at:

[jira] [Commented] (HBASE-20666) Unsuccessful table creation leaves entry in rsgroup meta table

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587896#comment-16587896 ] Ted Yu commented on HBASE-20666: For #1, I see that you have an assertion in finally block which is

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587864#comment-16587864 ] Ted Yu commented on HBASE-20968: Earlier, I had a copy of test output showing what the test script looks

[jira] [Commented] (HBASE-21076) TestTableResource fails with NPE

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587817#comment-16587817 ] Ted Yu commented on HBASE-21076: Patch for master looks good me. Thanks for working on this, Sean. >

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Attachment: 21088.v1.txt > HStoreFile should be closed in HStore#hasReferences >

[jira] [Updated] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21088: --- Status: Patch Available (was: Open) > HStoreFile should be closed in HStore#hasReferences >

[jira] [Created] (HBASE-21088) HStoreFile should be closed in HStore#hasReferences

2018-08-21 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21088: -- Summary: HStoreFile should be closed in HStore#hasReferences Key: HBASE-21088 URL: https://issues.apache.org/jira/browse/HBASE-21088 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-21084) When cloning a snapshot including a split parent region, the split parent region of the cloned table will be online

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587620#comment-16587620 ] Ted Yu commented on HBASE-21084: For the test, {code} admin.catalogJanitorSwitch(true); {code} Can

[jira] [Commented] (HBASE-20666) Unsuccessful table creation leaves entry in rsgroup meta table

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587476#comment-16587476 ] Ted Yu commented on HBASE-20666: {code} 548 public void

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587121#comment-16587121 ] Ted Yu commented on HBASE-19008: TestMergeTableRegionsProcedure is not related to Filter. > Add missing

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586853#comment-16586853 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you help Liubang out ? > Add missing equals or

[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586528#comment-16586528 ] Ted Yu commented on HBASE-20917: Looks like HBASE-19722 had wrong fix version. Waiting for Andrew's

[jira] [Commented] (HBASE-19722) Meta query statistics metrics source

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586522#comment-16586522 ] Ted Yu commented on HBASE-19722: Fix versions include 2.1.0 But I don't see relevant file in branch-2.1

[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586494#comment-16586494 ] Ted Yu commented on HBASE-20917: Just found out that HBASE-19722 wasn't in branch-2.1 - I cannot find

[jira] [Updated] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20917: --- Fix Version/s: (was: 2.1.1) > MetaTableMetrics#stop references uninitialized requestsMap for non-meta

[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586485#comment-16586485 ] Ted Yu commented on HBASE-20917: bq. is there anything to stop requestsMap being set to null after the

[jira] [Commented] (HBASE-21077) MR job launched by hbase incremental backup command failed with FileNotFoundException

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586478#comment-16586478 ] Ted Yu commented on HBASE-21077: We should have a unit test where BackupLogCleaner would remove certain

[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586469#comment-16586469 ] Ted Yu commented on HBASE-20917: bq. Should this be in 2.1 and 2.0 branches? I think so. >

[jira] [Updated] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20917: --- Fix Version/s: 3.0.0 > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region >

[jira] [Commented] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586466#comment-16586466 ] Ted Yu commented on HBASE-20968: bq. Dupe of HBASE-21043 Since the test was not fixed there, I think

[jira] [Commented] (HBASE-21077) MR job launched by hbase incremental backup command failed with FileNotFoundException

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586402#comment-16586402 ] Ted Yu commented on HBASE-21077: The change doesn't seem to compile. Can you double check ? Also

[jira] [Comment Edited] (HBASE-20968) list_procedures_test fails due to no matching regex

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579173#comment-16579173 ] Ted Yu edited comment on HBASE-20968 at 8/20/18 3:49 PM: - Verified locally

[jira] [Created] (HBASE-21076) TestTableResource fails with NPE

2018-08-20 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21076: -- Summary: TestTableResource fails with NPE Key: HBASE-21076 URL: https://issues.apache.org/jira/browse/HBASE-21076 Project: HBase Issue Type: Test Reporter:

[jira] [Updated] (HBASE-20666) Unsuccessful table creation leaves entry in rsgroup meta table

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20666: --- Status: Patch Available (was: Open) > Unsuccessful table creation leaves entry in rsgroup meta table >

[jira] [Commented] (HBASE-20666) Unsuccessful table creation leaves entry in rsgroup meta table

2018-08-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585625#comment-16585625 ] Ted Yu commented on HBASE-20666: Is it possible to add a test case ? Thanks > Unsuccessful table

[jira] [Commented] (HBASE-20690) Moving table to target rsgroup needs to handle TableStateNotFoundException

2018-08-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585361#comment-16585361 ] Ted Yu commented on HBASE-20690: In TableStateManager, I only found one place where

[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region

2018-08-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585014#comment-16585014 ] Ted Yu commented on HBASE-20917: Ping [~xucang] > MetaTableMetrics#stop references uninitialized

[jira] [Updated] (HBASE-21042) processor.getRowsToLock() always assumes there is some row being locked in HRegion#processRowsWithLocks

2018-08-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21042: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks

[jira] [Commented] (HBASE-21071) HBaseTestingUtility::startMiniCluster() to use builder pattern

2018-08-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584511#comment-16584511 ] Ted Yu commented on HBASE-21071: Overall, I like this initiative. It seems the Builder can be a class

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584187#comment-16584187 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you take another look ? > Add missing equals or

[jira] [Updated] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

2018-08-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20734: --- Status: Patch Available (was: Open) > Colocate recovered edits directory with hbase.wal.dir >

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582932#comment-16582932 ] Ted Yu commented on HBASE-19008: Failure in TestZKSecretWatcher was not related to the patch. > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582360#comment-16582360 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you take another look ? > Add missing equals or

[jira] [Commented] (HBASE-21062) WALFactory has misleading notion of "default"

2018-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581681#comment-16581681 ] Ted Yu commented on HBASE-21062: lgtm {code} + // we can't us it, we want to fall back to FSHLog

[jira] [Commented] (HBASE-21033) Separate the StoreHeap from StoreFileHeap

2018-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581661#comment-16581661 ] Ted Yu commented on HBASE-21033: I looked at 21033-branch-1-minimal.txt and think it makes sense.

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581561#comment-16581561 ] Ted Yu commented on HBASE-19008: Please refer to

[jira] [Updated] (HBASE-20676) Give .hbase-snapshot proper ownership upon directory creation

2018-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20676: --- Labels: security snapshot (was: snapshot) > Give .hbase-snapshot proper ownership upon directory creation

[jira] [Updated] (HBASE-20892) [UI] Start / End keys are empty on table.jsp

2018-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-20892: --- Labels: web-ui (was: ) > [UI] Start / End keys are empty on table.jsp >

[jira] [Updated] (HBASE-21040) Replace call to printStackTrace() with proper logger call

2018-08-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21040: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

2018-08-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580243#comment-16580243 ] Ted Yu commented on HBASE-19008: Please address checkstyle warnings in hbase-spark module: {code}

<    2   3   4   5   6   7   8   9   10   11   >