[jira] [Commented] (HBASE-21279) Split TestAdminShell into several tests

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652387#comment-16652387 ] Ted Yu commented on HBASE-21279: {code} +module Hbase + class AdminHelpersTest < Test::Unit::TestCase +

[jira] [Commented] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652319#comment-16652319 ] Ted Yu commented on HBASE-21285: {code} +public TableDescriptor getTableDescriptor() { + return

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652171#comment-16652171 ] Ted Yu commented on HBASE-21149: Added more DEBUG log: {code} 2018-10-16 17:59:05,032 DEBUG

[jira] [Updated] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21149: --- Status: Open (was: Patch Available) > TestIncrementalBackupWithBulkLoad may fail due to file copy failure

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651982#comment-16651982 ] Ted Yu commented on HBASE-21246: See if I understand Josh's proposal correctly. Under Josh's proposal,

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651961#comment-16651961 ] Ted Yu commented on HBASE-21149: Ran the test against hadoop 3.0.1 and got the same error: {code}

[jira] [Commented] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651954#comment-16651954 ] Ted Yu commented on HBASE-21285: Some tests are flaky - they pass when the machine is lightly loaded.

[jira] [Commented] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651941#comment-16651941 ] Ted Yu commented on HBASE-21285: Lavinia: Can you attach patch for master branch ? Thanks > Enhanced

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651020#comment-16651020 ] Ted Yu commented on HBASE-21149: See my comment above:

[jira] [Comment Edited] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649606#comment-16649606 ] Ted Yu edited comment on HBASE-21149 at 10/16/18 1:11 AM: -- For hadoop 3.1, when

[jira] [Assigned] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-21149: -- Assignee: Ted Yu (was: Vladimir Rodionov) > TestIncrementalBackupWithBulkLoad may fail due to file

[jira] [Updated] (HBASE-21238) MapReduceHFileSplitterJob#run shouldn't call System.exit

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21238: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-21238) MapReduceHFileSplitterJob#run shouldn't call System.exit

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650649#comment-16650649 ] Ted Yu commented on HBASE-21238: lgtm, pending QA > MapReduceHFileSplitterJob#run shouldn't call

[jira] [Updated] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21149: --- Fix Version/s: 3.0.0 Status: Patch Available (was: Open) > TestIncrementalBackupWithBulkLoad

[jira] [Commented] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650362#comment-16650362 ] Ted Yu commented on HBASE-21247: [~busbey]: Can you take a look at patch v8 ? > Custom WAL Provider

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650327#comment-16650327 ] Ted Yu commented on HBASE-21149: bq. kicked off distcp while some of the source files were being

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650324#comment-16650324 ] Ted Yu commented on HBASE-21149: I tried to plugin custom OutputFormat : {code} +@Override +

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649617#comment-16649617 ] Ted Yu commented on HBASE-21149: Patch v2 breaks multiple source files into multiple activations of

[jira] [Updated] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21149: --- Attachment: 21149.v2.txt > TestIncrementalBackupWithBulkLoad may fail due to file copy failure >

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649606#comment-16649606 ] Ted Yu commented on HBASE-21149: CopyCommitter#concatFileChunks would throw the following exception when

[jira] [Comment Edited] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642620#comment-16642620 ] Ted Yu edited comment on HBASE-21149 at 10/15/18 12:51 AM: --- It seems the

[jira] [Comment Edited] (HBASE-21281) Update bouncycastle dependency.

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648708#comment-16648708 ] Ted Yu edited comment on HBASE-21281 at 10/14/18 9:18 PM: -- The following

[jira] [Commented] (HBASE-21281) Update bouncycastle dependency.

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649535#comment-16649535 ] Ted Yu commented on HBASE-21281: Updated problem description above. > Update bouncycastle dependency. >

[jira] [Commented] (HBASE-21312) ReplicationSource should log the incorrect peerClusterId at Error level instead of Info

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649390#comment-16649390 ] Ted Yu commented on HBASE-21312: {code} 407 tearDownAfterClass(); {code} Why is the method

[jira] [Commented] (HBASE-13468) hbase.zookeeper.quorum supports ipv6 address

2018-10-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649342#comment-16649342 ] Ted Yu commented on HBASE-13468: Option A seems to be better. > hbase.zookeeper.quorum supports ipv6

[jira] [Commented] (HBASE-21281) Update bouncycastle dependency.

2018-10-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648925#comment-16648925 ] Ted Yu commented on HBASE-21281: TestSaslFanOutOneBlockAsyncDFSOutput passed during QA run:

[jira] [Updated] (HBASE-21281) Update bouncycastle dependency.

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21281: --- Attachment: 21281.addendum.patch > Update bouncycastle dependency. > --- > >

[jira] [Updated] (HBASE-21281) Update bouncycastle dependency.

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21281: --- Status: Patch Available (was: Reopened) I ran TestDelegationTokenWithEncryption with addendum against both

[jira] [Commented] (HBASE-21281) Update bouncycastle dependency.

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648708#comment-16648708 ] Ted Yu commented on HBASE-21281: The following dependency tree output shows that old bouncycastle

[jira] [Commented] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648501#comment-16648501 ] Ted Yu commented on HBASE-21285: I applied 21285.branch-1.4.003.patch on branch-1 but didn't reproduce

[jira] [Commented] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648488#comment-16648488 ] Ted Yu commented on HBASE-21285: Please check the following test error: {code} [ERROR]

[jira] [Assigned] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-21285: -- Assignee: Lavinia-Stefania Sirbu > Enhanced TableSnapshotInputFormat to allow a size based splitting

[jira] [Assigned] (HBASE-21286) Parallelize computeHDFSBlocksDistribution when getting splits of a HBaseSnapshot

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-21286: -- Assignee: Lavinia-Stefania Sirbu > Parallelize computeHDFSBlocksDistribution when getting splits of

[jira] [Commented] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648372#comment-16648372 ] Ted Yu commented on HBASE-21247: See if patch v8 is better. Class retrieval from ordinary WAL provider

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Attachment: 21247.v8.txt > Custom WAL Provider cannot be specified by configuration whose value is >

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Attachment: 21247.v7.txt > Custom WAL Provider cannot be specified by configuration whose value is >

[jira] [Updated] (HBASE-21178) [BC break] : Get and Scan operation with a custom converter_class not working

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21178: --- Resolution: Fixed Fix Version/s: 2.2.0 3.0.0 Status: Resolved (was:

[jira] [Commented] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647993#comment-16647993 ] Ted Yu commented on HBASE-21247: bq. in v6 you still have two different places that try to load by

[jira] [Commented] (HBASE-21281) Update bouncycastle dependency.

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647924#comment-16647924 ] Ted Yu commented on HBASE-21281: Looks like there is some more work to be done for hadoop3 build:

[jira] [Commented] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647910#comment-16647910 ] Ted Yu commented on HBASE-21247: The test failures for patch v6 were not related to the patch. {code}

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Attachment: (was: 21247.v6.txt) > Custom WAL Provider cannot be specified by configuration whose value

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Attachment: 21247.v6.txt > Custom WAL Provider cannot be specified by configuration whose value is >

[jira] [Commented] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647351#comment-16647351 ] Ted Yu commented on HBASE-21247: For meta WAL provider, if the user wants to use the same one for

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Attachment: 21247.v6.txt > Custom WAL Provider cannot be specified by configuration whose value is >

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Status: Patch Available (was: Reopened) > Custom WAL Provider cannot be specified by configuration whose

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Attachment: 21247.v5.txt > Custom WAL Provider cannot be specified by configuration whose value is >

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Description: Currently all the WAL Providers acceptable to hbase are specified in Providers enum of

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Summary: Custom WAL Provider cannot be specified by configuration whose value is outside the enums in

[jira] [Updated] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Release Note: (was: Two config parameters, hbase.wal.provider.class and hbase.wal.meta_provider.class are

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646794#comment-16646794 ] Ted Yu commented on HBASE-21246: bq. are there places aside from replication (where we put a wal into

[jira] [Commented] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646788#comment-16646788 ] Ted Yu commented on HBASE-21247: Stepping thru the code a few times, I kept coming to the code in

[jira] [Commented] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646773#comment-16646773 ] Ted Yu commented on HBASE-21247: I tried another way of initializing WALFactory : {code} final

[jira] [Commented] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646724#comment-16646724 ] Ted Yu commented on HBASE-21247: [~busbey]: Please take a look at the attached 21247.v4.tst Running

[jira] [Updated] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Attachment: 21247.v4.tst > Allow WAL Provider to be specified by configuration without explicit enum in >

[jira] [Commented] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646681#comment-16646681 ] Ted Yu commented on HBASE-21247: Reverted to allow time for more discussion. > Allow WAL Provider to be

[jira] [Commented] (HBASE-20140) HRegion FileSystem should be instantiated from hbase rootDir not default

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646647#comment-16646647 ] Ted Yu commented on HBASE-20140: Is it possible to add a unit test ? > HRegion FileSystem should be

[jira] [Commented] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646466#comment-16646466 ] Ted Yu commented on HBASE-21247: We are aware of the above (existing) config. However, it is an enum.

[jira] [Commented] (HBASE-21292) IdLock.getLockEntry() may hang if interrupted

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646408#comment-16646408 ] Ted Yu commented on HBASE-21292: Good catch. For the second hunk, would it be more readable if the

[jira] [Commented] (HBASE-20140) HRegion FileSystem should be instantiated from hbase rootDir not default

2018-10-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646397#comment-16646397 ] Ted Yu commented on HBASE-20140: Can you get another qa run ? The previous result was not accessible.

[jira] [Commented] (HBASE-21281) Update bouncycastle dependency.

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645747#comment-16645747 ] Ted Yu commented on HBASE-21281: lgtm > Update bouncycastle dependency. >

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.HBASE-20952.005.patch > Introduce WALIdentity interface > ---

[jira] [Updated] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21247: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645443#comment-16645443 ] Ted Yu commented on HBASE-21246: I ran TestMasterFailoverWithProcedures with patch locally which passed.

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.HBASE-20952.004.patch > Introduce WALIdentity interface > ---

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645355#comment-16645355 ] Ted Yu commented on HBASE-21246: bq. Why isn't this a WALProvider method? The start time of a WAL is

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.003.patch > Introduce WALIdentity interface > --- > >

[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.HBASE-20952.002.patch > Introduce WALIdentity interface > ---

[jira] [Comment Edited] (HBASE-21246) Introduce WALIdentity interface

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638994#comment-16638994 ] Ted Yu edited comment on HBASE-21246 at 10/10/18 3:56 PM: -- The first question

[jira] [Commented] (HBASE-21286) Parallelize computeHDFSBlocksDistribution when getting splits of a HBaseSnapshot

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645162#comment-16645162 ] Ted Yu commented on HBASE-21286: Where is the ExecutorService shutdown ? {code} 432

[jira] [Commented] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645138#comment-16645138 ] Ted Yu commented on HBASE-21285: In TableSnapshotInputFormatImpl#getRegionSizes, snapshot visitor may

[jira] [Commented] (HBASE-21247) Allow WAL Provider to be specified by configuration without explicit enum in Providers

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645099#comment-16645099 ] Ted Yu commented on HBASE-21247: If there is no further review comment, I plan to integrate this. >

[jira] [Commented] (HBASE-21285) Enhanced TableSnapshotInputFormat to allow a size based splitting

2018-10-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644985#comment-16644985 ] Ted Yu commented on HBASE-21285: Have you measured the duration for the {{getRegionSizes}} method on the

[jira] [Commented] (HBASE-21283) Add new shell command 'rit' for listing regions in transition

2018-10-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644244#comment-16644244 ] Ted Yu commented on HBASE-21283: +1 > Add new shell command 'rit' for listing regions in transition >

[jira] [Commented] (HBASE-21283) Add new shell command 'rit' for listing regions in transition

2018-10-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644225#comment-16644225 ] Ted Yu commented on HBASE-21283: {{getRegionStatesInTransition}} returns {{List}} Would the multiple

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642620#comment-16642620 ] Ted Yu commented on HBASE-21149: It seems the Warning was due to check during concatenation phase of

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642469#comment-16642469 ] Ted Yu commented on HBASE-21149: See the attached test output above. >

[jira] [Commented] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642312#comment-16642312 ] Ted Yu commented on HBASE-21149: I reproduced test error running against hadoop 3.1.1 : {code} [ERROR]

[jira] [Updated] (HBASE-21149) TestIncrementalBackupWithBulkLoad may fail due to file copy failure

2018-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21149: --- Attachment: testIncrementalBackupWithBulkLoad-output.txt > TestIncrementalBackupWithBulkLoad may fail due

[jira] [Updated] (HBASE-21230) BackupUtils#checkTargetDir doesn't compose error message correctly

2018-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21230: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was:

[jira] [Updated] (HBASE-21279) Split TestAdminShell into several tests

2018-10-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21279: --- Attachment: testAdminShell-output.tar.gz > Split TestAdminShell into several tests >

[jira] [Created] (HBASE-21279) Split TestAdminShell into several tests

2018-10-08 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21279: -- Summary: Split TestAdminShell into several tests Key: HBASE-21279 URL: https://issues.apache.org/jira/browse/HBASE-21279 Project: HBase Issue Type: Test

[jira] [Updated] (HBASE-21216) TestSnapshotFromMaster#testSnapshotHFileArchiving is flaky

2018-10-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21216: --- Description: >From

[jira] [Updated] (HBASE-21230) BackupUtils#checkTargetDir doesn't compose error message correctly

2018-10-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21230: --- Description: Here is related code from BackupUtils#checkTargetDir: {code} String expMsg =

[jira] [Updated] (HBASE-21238) MapReduceHFileSplitterJob#run shouldn't call System.exit

2018-10-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21238: --- Labels: mapreduce (was: ) > MapReduceHFileSplitterJob#run shouldn't call System.exit >

[jira] [Updated] (HBASE-21219) Hbase incremental backup fails with null pointer exception

2018-10-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21219: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks

[jira] [Commented] (HBASE-21219) Hbase incremental backup fails with null pointer exception

2018-10-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640845#comment-16640845 ] Ted Yu commented on HBASE-21219: Ping [~vrodionov] If you agree with my comment above, I can adjust the

[jira] [Updated] (HBASE-21272) Re-add assertions for RS Group admin tests

2018-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21272: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks

[jira] [Commented] (HBASE-21273) Move classes out of org.apache.spark namespace

2018-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640488#comment-16640488 ] Ted Yu commented on HBASE-21273: lgtm > Move classes out of org.apache.spark namespace >

[jira] [Updated] (HBASE-21272) Re-add assertions for RS Group admin tests

2018-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21272: --- Attachment: 21272.branch-1.01.patch > Re-add assertions for RS Group admin tests >

[jira] [Updated] (HBASE-21272) Re-add assertions for RS Group admin tests

2018-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21272: --- Status: Patch Available (was: Open) > Re-add assertions for RS Group admin tests >

[jira] [Created] (HBASE-21272) Re-add assertions for RS Group admin tests

2018-10-05 Thread Ted Yu (JIRA)
Ted Yu created HBASE-21272: -- Summary: Re-add assertions for RS Group admin tests Key: HBASE-21272 URL: https://issues.apache.org/jira/browse/HBASE-21272 Project: HBase Issue Type: Test

[jira] [Commented] (HBASE-21265) Split up TestRSGroups

2018-10-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639225#comment-16639225 ] Ted Yu commented on HBASE-21265: {code} public class IntegrationTestRSGroup extends TestRSGroupsBase {

[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface

2018-10-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638994#comment-16638994 ] Ted Yu commented on HBASE-21246: Now that design doc is back to review mode, please allow some more time

[jira] [Commented] (HBASE-21265) Split up TestRSGroups

2018-10-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637685#comment-16637685 ] Ted Yu commented on HBASE-21265: +1 > Split up TestRSGroups > - > >

[jira] [Updated] (HBASE-21221) Ineffective assertion in TestFromClientSide3#testMultiRowMutations

2018-10-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21221: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Ineffective assertion in

[jira] [Commented] (HBASE-20690) Moving table to target rsgroup needs to handle TableStateNotFoundException

2018-10-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636295#comment-16636295 ] Ted Yu commented on HBASE-20690: Triggered QA run #14566 > Moving table to target rsgroup needs to

[jira] [Comment Edited] (HBASE-21221) Ineffective assertion in TestFromClientSide3#testMultiRowMutations

2018-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634744#comment-16634744 ] Ted Yu edited comment on HBASE-21221 at 10/1/18 11:05 PM: -- I noticed that the

[jira] [Updated] (HBASE-21221) Ineffective assertion in TestFromClientSide3#testMultiRowMutations

2018-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21221: --- Status: Patch Available (was: Reopened) > Ineffective assertion in

[jira] [Reopened] (HBASE-21221) Ineffective assertion in TestFromClientSide3#testMultiRowMutations

2018-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reopened HBASE-21221: > Ineffective assertion in TestFromClientSide3#testMultiRowMutations >

[jira] [Updated] (HBASE-21221) Ineffective assertion in TestFromClientSide3#testMultiRowMutations

2018-10-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21221: --- Attachment: 21221.addendum.txt > Ineffective assertion in TestFromClientSide3#testMultiRowMutations >

<    1   2   3   4   5   6   7   8   9   10   >