[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-31 Thread nspiegelberg (Nicolas Spiegelberg)
nspiegelberg has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". Were you going to remove the unnecessary println()s? REVISION DETAIL https://reviews.facebook.net/D111

[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-31 Thread Liyin (Liyin Tang)
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". Thanks Mikhail's and Nicolas's review and response the comments inline. I will update the diff to address the comments. INLINE COMMENTS src/main/java/org/apa

[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-31 Thread mbautin (Mikhail Bautin)
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". A few more comments -- coding style only. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70 Code style: add an empty

[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-31 Thread nspiegelberg (Nicolas Spiegelberg)
nspiegelberg has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137 I would remove this line. We should only print out inform

[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-28 Thread Liyin (Liyin Tang)
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". Thanks Mikhail for reviewing. Response the comments inline. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:137 I agree

[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-28 Thread mbautin (Mikhail Bautin)
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 A follow-up comment after discussing this offline: rename startKey to

[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-28 Thread mbautin (Mikhail Bautin)
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". A few comments inline: INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:137 What happens otherwise? I think we need to

[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

2011-10-28 Thread Liyin (Liyin Tang)
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 After discussed it offline with Mikhail, we agreed on just renaming it