Apache9 commented on a change in pull request #2034:
URL: https://github.com/apache/hbase/pull/2034#discussion_r452602900



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
##########
@@ -85,6 +90,12 @@ public void sync(boolean forceSync) throws IOException {
     } else {
       fsdos.hflush();
     }
+    AtomicUtils.updateMax(this.syncedLength, fsdos.getPos());

Review comment:
       Good. Anyway I think this could be another issue to just remove the 
AtomicUtils class? The current PR is backport so we'd better keep it in sync 
with the one applied to master.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to