[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r953651328 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java: ## @@ -154,6 +154,18 @@ public class HttpServer implements FilterContainer { public static fin

[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r953649099 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoopServlet.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r953648382 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoopServlet.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r953647493 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java: ## @@ -784,6 +787,22 @@ protected void addDefaultServlets(ContextHandlerCollection contexts, Con

[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r947551006 ## hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsExportHelper.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r946323840 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoopServlet.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r943466191 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoop2Servlet.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

Apache9 commented on code in PR #4691: URL: https://github.com/apache/hbase/pull/4691#discussion_r942426722 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoop2Servlet.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (