[GitHub] [hbase] Apache9 commented on a diff in pull request #4838: HBASE-27440 fix table HistogramMetrics leak in table metrics map

[GitBox]

Apache9 commented on code in PR #4838:
URL: https://github.com/apache/hbase/pull/4838#discussion_r1001465344


##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java:
##########
@@ -532,4 +534,9 @@ public void clearMetrics() {
     }
     metricsMap.clear();
   }
+
+  @VisibleForTesting

Review Comment:
   We do not allow VisibleForTesting annotation now.
   
   Please use RestrictedApi to restrict the usage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org