Apache9 commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914295943
Only a few places need to polish, first is how to merge configurations, second is that I do not think we need to catch the exception for ReflectionUtils.newInstance and rethrow it. Other parts are fine, just some nits. PTAL at the remaining comments for more details. @wchevreuil We are almost done :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org