[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-545712558 Failed tests is not related to this PR. Tests has broken since #745, and Those will be fixed at #748.

[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-545873597 I made a typo when i fixed checkstyle warnings 😭 (https://github.com/apache/hbase/pull/749/commits/a8244d20

[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-547708224 added a minor fix in test code and rebased. ---

[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-548307708 Thanks for the review! > there are few variable/method renaming, moving to different class, just for

[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-550234489 ![image](https://user-images.githubusercontent.com/15886396/68287850-bf3a1200-00c6-11ea-9b96-87b3a2826d

[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-554897893 Failed tests are unrelated to this PR, and not reproduced in my local env. ![image](https://user-ima

[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-558894591 No further comments on this PR? If any lacks of description or something for code reviews, please let me kn

[GitHub] [hbase] JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated

JeongDaeKim commented on issue #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#issuecomment-564501788 > We might want to expose ReplicationSourceWALReaderThread.lastReadPosition, in order to eventually have an