apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850751391
I'm still waiting for tests to finish. Things look fine so far, want to be
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850572028
Thanks for the approvals. I'm going to rebase, run tests locally, and merge
if things look good.
--
This is an automated message from the Apache Git Service.
To respond to the
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850571678
> It looks like, unless we are too specific about elapsed time that we want
only nanosecond level elapsed time, we should prefer System#currentTimeMillis
for the perf benefit.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850569022
> But sometimes we use System.currentTimeMillis just for calculating elapsed
time, not for getting system clock, I'm not sure if this is also our goal here,
to also replace these
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849872794
> What about System.nanoTime?
@Apache9 System.nanotime is not used to get the system clock. I don't mind
bringing it into EnvironmentEdge but I don't care about it here. It
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849871673
TestWALEntryStream failure is not related. It is because of HBASE-25924,
which I have reopened.
--
This is an automated message from the Apache Git Service.
To respond to the
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849192021
Update fixes a checkstyle nit in SimpleServerRpcConnection. The rest of them
aren't mine.
--
This is an automated message from the Apache Git Service.
To respond to the message
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849094550
Rebase and fix
TestRegionServerReportForDuty#testReportForDutyWithEnvironmentEdge.
This test injected ManualEnvironmentEdge and never incremented the time. It
doesn't matt
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848374865
Update fixes TestSimpleRpcScheduler and TestBackupDelete and checkstyle and
javadoc nits.
--
This is an automated message from the Apache Git Service.
To respond to the message
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848192638
Two test failures were relevant. Updating patch soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
10 matches
Mail list logo