[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread via GitHub
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1083200018 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java: ## @@ -340,19 +357,21 @@ public Job createSubmittableJob(String[] args) throws IO

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread via GitHub
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1083067144 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java: ## @@ -88,19 +104,23 @@ protected WALPlayer(final Configuration c) { */ @De

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082074168 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, Li

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082074168 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, Li

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082004856 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081946531 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java: ## @@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean sh

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[] combineTableNameSuffix(by

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[] combineTableNameSuffix(by

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081934099 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081932511 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[] combineTableNameSuffix(by

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081929395 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, Li

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081926702 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, Li

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-09 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1064748623 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +255,19 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-04 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1061515529 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +255,19 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-03 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1060973517 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +255,19 @@ public void write(ImmutableBytesWritable row, V