[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5363: HBASE-28008 Add support for netty tcnative

2023-09-12 Thread via GitHub
bbeaudreault commented on code in PR #5363: URL: https://github.com/apache/hbase/pull/5363#discussion_r1322984856 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -131,6 +137,34 @@ private static String[] getCBCCiphers() { private stati

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5363: HBASE-28008 Add support for netty tcnative

2023-09-12 Thread via GitHub
bbeaudreault commented on code in PR #5363: URL: https://github.com/apache/hbase/pull/5363#discussion_r1322983399 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -83,9 +88,10 @@ public final class X509Util { public static final String

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5363: HBASE-28008 Add support for netty tcnative

2023-08-21 Thread via GitHub
bbeaudreault commented on code in PR #5363: URL: https://github.com/apache/hbase/pull/5363#discussion_r1300378770 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -234,11 +272,23 @@ public static SslContext createSslContextForClient(Confi