bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1255285105
@Apache9 sorry, but any idea why this keeps continually failing?
https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4724/15/pipeline/
htt
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1255213876
Pre-commit is weirdly failing trying to checkout from git. I just squashed,
rebased, and force pushed. No code changes.
--
This is an automated message from the Apache Git Service.
T
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1255094102
Thanks for all the guidance and review here, Duo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1252976475
Test failures are real but I ran out of time today. Will fix them up
tomorrow morning
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1250140413
@Apache9 @meszibalu any chance I could get a quick review on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1242505172
Test failures are unrelated.
Spotbugs failure also unrelated.
This PR is good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the messag
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1241946893
Just pushed a commit to fix the checkstyle/errorprone failures -- I cant
seem to run them locally, so we'll see.
The spotbugs failure seems to both be wrong and unrelated to my c
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1239591155
Yea, I was wondering we should add it to yours. I had started submitting a
suggestion comment. But actually I think it might need a larger refactor to
make it make sense relative to th
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1236902293
@Apache9 any chance you can take a look at this? It's just a backport from
zk like the other recent TLS patches, mostly copied except for the new
end-to-end tests I added.
--
This
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1226030954
@anmolnar I can't assign you as a reviewer, but would appreciate a look when
you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message,
bbeaudreault commented on PR #4724:
URL: https://github.com/apache/hbase/pull/4724#issuecomment-1226019986
I've added comprehensive tests (about 250 test cases covering all
permutations). I also marked with comments the files which are copied from ZK
unchanged.
--
This is an automated me
11 matches
Mail list logo
