[GitHub] [hbase] belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId

2020-01-03 Thread GitBox
belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId URL: https://github.com/apache/hbase/pull/910#issuecomment-570588185 @saintstack Yes and I too am trying to raise the bar here and clean things up. Thanks for catching that! I've removed it. ---

[GitHub] [hbase] belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId

2019-12-30 Thread GitBox
belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId URL: https://github.com/apache/hbase/pull/910#issuecomment-569733506 @busbey You able to take another swing at this? This is an automated message fr

[GitHub] [hbase] belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId

2019-12-26 Thread GitBox
belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId URL: https://github.com/apache/hbase/pull/910#issuecomment-569086691 @busbey Thanks for that. Embarrassing mistake on my part, to say the least. I addressed this and also updated the JavaDocs to talk about

[GitHub] [hbase] belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId

2019-12-09 Thread GitBox
belugabehr commented on issue #910: HBASE-23378: Clean Up FSUtil setClusterId URL: https://github.com/apache/hbase/pull/910#issuecomment-563408977 @HorizonNet When you are too helpful, you get asked to do more. :) Can you please also take a look at this PR as well? --