[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2020-01-13 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-573888707 > @apurtell, @saintstack no further comments? I'd like to merge this one today. Just had an offline chat with @apurtell about this

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2020-01-09 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-572742767 Rebased on top of my other patch that was merged few minutes ago. This i

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2020-01-09 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-572699482 I was mentioning this to @ndimiduk offline but just wanted to update here too, for the record. JUnit BeforeParam does not work for us as

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2020-01-08 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-572324821 Works for me. Try re-running? I noticed the mini cluster in cluster is very flaky, especially when you run it in a dev setup. --

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2020-01-07 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-571830020 > [ERROR] org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor.testCheckAndDeleteWithCompareOp[0] Time elapsed: 0.142 s <<

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2020-01-03 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-570749954 Fixed the check style issues and rebased on the latest tip of the feature branch (and squashed all the commits). Test failures seem to be

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2019-12-31 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-569974349 @saintstack / @apurtell Any thoughts on the new design? Happy to address any concerns. Thanks. -

[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation

2019-12-26 Thread GitBox
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-569152093 Fixed all the test failures from the last run in the latest push. One of the fixes comes in as a separate PR to master https://github.co