[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-09-07 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-688329992 Thank you very much for taking a look at this! @Apache9 I will commit this tomorrow if no objection.

[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-09-06 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-688042384 Ping @Apache9 @joshelser Thanks. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-09-05 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-687573231 BTW, this change doesn't break `org.apache.hadoop.hbase.client.TestAsyncTableNoncedRetry` that checks the nonce operation logic. Thanks.

[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-09-02 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-686173812 @Apache9 @joshelser Can you please review this? I think no behavior change other than what I commented as follows after this change:

[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-31 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-683613568 Looks the QA is okay. I moved the nonce operation logic to HRegion.batchMutate() to keep the behavior of the nonce operation. Can you please review this when you have

[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-21 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-678094914 Ping @joshelser @Apache9. Thanks. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-11 Thread GitBox
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-672537814 @Apache9 @joshelser Can you please review this when you have time? Thank you in advance. This is an automated