[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-27 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r478804228 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -537,8 +537,8 @@ def assign(region_name) #---

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-13 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r470429209 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java ## @@ -80,9 +78,6 @@ protected void serializeStateD

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-13 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r470428399 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -537,8 +537,8 @@ def assign(region_name) #---

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-13 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r470424739 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java ## @@ -508,35 +508,57 @@ default void postAssign(final Obse

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-13 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r470423500 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java ## @@ -508,35 +508,57 @@ default void postAssign(final Obse

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-13 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r470423388 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java ## @@ -508,35 +508,57 @@ default void postAssign(final Obse

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-13 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r470422725 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java ## @@ -591,7 +596,11 @@ * @param forcible If true, force unassign

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-13 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r470422377 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -784,9 +791,12 @@ default void move(byte[] encodedRegionName, byte[]