[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-08-19 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-676876548 Ping. @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-08-11 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-671762822 Ping. @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-22 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-662385535 @Apache9 Ping. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-20 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-660977509 There are no different between build-6 and build-7, and the latter failed on jdk8, seems unrelated to this PR.

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-20 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-660948017 > Is this relevant for non-prod deployments using local FS only? Yeah. This is an automated message from the

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-20 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-660914954 The failture test on jdk11 is TestRegionServerReportForDuty, due to time out, seems unrelated to this PR. This is

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-19 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-660782480 > Is the operation expensive? In my local env, the code below cost about 1μs~200μs, avg<5μs, much lesser than 1ms. ``` try { currentHost =

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-19 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-660761034 > > > > In distributed mode, this code would not make effect, because no host named "localhost". > > > > > > > > > Is this a strong assumption? > > > > > > Not

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654588129 > > In distributed mode, this code would not make effect, because no host named "localhost". > > Is this a strong assumption? Not strong enough...maybe i can add a

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654562715 The hostAndWeights stores weight of hosts for a region, currently the hosts in special mode has a bit diff, shows below. ``` #local mode(run by IDEA in windows)

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-07-06 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-654043899 @Apache9 Any more comments? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] bsglz commented on pull request #1909: HBASE-24569 Get hostAndWeights in addition using localhost if it is n…

2020-06-27 Thread GitBox
bsglz commented on pull request #1909: URL: https://github.com/apache/hbase/pull/1909#issuecomment-650525663 > I do not fully understand the logic here, why it is OK to use localhost if the returned hostAndWeight is null? We will only use the related methods to get hostAndWeight for the