[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649647335 @saintstack When doing the change, I found some places that also set the forceFlushAllStores true, such as HRegion.bulkLoadHFiles, HRegion.flush and many unit tests. I

[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649647335 @saintstack When do the change, I found some places that also set the forceFlushAllStores true, such as HRegion.bulkLoadHFiles, HRegion.flush and some unit tests. If w

[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-03 Thread GitBox
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560 @saintstack @Apache9 Help to review it if you have time, Thanks. This is an automated message from the Apache

[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-05-29 Thread GitBox
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-635781375 > This is a change to a fundamental API. Looks good. Does it make a difference being able to flush on family only? Yeah, if we want to use many families in a table, it