[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-25 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-535307798 > compile | 0m 17s | root in branch-1 failed with JDK v1.7.0_232. This is concerning, but unrelated. I'll cha

[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-25 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-535203894 I plan to merge this tonight and get it back-ported to branch-1.4 as well, unless someone else has more feedback. -

[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-25 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-535187479 Building with `-P release` fails while checking the shaded jars for correctness. Need to update `hbase-shade

[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-25 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-535120241 Okay! a new version of the hbase-thirdparty library is out now and includes a jdk7 compatible relocated GSON.

[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-19 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-533376069 I have some ideas on moving this forward. discussion on [HBASE-23052](https://issues.apache.org/jira/browse/HBASE-23

[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-16 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-532057453 ugh. Can't believe I didn't think of jdk requirements. Just built this on branch-1 with `-P release` so I'd have sha

[GitHub] [hbase] busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587)

2019-09-14 Thread GitBox
busbey commented on issue #616: HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) URL: https://github.com/apache/hbase/pull/616#issuecomment-531473215 This is looking great! I still need to try using it with a downstream project and after that I think it'll be good t